wgtpkg-digsig: Fix digital signature check 21/15421/2
authorJosé Bollo <jose.bollo@iot.bzh>
Tue, 17 Jul 2018 08:42:04 +0000 (10:42 +0200)
committerJosé Bollo <jose.bollo@iot.bzh>
Tue, 17 Jul 2018 09:26:52 +0000 (11:26 +0200)
The compute of the return code was wrong: it always
returned 0 even in case of error.

Installation of a widget with an error in its signature
was possible due to this error.

Bug-AGL: SPEC-1590

Change-Id: Ibefd74aafd6a00dea32e52d471460cbe08a380ab
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
src/wgtpkg-digsig.c

index 4460bf2..a1cb55f 100644 (file)
@@ -347,7 +347,7 @@ int check_all_signatures()
        for (i = n ; i-- > 0 ; ) {
                fdesc = signature_of_index(i);
                irc = verify_digsig(fdesc);
-               if (!irc)
+               if (irc < 0)
                        rc = irc;
        }