From: José Bollo <jose.bollo@iot.bzh>
Date: Tue, 17 Jul 2018 08:42:04 +0000 (+0200)
Subject: wgtpkg-digsig: Fix digital signature check
X-Git-Tag: flounder/5.99.3~3
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?p=src%2Fapp-framework-main.git;a=commitdiff_plain;h=f97f8d24a1971117bbd4057ca0cd00776bcccb39

wgtpkg-digsig: Fix digital signature check

The compute of the return code was wrong: it always
returned 0 even in case of error.

Installation of a widget with an error in its signature
was possible due to this error.

Bug-AGL: SPEC-1590

Change-Id: Ibefd74aafd6a00dea32e52d471460cbe08a380ab
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---

diff --git a/src/wgtpkg-digsig.c b/src/wgtpkg-digsig.c
index 4460bf2..a1cb55f 100644
--- a/src/wgtpkg-digsig.c
+++ b/src/wgtpkg-digsig.c
@@ -347,7 +347,7 @@ int check_all_signatures()
 	for (i = n ; i-- > 0 ; ) {
 		fdesc = signature_of_index(i);
 		irc = verify_digsig(fdesc);
-		if (!irc)
+		if (irc < 0)
 			rc = irc;
 	}