Code Review
/
src
/
xds
/
xds-gdb.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
|
inline
| side by side (parent:
295f712
)
Check go version because xds-common request go > v1.8.1
v0.2.0
author
Sebastien Douheret
<sebastien.douheret@iot.bzh>
Thu, 30 Nov 2017 15:28:36 +0000
(16:28 +0100)
committer
Sebastien Douheret
<sebastien.douheret@iot.bzh>
Thu, 30 Nov 2017 15:59:09 +0000
(16:59 +0100)
Makefile
patch
|
blob
|
history
diff --git
a/Makefile
b/Makefile
index
f786abd
..
0088519
100644
(file)
--- a/
Makefile
+++ b/
Makefile
@@
-23,7
+23,9
@@
TARGET=xds-gdb
# Retrieve git tag/commit to set version & sub-version strings
GIT_DESC := $(shell git describe --always --tags)
VERSION := $(firstword $(subst -, ,$(GIT_DESC)))
# Retrieve git tag/commit to set version & sub-version strings
GIT_DESC := $(shell git describe --always --tags)
VERSION := $(firstword $(subst -, ,$(GIT_DESC)))
-SUB_VERSION := $(subst $(VERSION)-,,$(GIT_DESC))
+ifeq (-,$(findstring -,$(GIT_DESC)))
+ SUB_VERSION := $(subst $(VERSION)-,,$(GIT_DESC))
+endif
ifeq ($(VERSION), )
VERSION := unknown-dev
endif
ifeq ($(VERSION), )
VERSION := unknown-dev
endif
@@
-56,6
+58,14
@@
PACKAGE_DIR := $(ROOT_SRCDIR)/package
export GOPATH := $(shell go env GOPATH):$(ROOT_GOPRJ)
export PATH := $(PATH):$(LOCAL_TOOLSDIR)
export GOPATH := $(shell go env GOPATH):$(ROOT_GOPRJ)
export PATH := $(PATH):$(LOCAL_TOOLSDIR)
+# Check Go version
+GOVERSION := $(shell go version |grep -o '[0-9\.]*'|head -n 1)
+GOVERMAJ := $(shell echo $(GOVERSION) |cut -f1 -d.)
+GOVERMIN := $(shell echo $(GOVERSION) |cut -f2 -d.)
+CHECKGOVER := $(shell [ $(GOVERMAJ) -gt 1 -o \( $(GOVERMAJ) -eq 1 -a $(GOVERMIN) -ge 8 \) ] && echo true)
+CHECKERRMSG := "ERROR: Go version 1.8.1 or higher is requested (current detected version: $(GOVERSION))."
+
+
VERBOSE_1 := -v
VERBOSE_2 := -v -x
VERBOSE_1 := -v
VERBOSE_2 := -v -x
@@
-83,7
+93,7
@@
endif
all: vendor build
.PHONY: build
all: vendor build
.PHONY: build
-build:
+build:
checkgover
@echo "### Build $(TARGET) (version $(VERSION), subversion $(SUB_VERSION) - $(BUILD_MODE))";
@cd $(ROOT_SRCDIR); $(BUILD_ENV_FLAGS) go build $(VERBOSE_$(V)) -i -o $(LOCAL_BINDIR)/$(TARGET)$(EXT) -ldflags "$(GO_LDFLAGS) -X main.AppVersion=$(VERSION) -X main.AppSubVersion=$(SUB_VERSION)" -gcflags "$(GO_GCFLAGS)" .
@echo "### Build $(TARGET) (version $(VERSION), subversion $(SUB_VERSION) - $(BUILD_MODE))";
@cd $(ROOT_SRCDIR); $(BUILD_ENV_FLAGS) go build $(VERBOSE_$(V)) -i -o $(LOCAL_BINDIR)/$(TARGET)$(EXT) -ldflags "$(GO_LDFLAGS) -X main.AppVersion=$(VERSION) -X main.AppSubVersion=$(SUB_VERSION)" -gcflags "$(GO_GCFLAGS)" .
@@
-104,6
+114,10
@@
clean:
distclean: clean
rm -rf $(LOCAL_BINDIR) $(ROOT_SRCDIR)/tools glide.lock vendor $(ROOT_SRCDIR)/*.zip
distclean: clean
rm -rf $(LOCAL_BINDIR) $(ROOT_SRCDIR)/tools glide.lock vendor $(ROOT_SRCDIR)/*.zip
+.PHONY: scripts
+scripts:
+ @mkdir -p $(LOCAL_BINDIR) && cp -rf scripts/*.sh scripts/xds-utils $(LOCAL_BINDIR)
+
.PHONY: release
release:
RELEASE=1 make -f $(ROOT_SRCDIR)/Makefile clean build
.PHONY: release
release:
RELEASE=1 make -f $(ROOT_SRCDIR)/Makefile clean build
@@
-149,6
+163,12
@@
tools/glide:
curl --silent -L https://glide.sh/get | GOBIN=$(LOCAL_TOOLSDIR) sh; \
}
curl --silent -L https://glide.sh/get | GOBIN=$(LOCAL_TOOLSDIR) sh; \
}
+.PHONY:
+checkgover:
+ @test "$(CHECKGOVER)" = "true" || { echo $(CHECKERRMSG); exit 1; }
+
+
+.PHONY: help
help:
@echo "Main supported rules:"
@echo " all (default)"
help:
@echo "Main supported rules:"
@echo " all (default)"