Fix horrendously wrong Volume check in Audio plugin
authorManuel Bachmann <manuel.bachmann@iot.bzh>
Tue, 23 Feb 2016 12:15:24 +0000 (13:15 +0100)
committerManuel Bachmann <manuel.bachmann@iot.bzh>
Tue, 23 Feb 2016 12:15:24 +0000 (13:15 +0100)
Volume bound check was always false.

Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
plugins/audio/audio-api.c

index 637f9d0..9c9da25 100644 (file)
@@ -190,7 +190,7 @@ STATIC json_object* volume (AFB_request *request) {      /* AFB_SESSION_CHECK */
         volume_i = strtok (volume_i, ",");
         volume[0] = atoi (volume_i);
 
-        if (100 < volume[0] < 0) {
+        if ((100 < volume[0])||(volume[0] < 0)) {
             free (volume_i);
             request->errcode = MHD_HTTP_SERVICE_UNAVAILABLE;
             return (jsonNewMessage (AFB_FAIL, "Volume must be between 0 and 100"));