desktop: Do not attempt to advertise the clients if there are none 56/25556/2
authorMarius Vlad <marius.vlad@collabora.com>
Thu, 12 Nov 2020 21:31:24 +0000 (23:31 +0200)
committerMarius Vlad <marius.vlad@collabora.com>
Tue, 17 Nov 2020 10:11:35 +0000 (12:11 +0200)
Clients not binding to agl_shell_desktop will cause spurious signal
emits when they commit the changes. Make sure we only attempt to
advertise if the are clients.

Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
Change-Id: I5c790b105b7c7f7d759e8a8fc2c64713df22d561

src/desktop.c

index 8fe6f7d..f7d11b1 100644 (file)
@@ -268,7 +268,8 @@ desktop_committed(struct weston_desktop_surface *dsurface,
                surface->checked_pending = true;
        }
 
-       if (!surface->advertised_on_launch)
+       if (!surface->advertised_on_launch &&
+           !wl_list_empty(&surface->ivi->desktop_clients))
                wl_signal_emit(&surface->signal_advertise_app, surface);
 
        weston_compositor_schedule_repaint(surface->ivi->compositor);