agl-compositor: RDEPENDS fixes 84/28184/2
authorScott Murray <scott.murray@konsulko.com>
Tue, 22 Nov 2022 03:38:11 +0000 (22:38 -0500)
committerJan-Simon Moeller <jsmoeller@linuxfoundation.org>
Wed, 23 Nov 2022 14:04:04 +0000 (14:04 +0000)
Changes:
- Add the required xkeyboard-config RDEPENDS to the agl-compositor
  recipe to avoid surprises if nothing else that pulls that in is
  in an image.
- Move the agl-compositor RDEPENDS on polkit directly into the
  recipe instead of getting indirectly via a meta-oe presence
  driven addition to packagegroup-agl-graphical-weston.  This is
  more correct, avoids surprises if that packagegroup happens to
  not be used, and will work better with a binary packagefeed.
  The RDEPENDS is still conditional on the presence of "polkit" in
  DISTRO_FEATURES, which seems a reasonable alternative to using
  dynamic-layers.

Bug-AGL: SPEC-4619

Change-Id: I595f55a9d598b4a15fe345f50d1a7a203616dd15
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/28184
Tested-by: Jenkins Job builder account
ci-image-build: Jenkins Job builder account
ci-image-boot-test: Jenkins Job builder account
Reviewed-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston.bbappend [deleted file]
meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston_aglcore.inc [deleted file]
meta-agl-core/recipes-graphics/wayland/agl-compositor_git.bb

diff --git a/meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston.bbappend b/meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston.bbappend
deleted file mode 100644 (file)
index 0db6066..0000000
+++ /dev/null
@@ -1 +0,0 @@
-require ${@bb.utils.contains('AGL_FEATURES', 'aglcore', 'packagegroup-agl-graphical-weston_aglcore.inc', '', d)}
diff --git a/meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston_aglcore.inc b/meta-agl-core/dynamic-layers/meta-oe/recipes-platform/packagegroups/packagegroup-agl-graphical-weston_aglcore.inc
deleted file mode 100644 (file)
index 6167f45..0000000
+++ /dev/null
@@ -1 +0,0 @@
-RDEPENDS:${PN} += "polkit"
index 68bc4e8..29b3c27 100644 (file)
@@ -34,6 +34,8 @@ FILES:${PN} = " \
 
 RDEPENDS:${PN} += " \
     agl-compositor-init \
+    xkeyboard-config \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'polkit', d)} \
     ${@bb.utils.contains('AGL_FEATURES', 'waltham-remoting', 'waltham waltham-transmitter-plugin', '', d)} \
 "