aglsetup: check build dir integrity (no spaces) 41/8541/3
authorStephane Desneux <stephane.desneux@iot.bzh>
Tue, 21 Feb 2017 17:58:20 +0000 (18:58 +0100)
committerJan-Simon Moeller <jsmoeller@linuxfoundation.org>
Wed, 1 Mar 2017 23:37:03 +0000 (23:37 +0000)
The absolute build path shouldn't contain any space.
Discussion: https://lists.linuxfoundation.org/pipermail/automotive-discussions/2017-February/003522.html

Change-Id: If3de580a2a8fd0f944c40f669a9fcd2de7e1f04b
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
scripts/.aglsetup_genconfig.bash

index af2b747..48af0fb 100755 (executable)
@@ -67,6 +67,13 @@ function list_all_machines() {
        done
 }
 
+function validate_builddir() {
+       if [[ "$BUILDDIR" =~ [[:space:]] ]]; then
+               error "Build dir '$BUILDDIR' shouldn't contain any space"
+       fi
+       debug "Build dir is valid"
+}
+
 function validate_machines() {
        list_all_machines | sort | uniq -c | while read cnt machine; do
                [[ $cnt == 1 ]] && continue
@@ -335,7 +342,8 @@ done
 
 # validate build dir
 debug "validating builddir $BUILDDIR"
-BUILDDIR=$(mkdir -p $BUILDDIR && cd $BUILDDIR && pwd -P)
+BUILDDIR=$(mkdir -p "$BUILDDIR" && cd "$BUILDDIR" && pwd -P)
+validate_builddir
 
 ###########################################################################################
 function dump_log() {