From 2fed63ed0087df0c79f7f30f7f397611381bfccd Mon Sep 17 00:00:00 2001 From: Sebastien Douheret Date: Thu, 24 Aug 2017 17:09:57 +0200 Subject: [PATCH] Fixed /exec command (don't prefix command with exec binary). adding 'exec' prevents to use "script" syntax: xds-exec -c xds-config.env -- "cd build && cmake .." But 'exec' binary is mandatory to allow to pass correctly signals to subprocess such as gdb. As workaround, exec is set for now on client side (eg. in xds-gdb). --- lib/apiv1/exec.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/apiv1/exec.go b/lib/apiv1/exec.go index 4a591be..6300dba 100644 --- a/lib/apiv1/exec.go +++ b/lib/apiv1/exec.go @@ -135,10 +135,13 @@ func (s *APIService) execCmd(c *gin.Context) { } } - // FIXME - SEB: exec prevents to use syntax: - // xds-exec -l debug -c xds-config.env -- "cd build && cmake .." cmd = append(cmd, "cd", folder.GetFullPath(args.RPath)) - cmd = append(cmd, "&&", "exec", args.Cmd) + // FIXME - add 'exec' prevents to use syntax: + // xds-exec -l debug -c xds-config.env -- "cd build && cmake .." + // but exec is mandatory to allow to pass correctly signals + // As workaround, exec is set for now on client side (eg. in xds-gdb) + //cmd = append(cmd, "&&", "exec", args.Cmd) + cmd = append(cmd, "&&", args.Cmd) // Process command arguments cmdArgs := make([]string, len(args.Args)+1) -- 2.16.6