From 425458b99b65ada911c21ba1896a5733541e5170 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Bollo?= Date: Wed, 4 Jul 2018 15:58:02 +0200 Subject: [PATCH] afb-trace: Fix bug in tracing of afb_req_get_client_info MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The utility wrap-json distinguishes o from O, the latest increment the reference count, as expected. Bug-AGL: SPEC-1563 Change-Id: I4490ac894059e47abf1e2474aab07249b862e985 Signed-off-by: José Bollo --- coverage/scripts/02-hello.sh | 5 +---- src/afb-trace.c | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/coverage/scripts/02-hello.sh b/coverage/scripts/02-hello.sh index 916892f7..579a3f06 100755 --- a/coverage/scripts/02-hello.sh +++ b/coverage/scripts/02-hello.sh @@ -44,10 +44,7 @@ hello setctxif "some-text-1" hello getctx hello setctx "some-text-2" hello getctx -#------------------------ -# TODO bug to be fixed! -#hello info -#------------------------ +hello info hello verbose {"level":2,"message":"hello"} EOC diff --git a/src/afb-trace.c b/src/afb-trace.c index 5f54b174..0e285e14 100644 --- a/src/afb-trace.c +++ b/src/afb-trace.c @@ -489,7 +489,7 @@ static void hook_xreq_get_uid(void *closure, const struct afb_hookid *hookid, co static void hook_xreq_get_client_info(void *closure, const struct afb_hookid *hookid, const struct afb_xreq *xreq, struct json_object *result) { - hook_xreq(closure, hookid, xreq, "get_client_info", "{so}", + hook_xreq(closure, hookid, xreq, "get_client_info", "{sO}", "result", result); } -- 2.16.6