From: Jose Bollo <jose.bollo@iot.bzh>
Date: Mon, 29 Jul 2019 09:48:00 +0000 (+0200)
Subject: Fix detection of error in call synchronous
X-Git-Tag: 8.99.1~17
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?p=src%2Fapp-framework-binder.git;a=commitdiff_plain;h=687d90d5f5a7ec8cd6c2b2d5f8a9c6c180c610c0

Fix detection of error in call synchronous

There fixes a bug with an inversion between info
and error in implementation of synchronous calls,
leading to bad detection of errors.

Bug-AGL: SPEC-2697

Change-Id: I30a8cd9c45a91b442f6c501dd3b0c32cd3ea632d
Signed-off-by: Jose Bollo <jose.bollo@iot.bzh>
---

diff --git a/src/afb-calls.c b/src/afb-calls.c
index e30fe364..084250b3 100644
--- a/src/afb-calls.c
+++ b/src/afb-calls.c
@@ -350,7 +350,7 @@ static int do_sync(
 
 	afb_xreq_unhooked_unref(&callreq->xreq);
 interr:
-	return store_reply(NULL, _internal_error_, NULL, object, info, error);
+	return store_reply(NULL, _internal_error_, NULL, object, error, info);
 }
 
 /******************************************************************************/