From: José Bollo <jose.bollo@iot.bzh>
Date: Fri, 8 Feb 2019 12:09:39 +0000 (+0100)
Subject: afb-stub-ws: Fix concurrent memory issues
X-Git-Tag: 7.99.1~52
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?p=src%2Fapp-framework-binder.git;a=commitdiff_plain;h=6415858bb8daa5f0c29392f18e7a230136916ec1

afb-stub-ws: Fix concurrent memory issues

This changes takes care to increment the
the count of reference before using it.

Bug-AGL: SPEC-2163

Change-Id: Ia7882427eeae933eeb5030aad025ebb1da129d6f
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---

diff --git a/src/afb-stub-ws.c b/src/afb-stub-ws.c
index 70c74b65..02070f46 100644
--- a/src/afb-stub-ws.c
+++ b/src/afb-stub-ws.c
@@ -266,6 +266,7 @@ static void client_api_call_cb(void * closure, struct afb_xreq *xreq)
 		return;
 	}
 
+	afb_xreq_unhooked_addref(xreq);
 	rc = afb_proto_ws_client_call(
 			proto,
 			xreq->request.called_verb,
@@ -273,10 +274,10 @@ static void client_api_call_cb(void * closure, struct afb_xreq *xreq)
 			afb_session_uuid(xreq->context.session),
 			xreq,
 			xreq_on_behalf_cred_export(xreq));
-	if (rc >= 0)
-		afb_xreq_unhooked_addref(xreq);
-	else
+	if (rc < 0) {
 		afb_xreq_reply(xreq, NULL, "internal", "can't send message");
+		afb_xreq_unhooked_unref(xreq);
+	}
 }
 
 static void client_on_description_cb(void *closure, struct json_object *data)