From: José Bollo <jose.bollo@iot.bzh>
Date: Thu, 28 Mar 2019 17:59:55 +0000 (+0100)
Subject: afb-args: Use secure_getenv
X-Git-Tag: 7.99.1~28
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?p=src%2Fapp-framework-binder.git;a=commitdiff_plain;h=5715fd569d6f8258830bb1808f9b65bde72cc5cd

afb-args: Use secure_getenv

Improves security of the binder by using
secure_getenv instead of getenv.

Change-Id: Iffd56ca65251763aacb0b9dbbaa768619cd92dd4
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---

diff --git a/src/afb-config.c b/src/afb-config.c
index 1cc84b02..87fad97e 100644
--- a/src/afb-config.c
+++ b/src/afb-config.c
@@ -969,7 +969,7 @@ void afb_config_dump(struct json_object *config)
 
 static void on_environment(struct json_object *config, int optid, const char *name, void (*func)(struct json_object*, int, const char*))
 {
-	char *value = getenv(name);
+	char *value = secure_getenv(name);
 
 	if (value && *value)
 		func(config, optid, value);
@@ -977,7 +977,7 @@ static void on_environment(struct json_object *config, int optid, const char *na
 
 static void on_environment_enum(struct json_object *config, int optid, const char *name, int (*func)(const char*))
 {
-	char *value = getenv(name);
+	char *value = secure_getenv(name);
 
 	if (value) {
 		if (func(value) == -1)
@@ -989,7 +989,7 @@ static void on_environment_enum(struct json_object *config, int optid, const cha
 
 static void on_environment_bool(struct json_object *config, int optid, const char *name)
 {
-	char *value = getenv(name);
+	char *value = secure_getenv(name);
 	int asbool;
 
 	if (value) {