Romain Forlot [Tue, 14 Nov 2017 15:42:05 +0000 (16:42 +0100)]
Fix: config.xml.in template usage
Change-Id: I03f11e2b8954eea0862df5126187f37aae801092
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Nov 2017 08:09:46 +0000 (09:09 +0100)]
Fix wrong filter condition (Thanks Parai Wang)
Change-Id: I7d3eccc2d4b99d543b669c7b3c8d7a38670d860f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 5 Sep 2017 17:03:01 +0000 (19:03 +0200)]
FixDAB: Kernel mandatory and missynchronized
Change-Id: Iabf3531817251aef5843f7f6dc8a94c2c39fe410
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 9 Aug 2017 14:10:41 +0000 (16:10 +0200)]
Improve debugging diag and empty event
Change-Id: I64dd5b3f241a9696dc759dffff884772e3f72fd7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 5 Jul 2017 16:36:17 +0000 (18:36 +0200)]
Can't set compile FLAG using set using Yocto build
If set, then these are the flags that are used by bitbake
without append its own flags which provides toolchain variables
environment mandatory to correctly build for another target.
Change-Id: Id5ddfc11c3d7d2e1eee418989aabaa73a933a41a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Matt Ranostay [Tue, 1 Aug 2017 06:35:41 +0000 (23:35 -0700)]
packaging: add hidden attribute to required permissions
Add urn:AGL:permission::public:hidden to the required
permissions to hide blank icon from HomeScreen
Bug-AGL: SPEC-796
Change-Id: I3c844a5c657d267678fe6ac78caaf99170c0cc53
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
Romain Forlot [Tue, 25 Jul 2017 16:42:06 +0000 (18:42 +0200)]
Make Kernel check not mandatory
Use 2 different checks, one specify a mandatory kernel version
and the other will output a warning and position a preprocessing
variable that can be used in the code to exclude portions of code
that use kernel features not available under a certain version.
Bug-AGL: SPEC-772
Change-Id: I04523abe96749aeeb185e90eee154fd70a4cbf19
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# conf.d/app-templates
Ronan Le Martret [Tue, 18 Jul 2017 15:58:24 +0000 (17:58 +0200)]
fix link option
Change-Id: Ibca245fc8c6ec7c68d24b9c6e693156974f186ef
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
(cherry picked from commit
4a538f440d525a2d01bd892989998dbaf67e5af0)
Romain Forlot [Thu, 20 Jul 2017 08:14:56 +0000 (10:14 +0200)]
Fix: align bindingv2 struct with dab appfw version
DAB Fixes follows appfw API break.
Following functions now return 0 on success and negative value
on failure :
o afb_req_subcall
o afb_req_subcall_sync
o afb_service_call
o afb_service_call_sync
Verbosity macros used in v2 bindings now needs to be prefixed
with AFB_ (ERROR -> AFB_ERROR)
New field for afb_verb_v2 and afb_binding_v2 structures
Fix: uninitialized variables.
Change-Id: Ia728b9ac4576b9b44c8c7c054820b7c64a314942
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Jan-Simon Möller [Sat, 24 Jun 2017 17:51:11 +0000 (19:51 +0200)]
Add .gitreview for dab
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Romain Forlot [Thu, 29 Jun 2017 22:47:42 +0000 (00:47 +0200)]
Update README
Change-Id: Idf39ee8002e4a9f08b0cba487c9b6517acb9aa7f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 29 Jun 2017 13:31:33 +0000 (15:31 +0200)]
Fix: Yocto build failure.
Change-Id: I515bc344f0ff6203eac6f43b2047aa7c5d0fc9aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Ronan Le Martret [Wed, 28 Jun 2017 22:35:21 +0000 (00:35 +0200)]
Fix native build for openSUSE_Tumbleweed
* add library specification "-pthread" to CXX_FLAGS.
fix build error under gcc7 "undefined reference to `pthread_create'"
Change-Id: Ic952682086744f0e3f3e5f292495c7bc8b922316
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
Romain Forlot [Thu, 29 Jun 2017 08:50:44 +0000 (08:50 +0000)]
Fix: autobuild scripts.
Wrong behavior when no DEST variable defined. mkdir failed
and copy too. Now mkdir and copy happens only when DEST is
defined
Change-Id: I8a3701f1f0fae7ecae60195300c3d8d8db4493c7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 28 Jun 2017 16:23:39 +0000 (16:23 +0000)]
Merge "Update config.cmake"
Romain Forlot [Wed, 28 Jun 2017 16:17:25 +0000 (18:17 +0200)]
submodule update and autobuild script generation
Change-Id: I9d434addc928124227f4d60599d30add4f8895b9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Ronan Le Martret [Wed, 28 Jun 2017 16:06:10 +0000 (18:06 +0200)]
Update config.cmake
Change-Id: I24e08bbb2dc735125cea9a9fee18641c21938713
Signed-off-by: Ronan Le Martret <ronan.lemartret@iot.bzh>
Romain Forlot [Wed, 28 Jun 2017 09:39:23 +0000 (11:39 +0200)]
Update to the latest app-templates version
No more needs to call any macro and only include
config.cmake file is mandatory. Common.cmake is include
from config.cmake file
Generation autobuild script in conf.d/autobuild dir
Change-Id: I71a18a91755d76912fd8ff93c66bab231d4db301
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# conf.d/app-templates
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 27 Jun 2017 17:00:16 +0000 (19:00 +0200)]
Update to the latest app-templates version
No more needs to call any macro and only include
config.cmake file is mandatory. Common.cmake is include
from config.cmake file
Generation autobuild script in conf.d/autobuild dir
Change-Id: I71a18a91755d76912fd8ff93c66bab231d4db301
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 26 Jun 2017 16:36:23 +0000 (18:36 +0200)]
Enable check kernel version before build
Upgrade app-template submodule that allows to correctly
check kernel version and uncomment kernel_minimal_version
variable definition.
Change-Id: I97d10e2506a89780fa611dc7f96eafb3f2be29cd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 22 Jun 2017 14:39:32 +0000 (16:39 +0200)]
Permission about car was a test, removing it.
target param isn't necessary because are implicit
Change-Id: I1704f8d28b0d7bf8a156c9dab9c4d37cb4b63347
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 22 Jun 2017 14:37:30 +0000 (16:37 +0200)]
Add some reminder...
Change-Id: Ifb81989c39f31f73ce7dc7dcbebfc6039f6a6a47
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 21 Jun 2017 10:01:12 +0000 (12:01 +0200)]
Needed feature to make binder load the binding
Change-Id: I5c312e082bc710f3d3f381d09be055af4950cd1a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 20 Jun 2017 14:43:28 +0000 (14:43 +0000)]
Review of documentation
Change-Id: I49763cc9264c0121db2950cfee56d69c66d0e4c7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 20 Jun 2017 14:37:08 +0000 (16:37 +0200)]
Move submodule directory
Change-Id: I2c603ab49bab01fd1221147cfe9c97bdacea91a9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 20 Jun 2017 10:24:05 +0000 (10:24 +0000)]
Separation Generator to a dedicated repo
Change-Id: Id94831651c3266861435272a6e36c7884bef2c45
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Sebastien Douheret [Tue, 20 Jun 2017 08:49:55 +0000 (10:49 +0200)]
Update doc revision and pdf cover.
Change-Id: Ia566b39055a39cb14760f3a17b4240690c1a8f56
Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Romain Forlot [Tue, 20 Jun 2017 08:54:29 +0000 (08:54 +0000)]
Add .gitreview
Change-Id: Ie52d9470d792ce3556d3a153316fc7384cd10e64
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 20 Jun 2017 08:11:17 +0000 (08:11 +0000)]
Align with AGL version
And unify prefix with audio binding and others bindings
Change-Id: I685afd2e4c75c813ac9af8ab3281fedc04b9289e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 14 Jun 2017 13:34:11 +0000 (15:34 +0200)]
Now even generator can be built in SDK environment
Change-Id: I7fdcddca9002e8d1cfb21049198d798c8551319c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 12 Jun 2017 10:07:11 +0000 (12:07 +0200)]
Update build and package configuration file.
Change-Id: I9e5f596744479ed21f375e3cdd97c5d68bfa4c7a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 16:11:39 +0000 (18:11 +0200)]
Update documentation PDF metadata
Change-Id: I64aa4cbae216d1ce4b48efaad704a158088b4494
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 16:11:24 +0000 (18:11 +0200)]
Rename submodule path to app-templates as the repo
Change-Id: Ic4c2c5e50a19199614b7f1aaa8e1d2f9992fb3af
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 10:33:30 +0000 (12:33 +0200)]
Update git clone command in documentation
Change-Id: I0cf5fbaed72dfd8602ce9f8e10feb97fa9a17ce4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 09:25:28 +0000 (11:25 +0200)]
Update submodule about cmake templates and config
Change-Id: Ia4cdc62993fd585a89e214d21fdf465d0af3d59b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 07:03:43 +0000 (09:03 +0200)]
Change name and version
Change-Id: Ifaf6850773f94111a9501f7ded85ad4d62797f0b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 07:03:20 +0000 (09:03 +0200)]
Fix: warning at compile time after migration to v2
Change-Id: I7bd4168d74ee0c144cea8ca85f30b5b6928d68f8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 9 Jun 2017 07:02:32 +0000 (09:02 +0200)]
Update documentation
Change-Id: Ieea8476f65433ebd41da2ca992b9984310eb6c5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 8 Jun 2017 13:25:27 +0000 (15:25 +0200)]
Migration to AFB Binding V2
No more binder interface needed to use logging macros and
others stuff like make_event or any other calls
Change-Id: Iaee60697373bc8a0e67518e924b36b5389533e68
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 8 Jun 2017 10:41:09 +0000 (12:41 +0200)]
Comments, Cleanup, format
Change-Id: I9f032cc232e77ce73e889a1656f1ad86cfdec774
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 21:38:19 +0000 (23:38 +0200)]
Cleanup include and prepare to switch binding v2
Change-Id: I032e8ec32c3ff5b2464f2802dd93683752316049
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:42:21 +0000 (15:42 +0200)]
Fix: read 2 times for 1 incoming CAN frame.
Change-Id: I7be7b5e704b3cb081e1dbd73a6ba7f88a2bbc62f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:41:40 +0000 (15:41 +0200)]
Possible uninitialized variable returned.
Change-Id: Id6ffed520aa238304afdddcd37a64e93002196aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:41:00 +0000 (15:41 +0200)]
Add some useful DEBUG information for read frames
Change-Id: I026111942b4b8486b46f56d5fc92fcebde4dc91f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:40:16 +0000 (15:40 +0200)]
Fix: invalid CAN frame read leads to an exception
The frame is reported like before but ignored now.
Change-Id: I8314cdb5fa99d950023bf881c72daea2ef9bb935
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 12:27:33 +0000 (14:27 +0200)]
Improve reliability on multi-threading.
- Limits call to signals_manager and subscribed signals map
- Unlock and lock mutex in the right order to avoid possible dead locks.
Change-Id: Ifb152af833ad8bdde5dc4fc3a27b1a7c27046523
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:29:59 +0000 (01:29 +0200)]
Fix: exception unsubscribe all at start
When unsubscribing but no diagnostic subscription made there
is an exception when cleaning empty requests vector.
Change-Id: I40bdd01969fd1a1c6fecb0a438c46d0df584de83
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:28:21 +0000 (01:28 +0200)]
Fix: c++11 detected and not applied from config
Change-Id: Iedf1f88e142a3f579ada3794b1f0f8813105d880
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:27:24 +0000 (01:27 +0200)]
Fix: unsubscribe from 1 app remove diagnostic req
Let the function on_no_client do the cleaning of the remaining active
diagnostic requests.
Change-Id: I6fc2477d53200e3475f62cd453804827172a99c0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:25:04 +0000 (01:25 +0200)]
Separate low_can_subscription class from callbacks
Change-Id: I682cacca1af53f898ac4c428f823562c50e7cce4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 08:23:51 +0000 (10:23 +0200)]
Update signals.json and generated files.
Adding fake windows signals,
Fix wrong bit_position about doors (not fake signal)
In fact all signals are fake except of doors signals and OBD2
diagnostic messages.
Change-Id: Ia5877bb9720b11b0ff3593788d3e79324b0fa44e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 08:18:08 +0000 (10:18 +0200)]
Update generator at latest low level binding
- renaming configuration to application
- make message_set as a vector of shared_ptr
- Setting up object parent in graphs at application object instanciation
Change-Id: Ib33103d5cebbd9381375d2832582a25ae0f9f199
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 07:21:42 +0000 (09:21 +0200)]
Remove demo UI from the project
Low level CAN binding is a standalone service that doesn't
have to be delivered with an UI.
Change-Id: Ic3995704a63b56f21168e2e9da8e45b3117a0f41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:50:15 +0000 (19:50 +0200)]
Let the thread to be managed outside the binding.
Change-Id: Ib905a3e0ea58a32761c4dda4a391c1d7b311c12a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:49:46 +0000 (19:49 +0200)]
C++ coding style
No changes on the object so it is a const method...
Change-Id: I55b50d0d6fc0dd120f58ca56b6a68172353a5ef5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:48:24 +0000 (19:48 +0200)]
Remove pointer generator that make memory leaks.
Only have 1 place where to generate a pointer from a DiagnosticRequest
is in low-can-cb.cpp when subscribing. Else now using reference instead
of raw pointer.
Change-Id: I7fd2f3d30afa90017b945e6b711922036123b6d3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:45:01 +0000 (19:45 +0200)]
Get diag manager's socket into subscription obj
Subscription index map is the socket ID which implies the following:
- All diagnostic messages subscriptions are stored into a vector
holding diagnostic_message and there is 1 socket for all like the
diag manager did.
- Reworked workflow to open a BCM socket and adding an RX filter more flexible.
- Separated methods to handle on_no_clients event.
- Cleaning diagnostic manager code to remove all unneeded stuff now.
- Embed diagnostic response in VehicleMessage decoded message to be able
transmits the PID in event push thread. This is needed by to correctly handle case
when there is no clients subscribed to an AFB event. Else we can't find
the diagnostic message to remove from low_can_subscription vector.
Change-Id: Iab13fd556cda3c69827bcd67f3a23a03cb6a2cf2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:05:18 +0000 (02:05 +0200)]
Update submodule.
Change-Id: I2f8bc5bbe7325b50c62a40d1f081b5bf771179c8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:03:27 +0000 (02:03 +0200)]
Fix: Handle several subscriptions to a signal
Change-Id: I460bae0056761f6468ca4dc55a594f1529d53c83
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:02:55 +0000 (02:02 +0200)]
Adding accessor to diagnostic msg shared ptr.
Change-Id: I9d32239b3ebd762ab3a337fc734d504ee8dc8c5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:02:20 +0000 (02:02 +0200)]
Change way to validate a subscription object
Better to check validity of 2 differents type of signals
used and checks that its event is valid.
Change-Id: I1435bbe81a43fd80eae049d43b5e37fc8f893074
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:42:39 +0000 (18:42 +0200)]
Fix warning compile
Change-Id: Id0f088f030c0a23b4347c4886a3d756538cbb651
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:18:33 +0000 (18:18 +0200)]
Implement minimum and maximum subscription filters
Change-Id: I6b027cdb37e425e185b8d2278ae775f857ff96bc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:18:07 +0000 (18:18 +0200)]
Better handling of duplicate non recurring request
Change-Id: Ib6015d5dac66751622f3e287429475b6b708c3d5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:17:29 +0000 (18:17 +0200)]
Methods to ease access to DynamicField members
Change-Id: I8974827340e3faf60a511900cbdcf117ce43fb53
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:59:57 +0000 (15:59 +0200)]
Close socket by default when destroying object
As socket is back to only movable, only one copy of a socket
can be present at a time, so when the object is destroyed we have
to close the socket too.
Change-Id: Id64bb53919ce7c24476c26ba9a8520affa3f6273
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:58:44 +0000 (15:58 +0200)]
Delete pointer and content, possible memory leak
Change-Id: I21e65bcaaa444c03bbc634f1d437e6ff363623b6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:58:20 +0000 (15:58 +0200)]
Initializing all struct by default to avoid errors
Change-Id: I54eab7da7e5819f633a5612abe46d44550068aab
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:57:29 +0000 (15:57 +0200)]
Format
Change-Id: Ibbd48a1c0fe0e7567cbf3f5f1c6919e542883924
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:57:24 +0000 (15:57 +0200)]
Left over renaming variable
Following change from configuration_t to application_t some
variable name doesn't correspond now : conf -> app
Change-Id: I56c3a83113777a43af9024a9bc9b53f705b60b0f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:55:53 +0000 (15:55 +0200)]
Fix: Frequency filter doesn't apply on diagnostic
As socket isn't managed by low_can_susbcription yet,
create_rx_filter was just using signal frequency setting.
Now, it take the frequency asked in argument if provided.
Change-Id: If44458b2b0e34df44337670dd9a5b2b58324bfbe
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:48:36 +0000 (13:48 +0200)]
Cleaning
Change-Id: I73e9acf8b3a28db2134cf1f4bcb1b2aa7fd224fc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:48:19 +0000 (13:48 +0200)]
Use UDS PID has key to record subscriptions
can_signal_t use socket number but has for OBD2 diagnostic request
there is only 1 socket to listen all response then we use PID has key
to find the subscription later on the processing.
Change-Id: I5f0554e1a4ac43e1046d9b7b7f9bb00d3a753562
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:46:10 +0000 (13:46 +0200)]
Simplify processing event
Set afb_event into subscription object then there is no more
std::pair used t access it, better use a method from
low_can_subscription_t class
Change-Id: Ic0772d97c18ca8899821cf3ce175166bbe0be660
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 08:33:05 +0000 (10:33 +0200)]
Format
Change-Id: Ib3f8f0c8cbffaf7b5d1acb8c4541526dad03a9c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 08:32:48 +0000 (10:32 +0200)]
Fix: segfault subscribing diagnostic messages
Wrong object used when subscribing.
Change-Id: I356c8cedc57191268ce3ea1838999fbe03472ae2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:43:43 +0000 (09:43 +0200)]
Fix: get signal name no matter type of signal.
One method to return name depending upon which type it is,
can or diagnostic.
Change-Id: I1e96f88654e14316d3afe527fa6fa0d8ddbf410d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:43 +0000 (09:07 +0200)]
Using isnan to define frequency.
Change-Id: Iba93089dc982644898540b286892c436229f38d2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:15 +0000 (09:07 +0200)]
Missing pragma once...
Change-Id: I3088089af5a817ed68ef0276869a01d7323e6ae7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:00 +0000 (09:07 +0200)]
Implement method to filter messages before pushing
Change-Id: I94223ebead4a011a1fb56ed0c3676c433e01319b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:05:08 +0000 (09:05 +0200)]
Split function to call 1 function by signal types.
From signals found process each vector into a separated function
Change-Id: I0c622508eb98a7284606b4f75c825ba48e3fe227
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 23:12:59 +0000 (01:12 +0200)]
Rename method to have same everywhere
Change-Id: I80ceeada376d46f2cfcac259ed86239cc74ea05c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 16:32:49 +0000 (18:32 +0200)]
Fix diagnostic message subscription.
Change-Id: I490ee639e5d524a142e2fbbd928725b7268178aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:28:57 +0000 (17:28 +0200)]
Adding windows CAN signals.
These signals is not the reals ones.
Change-Id: I5f30fcab09f22488a8085f44eb22a97b67214339
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:19:25 +0000 (17:19 +0200)]
YouCompleteMe extra configuration file for IDE
Change-Id: I915cfefcbeadeda56c949a405dc3194edf1faf99
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:14:39 +0000 (17:14 +0200)]
Use default signal frequency if no filter provided
Change-Id: I60bc1cdd62a75b539684032bbb58c38256149944
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:01:54 +0000 (17:01 +0200)]
Retrieve signal last value and timestamp at once.
Change-Id: I8401030ece94b5e397b6d2b71b29ff4e435d1486
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:01:12 +0000 (17:01 +0200)]
Fix: Don't processing filter argument
Filter is a separate json object to get, so using request
arguments to retrieve it.
Change-Id: I0e672a747c95ef5e7ed17dd184697265a18add9c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:09:27 +0000 (12:09 +0200)]
Consider using char* as well as string.
Change-Id: I08aba32f1273c7be305ceacf121e42fddfca173e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:08:13 +0000 (12:08 +0200)]
Clearer call to method
Change-Id: Ibf37a46989ac8d84a56aa43873fdb8bb0e601304
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:07:38 +0000 (12:07 +0200)]
Remove reverse find can_signal from can_message
There is no need to search against can_signal with CAN arbitration id
because a pointer to the signal it maintained through the
low_can_subscription_t object now.
Change-Id: Ia8b3c7074ff86f7e2a8f3ed503ea1abed3bfe51b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:03:02 +0000 (12:03 +0200)]
Use ptr to can_signal instead of copying some members
Change-Id: Ie827559c7da462f59bfe4af8af824f4616c2dd5b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 07:23:19 +0000 (09:23 +0200)]
Missing var declaration
Change-Id: Icbb18bcdeae1d928d3981d21fc547d2940b198bd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 07:23:03 +0000 (09:23 +0200)]
Fix: use of isnan() from std lib
Change-Id: I40ecb409ec1361faa6df8585332f319508bcb464
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
José Bollo [Tue, 30 May 2017 17:21:22 +0000 (19:21 +0200)]
manage unset values with NAN
Change-Id: I144bc110864f507e57d5e4b7f03ee1c0aa61ff63
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
José Bollo [Tue, 30 May 2017 17:20:35 +0000 (19:20 +0200)]
optimise flow
Change-Id: I56d796531120236591f00fdf7a30f0a4495cbef2
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
Romain Forlot [Wed, 31 May 2017 06:59:58 +0000 (08:59 +0200)]
Update submodule to latest version
Change-Id: Ia38494c18ac75409d39525286be07e4b1b610c50
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:46:21 +0000 (12:46 +0200)]
Cleaning
Change-Id: Iba8c7929ced1e2492de94e3a2b1c98dd4eb70b6b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:46:02 +0000 (12:46 +0200)]
Reworked subscription to integrate filtering.
- Creation of an object which old the subscription context
(filter, signal) : low_can_subscription_t
- Move socket from can_signal_t to this new object.
- Adding a member to can_message_t to transport subscription_id to be able to
retrieve it with all the context through running.
Change-Id: I87be8cd6c3c93a81040357920d8c081a316800c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:34:22 +0000 (12:34 +0200)]
Return const structures.
These structures doesn't not have to change after.
Change-Id: I0cc83136c7ee4e5f5cd9c04bf717814e141f98c5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Code Review / apps / low-level-can-service.git / log