From fb66fba2bfdd2f14adf9218e8a6d537c9121ed3c Mon Sep 17 00:00:00 2001 From: Li Xiaoming Date: Fri, 27 Sep 2019 21:01:49 +0800 Subject: [PATCH] fix: Remove qml M126 warning Message: == and != may perform type coercion, use === or !== to avoid it. Description: The non-strict equality comparison is allowed to convert its arguments to a common type. That can lead to unexpected results such as ' \t\r\n' == 0 being true. Use the strict equality operators === and !== and be explicit about conversions you require. Bug-AGL: SPEC-2814 Change-Id: I374749e71705b24eb793e0ba8a5efacc81ea40de Signed-off-by: Li Xiaoming --- homescreen/qml/IconItem.qml | 2 +- homescreen/qml/StatusArea.qml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/homescreen/qml/IconItem.qml b/homescreen/qml/IconItem.qml index a5c032e..ace0628 100644 --- a/homescreen/qml/IconItem.qml +++ b/homescreen/qml/IconItem.qml @@ -81,7 +81,7 @@ Item { states: [ State { name: 'active' - when: loc.currentId == model.id + when: loc.currentId === model.id PropertyChanges { target: container x: loc.mouseX - width/2 diff --git a/homescreen/qml/StatusArea.qml b/homescreen/qml/StatusArea.qml index d2e0930..14ccb8f 100644 --- a/homescreen/qml/StatusArea.qml +++ b/homescreen/qml/StatusArea.qml @@ -37,13 +37,13 @@ Item { onConditionChanged: { var icon = '' - if (condition.indexOf("clouds") != -1) { + if (condition.indexOf("clouds") !== -1) { icon = "WeatherIcons_Cloudy-01.png" - } else if (condition.indexOf("thunderstorm") != -1) { + } else if (condition.indexOf("thunderstorm") !== -1) { icon = "WeatherIcons_Thunderstorm-01.png" - } else if (condition.indexOf("snow") != -1) { + } else if (condition.indexOf("snow") !== -1) { icon = "WeatherIcons_Snow-01.png" - } else if (condition.indexOf("rain") != -1) { + } else if (condition.indexOf("rain") !== -1) { icon = "WeatherIcons_Rain-01.png" } -- 2.16.6