Freeing main argv is not needed and must not be done. 36/26936/3 11.0.5 12.91.0 koi/11.0.5 koi_11.0.5 marlin/12.91.0 marlin_12.91.0
authorVasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
Wed, 15 Sep 2021 07:50:29 +0000 (09:50 +0200)
committerJan-Simon Moeller <jsmoeller@linuxfoundation.org>
Tue, 7 Dec 2021 22:54:37 +0000 (22:54 +0000)
Was getting:

  free(): invalid pointer

Bug-AGL: SPEC-4148
Change-Id: I81bc58f647c0d4cb57a2d1bd7cecb80e943c05d2
Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
app/main.cpp

index 62ea3a0..d84ca26 100644 (file)
@@ -677,7 +677,7 @@ int main(int argc, char *argv[])
        GstElement *pipeline = gst_parse_launch(pipeline_str, &error);
        if (error || !pipeline) {
                fprintf(stderr, "gstreamer pipeline construction failed!\n");
-               free(argv);
+               free(gargv);
                return EXIT_FAILURE;
        }
 
@@ -700,7 +700,7 @@ int main(int argc, char *argv[])
        window = create_window(display, WINDOW_WIDTH_SIZE, WINDOW_HEIGHT_SIZE, app_id); 
 
        if (!window) {
-               free(argv);
+               free(gargv);
                return EXIT_FAILURE;
        }
 
@@ -731,7 +731,7 @@ int main(int argc, char *argv[])
 
        destroy_window(window);
        destroy_display(display);
-       free(argv);
+       free(gargv);
 
        gst_element_set_state(pipeline, GST_STATE_NULL);
        gst_object_unref(pipeline);