Code Review
/
apps
/
agl-service-can-low-level.git
/ search
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
first
⋅
prev
⋅
next
Static code review fixes.
2017-03-21
Romain Forlot
Fix: use the cmake from SDK instead from docker image
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-21
Romain Forlot
Change binder to binding in title in use with gitbook
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-21
Romain Forlot
Detail some instructions.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-21
Romain Forlot
Typo
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-21
Romain Forlot
Make IoTBZH smaller.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-21
Romain Forlot
Path from CANoe db to JSON files using OpenXC utilities.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Adding instructions to monitor CAN traffic.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Rename to the standard name Doxygen config file
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
More accurate diagram since we do not use OpenXC generator
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Improve documentation with config generation instructions
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Add targets to build documentation with instructions.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Update toyota example
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Spellchecking and typo
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Make error goes back to the subscribed clients when...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-20
Romain Forlot
Fix: Avoid segfault if diagnostic bus isn't correctly...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-19
Romain Forlot
Fix bad handling unsupported OBD2 messages subscription.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-18
Romain Forlot
Improve Toyota examples.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-17
Romain Forlot
Typo and formating and rework somes sentences.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-17
Romain Forlot
Comments fixes, typo and formating.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-17
Romain Forlot
Convert svg to png for the doc
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-17
Romain Forlot
Adding some abstract to the READme.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-17
Romain Forlot
Improve READme instructions.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Diagnostic requests will occur depending on their frequency.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Wrong error handling when fire diagnostic request.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Generate a configuration example with diagnostic messages...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: decoded name will be prefixed as at subscription.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Doxygen base configuration file and logo.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
gitignore update
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Include cleaning
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding missing doxygen comments.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Generated cpp file example.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Use index number between objects to set their links.
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Implement check of supported diagnostic PID.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve comments
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Make unsubscription works with diagnostic message too.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix comments
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix diagnostic message name mismatch at decoding.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Follow rename operation in CMakeLists.txt
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Small fixes
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Finalization of decoding part of diagnostic messages.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Retrieve easily Diagnostic Request PID from an Active...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Ease use of openXC structures.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Rename class and 1:1 map to JSON description file
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Make available decoding OBD2 messages method to be...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Simplification of checking Diagnostic response.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve memory allocation about Signal states.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Revert accessing CAN device with a map indexing on...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Uniformization between get_name() method of signals.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Littles comments improvments
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Change way to check prefix of signals name.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve shims_logger function to get full details.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Get recurring requests works.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Simplification of diagnostic manager. Delete uneeded...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Return period without unit conversion.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Search signals against name not generic_name. It's...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Less control before process the CAN message.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Implement regular event launching using systemd event...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve logging messages and change string conversion...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Move diagnostic requests scheduling to diagnostic manager
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: Initialization and entries flow
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Enabling recurrent check of diagnostic requests.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve Doxygen comments and formating.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Improve: DEBUG messages.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: return before initialization of diagnostic manager.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Make decoder systematic use of openxc-utils to build
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Implement signals states decoder and change map
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Search into generic_name as well as name + prefix, but
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding/Fix classes constructors to make them correspond
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Separation of classes in the same file.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Move member from obd2_signals_t class to
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Get decoding diagnostic request from decoding thread...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Change the way to check signal type making prefix_
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Reordering class method.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding instruction to use the binding.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: set to microsecond frequency check of diag request
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
fix: test for opened CAN socket.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Keep subscription to signal simplier without doubling
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Default value about thread state set at false.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Change configuration location into an etc directory.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: wrong location to make the increment because we use
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix CMakeLists file to get isotp correctly linked and...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Missing include header and code reordering and cleaning.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Change method returned value. Needed with send_request()
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Implemente way to send diagnostic request when subscribed.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Use of signals prefix to be able to distinguish type of
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Make diagnostic manager initialization processus.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding diagnostic_messages from diagnostic.json file
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
We doesn't modify member once getted, we can use const...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Manage prefix on CAN and OBD2 prefix. Searching signals
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Remove uneeded define as it was already present in...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Instead of a global pointer, config is now a Singleton.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Also initialize the id_ renamed address_ member. This...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Keep raw pointer for now as we have to move them around...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Finalize the class active_diag... to get it compile.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Change also where wgt file is since we build into a...
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding requests to diagnostic manager implemented.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding needed getter for diagnostic manager. Useful
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Adding needed function to get some time handle on request
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Fix: include statement with wrong path.
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
2017-03-16
Romain Forlot
Added constructor to get vector initialized with default
Signed-off-by: Romain Forlot <
romain.forlot@iot.bzh
>
commit
|
commitdiff
|
tree
next