From f97f8d24a1971117bbd4057ca0cd00776bcccb39 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Jos=C3=A9=20Bollo?= <jose.bollo@iot.bzh>
Date: Tue, 17 Jul 2018 10:42:04 +0200
Subject: [PATCH] wgtpkg-digsig: Fix digital signature check
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit
The compute of the return code was wrong: it always
returned 0 even in case of error.
Installation of a widget with an error in its signature
was possible due to this error.
Bug-AGL: SPEC-1590
Change-Id: Ibefd74aafd6a00dea32e52d471460cbe08a380ab
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---
src/wgtpkg-digsig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wgtpkg-digsig.c b/src/wgtpkg-digsig.c
index 4460bf2..a1cb55f 100644
--- a/src/wgtpkg-digsig.c
+++ b/src/wgtpkg-digsig.c
@@ -347,7 +347,7 @@ int check_all_signatures()
for (i = n ; i-- > 0 ; ) {
fdesc = signature_of_index(i);
irc = verify_digsig(fdesc);
- if (!irc)
+ if (irc < 0)
rc = irc;
}
--
2.16.6