From f83af86907f072b8d58bc84acfb431682a9e3080 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Bollo?= Date: Wed, 11 May 2016 17:42:49 +0200 Subject: [PATCH] fixup session memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Change-Id: I49ed17a3818be6107c46ce17533761858d99f735 Signed-off-by: José Bollo --- src/session.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/session.c b/src/session.c index 667738c4..22e50cfc 100644 --- a/src/session.c +++ b/src/session.c @@ -197,10 +197,11 @@ static void ctxStoreCleanUp (time_t now) // Loop on Sessions Table and remove anything that is older than timeout for (idx=0; idx < sessions.max; idx++) { - ctx = sessions.store[idx]; + ctx = ctxClientAddRef(sessions.store[idx]); if (ctx != NULL && ctxStoreTooOld(ctx, now)) { ctxClientClose (ctx); } + ctxClientUnref(ctx); } } @@ -276,6 +277,7 @@ void ctxClientUnref(struct AFB_clientCtx *clientCtx) --clientCtx->refcount; if (clientCtx->refcount == 0 && clientCtx->uuid[0] == 0) { ctxStoreDel (clientCtx); + free(clientCtx); } } } @@ -284,8 +286,12 @@ void ctxClientUnref(struct AFB_clientCtx *clientCtx) void ctxClientClose (struct AFB_clientCtx *clientCtx) { assert(clientCtx != NULL); - ctxUuidFreeCB (clientCtx); - clientCtx->uuid[0] = 0; + if (clientCtx->uuid[0] != 0) { + clientCtx->uuid[0] = 0; + ctxUuidFreeCB (clientCtx); + while(clientCtx->listeners != NULL) + ctxClientEventListenerRemove(clientCtx, clientCtx->listeners->listener); + } } // Sample Generic Ping Debug API -- 2.16.6