From 315496ddbb9f6f6079c8cd413507e15d41c3a5e7 Mon Sep 17 00:00:00 2001 From: Marius Vlad Date: Tue, 20 Sep 2022 11:45:09 +0300 Subject: [PATCH] compositor: Stop trapping SIGQUIT We've been trapping SIGQUIT for a "clean shutdown" since commit 3cad436a However, sources such as: http://www.gnu.org/software/libc/manual/html_node/Termination-Signals.html indicate we probably shouldn't be trapping it at all, as the intent of SIGQUIT is to leave a core file and debug artifacts from the run. We should perform the minimal amount of clean up to ensure the system isn't left in an unusable state - but these days that's performed by other software such as logind. We can safely stop trapping SIGQUIT entirely. (Based on work from https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/817) Bug-AGL: SPEC-4570 Signed-off-by: Derek Foreman Signed-off-by: Marius Vlad Change-Id: Icf7d4f3e76a58e781bad911a966b65e2798266d0 --- src/compositor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index e03b860..dbc89e2 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1608,7 +1608,7 @@ int wet_main(int argc, char *argv[], const struct weston_testsuite_data *test_da char *cmdline; struct wl_display *display = NULL; struct wl_event_loop *loop; - struct wl_event_source *signals[3] = { 0 }; + struct wl_event_source *signals[2] = { 0 }; struct weston_config_section *section; /* Command line options */ char *backend = NULL; @@ -1709,8 +1709,6 @@ int wet_main(int argc, char *argv[], const struct weston_testsuite_data *test_da display); signals[1] = wl_event_loop_add_signal(loop, SIGINT, on_term_signal, display); - signals[2] = wl_event_loop_add_signal(loop, SIGQUIT, on_term_signal, - display); for (size_t i = 0; i < ARRAY_LENGTH(signals); ++i) if (!signals[i]) -- 2.16.6