From 1d44ff2a0d14f8955a4efc26664d049150a8a18b Mon Sep 17 00:00:00 2001 From: Christopher Peplin Date: Fri, 14 Feb 2014 22:43:05 -0500 Subject: [PATCH] Only include PID in log output if request has one. --- src/uds/uds.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/uds/uds.c b/src/uds/uds.c index 5a45c0c6..88d56bc5 100644 --- a/src/uds/uds.c +++ b/src/uds/uds.c @@ -342,10 +342,17 @@ void diagnostic_response_to_string(const DiagnosticResponse* response, void diagnostic_request_to_string(const DiagnosticRequest* request, char* destination, size_t destination_length) { int bytes_used = snprintf(destination, destination_length, - "arb_id: 0x%02x, mode: 0x%x, pid: 0x%x, ", + "arb_id: 0x%02x, mode: 0x%x, ", request->arbitration_id, - request->mode, - request->pid); + request->mode); + + if(request->has_pid) { + bytes_used += snprintf(destination + bytes_used, + destination_length - bytes_used, + "pid: 0x%x, ", + request->pid); + } + int remaining_space = destination_length - bytes_used; if(request->payload_length > 0) { snprintf(destination + bytes_used, remaining_space, -- 2.16.6