From c0c44da0caba438d0b5445e0c15b511170d37eac Mon Sep 17 00:00:00 2001 From: Romain Forlot Date: Wed, 8 Jan 2020 10:58:42 +0100 Subject: [PATCH 1/1] converter: Use unsigned int whenever it's possible Use unsigned int whenever it is possible instead of uint32_t. This let the compiler decide the type. We do not need to use uint32_t explicitly for the converter. Bug-AGL: SPEC-2988 Change-Id: Ic2af875e7435668928c454df76e59c5c43b08407 Signed-off-by: Romain Forlot --- low-can-binding/utils/converter.cpp | 2 +- low-can-binding/utils/converter.hpp | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/low-can-binding/utils/converter.cpp b/low-can-binding/utils/converter.cpp index 9e70bc95..fad17757 100644 --- a/low-can-binding/utils/converter.cpp +++ b/low-can-binding/utils/converter.cpp @@ -48,7 +48,7 @@ std::string converter_t::to_hex(const uint8_t data[], const size_t length) * @param new_start_bit The first bit of the signal in the frame * @param new_end_bit The last bit of the signal in the frame */ -void converter_t::signal_to_bits_bytes(uint32_t bit_position, uint32_t bit_size, int &new_start_byte, int &new_end_byte, uint8_t &new_start_bit, uint8_t &new_end_bit) +void converter_t::signal_to_bits_bytes(unsigned int bit_position, unsigned int bit_size, int &new_start_byte, int &new_end_byte, uint8_t &new_start_bit, uint8_t &new_end_bit) { new_start_byte = bit_position >> 3; new_start_bit = bit_position % 8; diff --git a/low-can-binding/utils/converter.hpp b/low-can-binding/utils/converter.hpp index 45233268..32c898f1 100644 --- a/low-can-binding/utils/converter.hpp +++ b/low-can-binding/utils/converter.hpp @@ -23,6 +23,12 @@ class converter_t { public: static std::string to_hex(const uint8_t data[], const size_t length); - static void signal_to_bits_bytes(uint32_t bit_position, uint32_t bit_size, int &new_start_byte, int &new_end_byte, uint8_t &new_start_bit, uint8_t &new_end_bit); - static uint32_t bit_position_swap(uint32_t bit_position,uint32_t bit_size); + static void signal_to_bits_bytes(unsigned int bit_position, + unsigned int bit_size, + int &new_start_byte, + int &new_end_byte, + uint8_t &new_start_bit, + uint8_t &new_end_bit); + static uint32_t bit_position_swap(unsigned int bit_position, + unsigned int bit_size); }; -- 2.16.6