Romain Forlot [Thu, 8 Jun 2017 10:41:09 +0000 (12:41 +0200)]
Comments, Cleanup, format
Change-Id: I9f032cc232e77ce73e889a1656f1ad86cfdec774
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 21:38:19 +0000 (23:38 +0200)]
Cleanup include and prepare to switch binding v2
Change-Id: I032e8ec32c3ff5b2464f2802dd93683752316049
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:42:21 +0000 (15:42 +0200)]
Fix: read 2 times for 1 incoming CAN frame.
Change-Id: I7be7b5e704b3cb081e1dbd73a6ba7f88a2bbc62f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:41:40 +0000 (15:41 +0200)]
Possible uninitialized variable returned.
Change-Id: Id6ffed520aa238304afdddcd37a64e93002196aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:41:00 +0000 (15:41 +0200)]
Add some useful DEBUG information for read frames
Change-Id: I026111942b4b8486b46f56d5fc92fcebde4dc91f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 13:40:16 +0000 (15:40 +0200)]
Fix: invalid CAN frame read leads to an exception
The frame is reported like before but ignored now.
Change-Id: I8314cdb5fa99d950023bf881c72daea2ef9bb935
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 7 Jun 2017 12:27:33 +0000 (14:27 +0200)]
Improve reliability on multi-threading.
- Limits call to signals_manager and subscribed signals map
- Unlock and lock mutex in the right order to avoid possible dead locks.
Change-Id: Ifb152af833ad8bdde5dc4fc3a27b1a7c27046523
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:29:59 +0000 (01:29 +0200)]
Fix: exception unsubscribe all at start
When unsubscribing but no diagnostic subscription made there
is an exception when cleaning empty requests vector.
Change-Id: I40bdd01969fd1a1c6fecb0a438c46d0df584de83
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:28:21 +0000 (01:28 +0200)]
Fix: c++11 detected and not applied from config
Change-Id: Iedf1f88e142a3f579ada3794b1f0f8813105d880
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:27:24 +0000 (01:27 +0200)]
Fix: unsubscribe from 1 app remove diagnostic req
Let the function on_no_client do the cleaning of the remaining active
diagnostic requests.
Change-Id: I6fc2477d53200e3475f62cd453804827172a99c0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 23:25:04 +0000 (01:25 +0200)]
Separate low_can_subscription class from callbacks
Change-Id: I682cacca1af53f898ac4c428f823562c50e7cce4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 08:23:51 +0000 (10:23 +0200)]
Update signals.json and generated files.
Adding fake windows signals,
Fix wrong bit_position about doors (not fake signal)
In fact all signals are fake except of doors signals and OBD2
diagnostic messages.
Change-Id: Ia5877bb9720b11b0ff3593788d3e79324b0fa44e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 08:18:08 +0000 (10:18 +0200)]
Update generator at latest low level binding
- renaming configuration to application
- make message_set as a vector of shared_ptr
- Setting up object parent in graphs at application object instanciation
Change-Id: Ib33103d5cebbd9381375d2832582a25ae0f9f199
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 6 Jun 2017 07:21:42 +0000 (09:21 +0200)]
Remove demo UI from the project
Low level CAN binding is a standalone service that doesn't
have to be delivered with an UI.
Change-Id: Ic3995704a63b56f21168e2e9da8e45b3117a0f41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:50:15 +0000 (19:50 +0200)]
Let the thread to be managed outside the binding.
Change-Id: Ib905a3e0ea58a32761c4dda4a391c1d7b311c12a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:49:46 +0000 (19:49 +0200)]
C++ coding style
No changes on the object so it is a const method...
Change-Id: I55b50d0d6fc0dd120f58ca56b6a68172353a5ef5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:48:24 +0000 (19:48 +0200)]
Remove pointer generator that make memory leaks.
Only have 1 place where to generate a pointer from a DiagnosticRequest
is in low-can-cb.cpp when subscribing. Else now using reference instead
of raw pointer.
Change-Id: I7fd2f3d30afa90017b945e6b711922036123b6d3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 17:45:01 +0000 (19:45 +0200)]
Get diag manager's socket into subscription obj
Subscription index map is the socket ID which implies the following:
- All diagnostic messages subscriptions are stored into a vector
holding diagnostic_message and there is 1 socket for all like the
diag manager did.
- Reworked workflow to open a BCM socket and adding an RX filter more flexible.
- Separated methods to handle on_no_clients event.
- Cleaning diagnostic manager code to remove all unneeded stuff now.
- Embed diagnostic response in VehicleMessage decoded message to be able
transmits the PID in event push thread. This is needed by to correctly handle case
when there is no clients subscribed to an AFB event. Else we can't find
the diagnostic message to remove from low_can_subscription vector.
Change-Id: Iab13fd556cda3c69827bcd67f3a23a03cb6a2cf2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:05:18 +0000 (02:05 +0200)]
Update submodule.
Change-Id: I2f8bc5bbe7325b50c62a40d1f081b5bf771179c8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:03:27 +0000 (02:03 +0200)]
Fix: Handle several subscriptions to a signal
Change-Id: I460bae0056761f6468ca4dc55a594f1529d53c83
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:02:55 +0000 (02:02 +0200)]
Adding accessor to diagnostic msg shared ptr.
Change-Id: I9d32239b3ebd762ab3a337fc734d504ee8dc8c5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 2 Jun 2017 00:02:20 +0000 (02:02 +0200)]
Change way to validate a subscription object
Better to check validity of 2 differents type of signals
used and checks that its event is valid.
Change-Id: I1435bbe81a43fd80eae049d43b5e37fc8f893074
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:42:39 +0000 (18:42 +0200)]
Fix warning compile
Change-Id: Id0f088f030c0a23b4347c4886a3d756538cbb651
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:18:33 +0000 (18:18 +0200)]
Implement minimum and maximum subscription filters
Change-Id: I6b027cdb37e425e185b8d2278ae775f857ff96bc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:18:07 +0000 (18:18 +0200)]
Better handling of duplicate non recurring request
Change-Id: Ib6015d5dac66751622f3e287429475b6b708c3d5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:17:29 +0000 (18:17 +0200)]
Methods to ease access to DynamicField members
Change-Id: I8974827340e3faf60a511900cbdcf117ce43fb53
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:59:57 +0000 (15:59 +0200)]
Close socket by default when destroying object
As socket is back to only movable, only one copy of a socket
can be present at a time, so when the object is destroyed we have
to close the socket too.
Change-Id: Id64bb53919ce7c24476c26ba9a8520affa3f6273
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:58:44 +0000 (15:58 +0200)]
Delete pointer and content, possible memory leak
Change-Id: I21e65bcaaa444c03bbc634f1d437e6ff363623b6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:58:20 +0000 (15:58 +0200)]
Initializing all struct by default to avoid errors
Change-Id: I54eab7da7e5819f633a5612abe46d44550068aab
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:57:29 +0000 (15:57 +0200)]
Format
Change-Id: Ibbd48a1c0fe0e7567cbf3f5f1c6919e542883924
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:57:24 +0000 (15:57 +0200)]
Left over renaming variable
Following change from configuration_t to application_t some
variable name doesn't correspond now : conf -> app
Change-Id: I56c3a83113777a43af9024a9bc9b53f705b60b0f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 13:55:53 +0000 (15:55 +0200)]
Fix: Frequency filter doesn't apply on diagnostic
As socket isn't managed by low_can_susbcription yet,
create_rx_filter was just using signal frequency setting.
Now, it take the frequency asked in argument if provided.
Change-Id: If44458b2b0e34df44337670dd9a5b2b58324bfbe
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:48:36 +0000 (13:48 +0200)]
Cleaning
Change-Id: I73e9acf8b3a28db2134cf1f4bcb1b2aa7fd224fc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:48:19 +0000 (13:48 +0200)]
Use UDS PID has key to record subscriptions
can_signal_t use socket number but has for OBD2 diagnostic request
there is only 1 socket to listen all response then we use PID has key
to find the subscription later on the processing.
Change-Id: I5f0554e1a4ac43e1046d9b7b7f9bb00d3a753562
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 11:46:10 +0000 (13:46 +0200)]
Simplify processing event
Set afb_event into subscription object then there is no more
std::pair used t access it, better use a method from
low_can_subscription_t class
Change-Id: Ic0772d97c18ca8899821cf3ce175166bbe0be660
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 08:33:05 +0000 (10:33 +0200)]
Format
Change-Id: Ib3f8f0c8cbffaf7b5d1acb8c4541526dad03a9c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 08:32:48 +0000 (10:32 +0200)]
Fix: segfault subscribing diagnostic messages
Wrong object used when subscribing.
Change-Id: I356c8cedc57191268ce3ea1838999fbe03472ae2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:43:43 +0000 (09:43 +0200)]
Fix: get signal name no matter type of signal.
One method to return name depending upon which type it is,
can or diagnostic.
Change-Id: I1e96f88654e14316d3afe527fa6fa0d8ddbf410d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:43 +0000 (09:07 +0200)]
Using isnan to define frequency.
Change-Id: Iba93089dc982644898540b286892c436229f38d2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:15 +0000 (09:07 +0200)]
Missing pragma once...
Change-Id: I3088089af5a817ed68ef0276869a01d7323e6ae7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:07:00 +0000 (09:07 +0200)]
Implement method to filter messages before pushing
Change-Id: I94223ebead4a011a1fb56ed0c3676c433e01319b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 07:05:08 +0000 (09:05 +0200)]
Split function to call 1 function by signal types.
From signals found process each vector into a separated function
Change-Id: I0c622508eb98a7284606b4f75c825ba48e3fe227
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 23:12:59 +0000 (01:12 +0200)]
Rename method to have same everywhere
Change-Id: I80ceeada376d46f2cfcac259ed86239cc74ea05c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 16:32:49 +0000 (18:32 +0200)]
Fix diagnostic message subscription.
Change-Id: I490ee639e5d524a142e2fbbd928725b7268178aa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:28:57 +0000 (17:28 +0200)]
Adding windows CAN signals.
These signals is not the reals ones.
Change-Id: I5f30fcab09f22488a8085f44eb22a97b67214339
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:19:25 +0000 (17:19 +0200)]
YouCompleteMe extra configuration file for IDE
Change-Id: I915cfefcbeadeda56c949a405dc3194edf1faf99
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:14:39 +0000 (17:14 +0200)]
Use default signal frequency if no filter provided
Change-Id: I60bc1cdd62a75b539684032bbb58c38256149944
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:01:54 +0000 (17:01 +0200)]
Retrieve signal last value and timestamp at once.
Change-Id: I8401030ece94b5e397b6d2b71b29ff4e435d1486
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 15:01:12 +0000 (17:01 +0200)]
Fix: Don't processing filter argument
Filter is a separate json object to get, so using request
arguments to retrieve it.
Change-Id: I0e672a747c95ef5e7ed17dd184697265a18add9c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:09:27 +0000 (12:09 +0200)]
Consider using char* as well as string.
Change-Id: I08aba32f1273c7be305ceacf121e42fddfca173e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:08:13 +0000 (12:08 +0200)]
Clearer call to method
Change-Id: Ibf37a46989ac8d84a56aa43873fdb8bb0e601304
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:07:38 +0000 (12:07 +0200)]
Remove reverse find can_signal from can_message
There is no need to search against can_signal with CAN arbitration id
because a pointer to the signal it maintained through the
low_can_subscription_t object now.
Change-Id: Ia8b3c7074ff86f7e2a8f3ed503ea1abed3bfe51b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:03:02 +0000 (12:03 +0200)]
Use ptr to can_signal instead of copying some members
Change-Id: Ie827559c7da462f59bfe4af8af824f4616c2dd5b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 07:23:19 +0000 (09:23 +0200)]
Missing var declaration
Change-Id: Icbb18bcdeae1d928d3981d21fc547d2940b198bd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 07:23:03 +0000 (09:23 +0200)]
Fix: use of isnan() from std lib
Change-Id: I40ecb409ec1361faa6df8585332f319508bcb464
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
José Bollo [Tue, 30 May 2017 17:21:22 +0000 (19:21 +0200)]
manage unset values with NAN
Change-Id: I144bc110864f507e57d5e4b7f03ee1c0aa61ff63
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
José Bollo [Tue, 30 May 2017 17:20:35 +0000 (19:20 +0200)]
optimise flow
Change-Id: I56d796531120236591f00fdf7a30f0a4495cbef2
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
Romain Forlot [Wed, 31 May 2017 06:59:58 +0000 (08:59 +0200)]
Update submodule to latest version
Change-Id: Ia38494c18ac75409d39525286be07e4b1b610c50
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:46:21 +0000 (12:46 +0200)]
Cleaning
Change-Id: Iba8c7929ced1e2492de94e3a2b1c98dd4eb70b6b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:46:02 +0000 (12:46 +0200)]
Reworked subscription to integrate filtering.
- Creation of an object which old the subscription context
(filter, signal) : low_can_subscription_t
- Move socket from can_signal_t to this new object.
- Adding a member to can_message_t to transport subscription_id to be able to
retrieve it with all the context through running.
Change-Id: I87be8cd6c3c93a81040357920d8c081a316800c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:34:22 +0000 (12:34 +0200)]
Return const structures.
These structures doesn't not have to change after.
Change-Id: I0cc83136c7ee4e5f5cd9c04bf717814e141f98c5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 31 May 2017 10:31:11 +0000 (12:31 +0200)]
Remake socketcan only movable
Change-Id: If81e2a18c0beec392a98f8b835c7a5d154360500
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 30 May 2017 15:00:44 +0000 (17:00 +0200)]
Renaming configuration to application
It is more accurate to name it application because all its
members aren't modifiable at runtime (without talking of last_value_
member and few others).
Change-Id: Ica0d33dfd9c26cfdea019c2f41ed07777fb36d39
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 1 Jun 2017 16:22:41 +0000 (18:22 +0200)]
Update gitignore
Change-Id: I918ce2a6e99d1c517a3492d6cc9312bf333f94fa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# .gitignore
Romain Forlot [Mon, 29 May 2017 12:38:56 +0000 (14:38 +0200)]
Update submodule
Change-Id: I48f225fc70bc1a3924c7cb1caf5db7923f3c5ee8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 29 May 2017 09:02:04 +0000 (11:02 +0200)]
Update mismatched variables.
Change-Id: I60db8a08255fbd0cb24e06e38871cd926bba153f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 28 May 2017 16:24:15 +0000 (18:24 +0200)]
Update README instructions.
Adding git submodules instructions before building.
Change-Id: I8b1aa09e5ca69c0e2a7e8acbf6d80593a5fc0f22
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 28 May 2017 15:52:14 +0000 (17:52 +0200)]
Disabled temporarly kernel version checking
Change-Id: I02498df332b8322dc28c9d07187fec544cfd928c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 28 May 2017 15:20:49 +0000 (17:20 +0200)]
Clean unused project files and update build script
Change-Id: I4f606005ee781716da52f2ef68e55eeb69026ce3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 28 May 2017 14:51:46 +0000 (16:51 +0200)]
Use latest version of cmake templates.
Change-Id: Ia2408a09705ccf035f0e68ecac2909e2b0047f9b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 28 May 2017 11:18:52 +0000 (13:18 +0200)]
Update gitignore
Change-Id: I918ce2a6e99d1c517a3492d6cc9312bf333f94fa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 24 May 2017 16:38:54 +0000 (18:38 +0200)]
Fix: file already exists on build demo app
Change-Id: I956caaa06c82e5786114d2fac53c7532226fe7ba
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 24 May 2017 16:15:46 +0000 (18:15 +0200)]
Update config.cmake path
Change-Id: I468d27c764274458310cbd11cdec06b686789152
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 24 May 2017 15:35:53 +0000 (17:35 +0200)]
Cmake WIP
Change-Id: I9c1cefde33724db192cbbf3dac69d47b2a700c2d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# CAN-binder/conf.d/default
Romain Forlot [Wed, 24 May 2017 14:54:43 +0000 (16:54 +0200)]
Move and update app-templates submodule
Change-Id: I91b3926c9c5ab7c95b5a6f9cec309d930792ba14
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 23:38:00 +0000 (01:38 +0200)]
Close diagnostic manager socket if there isn't any requests
No need to listen diagnostic responses if there isn't any subscriptions.
Change-Id: I7fa48dbc3e8fb1847b8186337fe2813625894406
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 23:37:04 +0000 (01:37 +0200)]
Initialize the new socket member.
Change-Id: Ia267c7ec605c692222ddcaed112486f81b428200
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 22:46:43 +0000 (00:46 +0200)]
Fix memory leaks
Change-Id: I4a33b6d5f1f3b73af113aff62b024329b0ed5288
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 22:00:33 +0000 (00:00 +0200)]
Be able to copy active diagnostic request objects with their socket
Implement socket copy assignment operator on socketcan base class.
Change-Id: I75a2d3b96275b7ab83372d74ff7fe0a0b0535dc7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 21:59:27 +0000 (23:59 +0200)]
Static code review fixes.
Several style errors and mistakes mostly on constructor and passing arguments
as ref.
Change-Id: I2ca921d6aa70b9074392bb7779ade35bebf7bd8d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 20:54:55 +0000 (22:54 +0200)]
Fix a dependency problem with populate htdocs targets.
Update modif date on output dir to make update on populate happens too.
Change-Id: Ie1481d4231075a83bebde79ebf41c1f11b73ac21
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 20:53:28 +0000 (22:53 +0200)]
Update the doc
Change-Id: I5b403be18a82072bb68b0b01d2ad576de4fb5014
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 23 May 2017 20:53:18 +0000 (22:53 +0200)]
Implement filtering on subscription. WIP
Change-Id: I232bdfe75335d0266d582b4974d8378632aceeae
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 22 May 2017 08:28:38 +0000 (10:28 +0200)]
Logical bus name mapped to device name using conf file.
Store CAN device map without prefixed section name and add methods to get
the mapped device name.
Change-Id: I03ebc175c67b2251016863b0d69a45a816a81d25
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 14:21:17 +0000 (16:21 +0200)]
Remove unused CMakeLists.txt file.
Useless because nanopb isn't compiled standalone. It's used from openxc-
message-format library.
Change-Id: I59b8a6617d7ba95ac1557d1ad5f49ae0011eb701
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 14:20:02 +0000 (16:20 +0200)]
Add 'CAN-binder/libs/nanopb/' from commit '
278ffb890e3d8722e4c7d824baaf221a1e375fc4'
git-subtree-dir: CAN-binder/libs/nanopb
git-subtree-mainline:
48a2605965af1f05ba7f01f6e8c1758a4c9b0522
git-subtree-split:
278ffb890e3d8722e4c7d824baaf221a1e375fc4
Romain Forlot [Fri, 19 May 2017 14:13:23 +0000 (16:13 +0200)]
Use the nanopb sources from projects libs.
Change-Id: I9af9a71e4e454a488e51a95ae896fd249bf27103
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 12:09:40 +0000 (14:09 +0200)]
Using reference make std::move useless.
Change-Id: I9b9b6a2fbaecae8acc4f8f1eef0ea8d2f084fb9f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 12:07:38 +0000 (14:07 +0200)]
Set parent from configuration_generated objects.
Change-Id: I8f07084c6364347ebad3e029b89aeef93129cce3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 10:15:07 +0000 (12:15 +0200)]
Added timestamp to received CAN messages
and store into frequency_clock_t.
Change-Id: If209070298bd9df49297fdcbed554770e1bc0e4a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 08:55:52 +0000 (10:55 +0200)]
Delete sub-submodules from imported openXC project
Change-Id: If0584c7238353b01292486a4843ff00bb0398987
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 11:55:29 +0000 (13:55 +0200)]
Rename build script to generic name
Change-Id: I91d7646e27357e338d13e0aea0e0d373fb61b175
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 19 May 2017 14:17:36 +0000 (16:17 +0200)]
Adjust method signature to be more efficient.
Return vector reference and doesn't return const ref.
Change-Id: Ibcbc1d72e4baf1a7b8bf017d36d6d37d25312d6d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
# Conflicts:
# CAN-binder/low-can-binding/can/can-signals.hpp
Romain Forlot [Thu, 18 May 2017 22:36:30 +0000 (00:36 +0200)]
Change method name to signify that it is an aggregate.
As can_message_definitions got the exact same name but the one from can_message_set
is an aggregate of all can_message_definition. So it is clearer using a different
name.
Change-Id: Ieb9e4d3291f3dc460eb352d8b8fe5a7cf479e687
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 18 May 2017 17:50:02 +0000 (19:50 +0200)]
Use shared_ptr for can_message_set too.
Change-Id: I3ba4881d5fc01a69d55e101b9a07c2019dda1d4b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 18 May 2017 17:49:43 +0000 (19:49 +0200)]
Finish config parser retrieving device mapping.
Change-Id: Ia43f9c0edf09ff9a1c009f198bdad10a6b44b249
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 18 May 2017 17:48:29 +0000 (19:48 +0200)]
Upgrade CMake once again using reference submodule from app-templates
Change-Id: I2a17d142af208e71fe6f59d71bc455d6f5882b4a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 17 May 2017 23:05:36 +0000 (01:05 +0200)]
Update the doc
Change-Id: I3efb0bcd4b5e56101bf14a8335406bf6b2f30e97
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 17 May 2017 23:05:16 +0000 (01:05 +0200)]
Fix: cmake doesn"t create populate targets.
Use of property make that the variable PROJECTçTARGETS isn't available until
we retrieve it with get_property
Change-Id: I69845425a11af6408dbced4d13c2d04c5181c0be
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 17 May 2017 23:03:57 +0000 (01:03 +0200)]
Format
Change-Id: If3a381a4a07c117b9b1cc48ba3a6b4af2d7bdc69
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Code Review / apps / low-level-can-service.git / log