apps/agl-service-can-low-level.git
7 years agoadded a parent CMakeLists.txt to allow build in root dir and use by IDEs.
Loïc Collignon [Wed, 8 Mar 2017 13:39:48 +0000 (14:39 +0100)]
added a parent CMakeLists.txt to allow build in root dir and use by IDEs.

Change-Id: I1d5e3a85c582ed2c711d3138df0030655ce09d5e
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
7 years agoadded some ignore to skip KDevelop files.
Loïc Collignon [Wed, 8 Mar 2017 13:37:26 +0000 (14:37 +0100)]
added some ignore to skip KDevelop files.

Change-Id: I602b92268f82250730818027c846b569db7f2b59
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
7 years agoChange doxygen comments
Loïc Collignon [Wed, 8 Mar 2017 11:44:50 +0000 (12:44 +0100)]
Change doxygen comments

Change-Id: Ia635a7483e2fcda3b98fd3d3b3f7e996d26926d0
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
7 years agoBeginning of work of get central configuration object
Romain Forlot [Wed, 8 Mar 2017 01:41:56 +0000 (02:41 +0100)]
Beginning of work of get central configuration object
that will be used by the binding to access generated
elements. It will hold generated structure/objects and
make a resume to the binding configuration.

Idea is to have an object that can be inherited
in the generated code to extend its functionnalities
or change some of its behoviors.

Change-Id: If2ce5cbe2eb98a74a8e3f13000ee02855674216f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoIt isn't needed to initialize diag manager
Romain Forlot [Tue, 7 Mar 2017 23:21:21 +0000 (00:21 +0100)]
It isn't needed to initialize diag manager
for each can_bus_dev_t instance
Indeed, generator will write the diag manager objects statically with the
correct can_bus_dev_t instance to use.

Change-Id: Ib52d93bff576ef962dc141f5936133e878977017

7 years agoIntroducing active-diagnostic-message that will be hold
Romain Forlot [Tue, 7 Mar 2017 14:37:10 +0000 (15:37 +0100)]
Introducing active-diagnostic-message that will be hold
by Diagnostic manager in its queue and list.

Change-Id: I565d06634a55b99cc97f36ec6d695b3b0bf21dca
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: typo, and dirty fix to get compiled ftm.
Romain Forlot [Tue, 7 Mar 2017 14:36:18 +0000 (15:36 +0100)]
Fix: typo, and dirty fix to get compiled ftm.

Change-Id: I74042051346a0f0f4de7152e2a668c041edaebde
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoIntroducing diagnostic manager class.
Romain Forlot [Tue, 7 Mar 2017 14:35:37 +0000 (15:35 +0100)]
Introducing diagnostic manager class.

It will hold communication through uds-c lib allowing
to communication with diagnostic protocol obd2. It is
attached to can_bus_dev_t class 'cause it must regularly
send CAN message through it.

Change-Id: I2d9d8dfaca10e9865bf82b0ae83e65490ca982f8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMake an extern get_signal_id() function plug to get_pid()
Romain Forlot [Tue, 7 Mar 2017 14:31:20 +0000 (15:31 +0100)]
Make an extern get_signal_id() function plug to get_pid()
member function from class obd2_signals class.

Change-Id: I5a0f1cfd0c2fb9374cc3928861ca4e8a52911942
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wrong function signature and get out from class
Romain Forlot [Tue, 7 Mar 2017 08:30:50 +0000 (09:30 +0100)]
Fix: wrong function signature and get out from class
temporarly to get compiled project.

Change-Id: I7235f503c42a3e31d09094c42882b74e5e809493
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoInclude file changes, typo and renaming operation.
Romain Forlot [Thu, 16 Mar 2017 16:08:57 +0000 (17:08 +0100)]
Include file changes, typo and renaming operation.

Change-Id: I6643333cfcc8bea120496c53f1cd3b8596e33398
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: typo
Romain Forlot [Mon, 6 Mar 2017 21:39:41 +0000 (22:39 +0100)]
Fix: typo

Change-Id: I882595f4a0f28c60b12f8c6ed0bff11a80af29af
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFinalize new directories organization.
Romain Forlot [Mon, 6 Mar 2017 21:39:31 +0000 (22:39 +0100)]
Finalize new directories organization.

Change include statements and CMakeLists.txt accordingly
to the new layout.

Change-Id: Ief0821f7f6636b072cf26c7d8d8fcc16fe43ab01
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoBeginning of work on obd2 object and
Romain Forlot [Mon, 6 Mar 2017 21:28:50 +0000 (22:28 +0100)]
Beginning of work on obd2 object and
files reorganization.

Change-Id: Idaa7ad05c45d734ce771506fd6e41f1a09a6ac66
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoRaw import openXC function to detect obd2 response.
Romain Forlot [Mon, 6 Mar 2017 18:16:30 +0000 (19:16 +0100)]
Raw import openXC function to detect obd2 response.

Change-Id: Ieea0396979302329f5884ebef2064bdc7015a45f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoComment pass to cpp file instead of hpp
Romain Forlot [Mon, 6 Mar 2017 18:08:32 +0000 (19:08 +0100)]
Comment pass to cpp file instead of hpp

Change-Id: I13f3b3d81485ec59a636f11140074d9f25f87428
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoSort and comment the code
Romain Forlot [Mon, 6 Mar 2017 17:45:35 +0000 (18:45 +0100)]
Sort and comment the code

Change-Id: I1860c0d5fb03ce2217d5553159a090298596d939
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: clear pointer vector before fill it.
Romain Forlot [Mon, 6 Mar 2017 16:00:12 +0000 (17:00 +0100)]
Fix: clear pointer vector before fill it.

Clearer indentation

Change-Id: I9fdea8d03bf33bf0ada3504770b52a21f30b57a0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoInclude new signals.xpp files to the compilation
Romain Forlot [Mon, 6 Mar 2017 15:58:04 +0000 (16:58 +0100)]
Include new signals.xpp files to the compilation

Change-Id: If105a195f24f90d8a75793e127488563ca299851
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange way to find signals to make it a little bit more generic.
Romain Forlot [Mon, 6 Mar 2017 15:57:14 +0000 (16:57 +0100)]
Change way to find signals to make it a little bit more generic.

Now we have basically 3 functions :
 - one for subscription which return signal name into a vector
 - one to find from CanSignal vector
 - a last to find from Obd2Pid vector

Name of some function has been changed.

May be reworked later.

Change-Id: Ie72969fd20503fc1f9291958dc2ac5d827a6be59
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agochange all genericName to generic_name. Now all
Romain Forlot [Fri, 3 Mar 2017 14:12:17 +0000 (15:12 +0100)]
change all genericName to generic_name. Now all
objects use the same variable name

Change-Id: I8a232bc8fd7e580bd8088e6b2ae7a90666ef9c62
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange TARGET variable name and remove CMakeTools
Romain Forlot [Fri, 3 Mar 2017 14:11:33 +0000 (15:11 +0100)]
Change TARGET variable name and remove CMakeTools
helpers modules requirements

Change-Id: Ifaa03b13671c62f877e391e7cd6f0ff0b40fd356
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agotbf
Romain Forlot [Fri, 3 Mar 2017 07:49:00 +0000 (08:49 +0100)]
tbf

Change-Id: I4e46542258b8dab0c0e266adddf9bfc7a4111376
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoClean up uneeded members and functions
Romain Forlot [Thu, 2 Mar 2017 22:23:55 +0000 (23:23 +0100)]
Clean up uneeded members and functions

Change-Id: Idc9ebe9cfc6e348c378c1489971600b8f125e6e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: unsynchronization between queues.
Romain Forlot [Thu, 2 Mar 2017 22:23:32 +0000 (23:23 +0100)]
Fix: unsynchronization between queues.
Ressources not enough protected with mutex, I extend
the scope of the lock to make sure that event flow go
through synchronously.

Change-Id: I77a80ab69eb768a211c537e0f33580379832a465
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: no json data for subcribed events
Romain Forlot [Thu, 2 Mar 2017 22:16:56 +0000 (23:16 +0100)]
Fix: no json data for subcribed events

Change-Id: I9c260559d28bfe4bf26a77403254cd46a84a7d6f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: Make sure can_message_t.data_ member has been
Romain Forlot [Thu, 2 Mar 2017 22:06:22 +0000 (23:06 +0100)]
Fix: Make sure can_message_t.data_ member has been
clear before use it again.

Change-Id: Ib073d67651cd3272190ef7464e806cf1f22b4cf3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoDebugging message cook
Romain Forlot [Thu, 2 Mar 2017 22:05:50 +0000 (23:05 +0100)]
Debugging message cook

Change-Id: If93bf9bf7c6e2f429a4313a7f6500ded950229c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdding DEBUG messages to track error on STL container
Romain Forlot [Thu, 2 Mar 2017 21:35:22 +0000 (22:35 +0100)]
Adding DEBUG messages to track error on STL container
Fix: iteration around signal vector.

Change-Id: I188cfa8be452ba5268f236b5a8cd1f2bce89058b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: Wrong set up of vector.
Romain Forlot [Thu, 2 Mar 2017 21:34:23 +0000 (22:34 +0100)]
Fix: Wrong set up of vector.

Change-Id: Id9fa04541a62714802a64492e3981b204756212e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoReserve new space to data_ can_message_t member only if the
Romain Forlot [Thu, 2 Mar 2017 21:33:38 +0000 (22:33 +0100)]
Reserve new space to data_ can_message_t member only if the
new incoming can frame if bigger than the old one.

Change-Id: I39634cc0d01b300ea471b358e13d704b8eff351c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: multiple subscription and maintain subscribed_signals coherence
Romain Forlot [Thu, 2 Mar 2017 21:32:53 +0000 (22:32 +0100)]
Fix: multiple subscription and maintain subscribed_signals coherence
across usage.

- Transmission of a reference instead of copy.
- Don't use anymore iterator on subscribed_signals map

Change-Id: I5e5b7b0bb8598be3bb0ec59c29418ee937ddcc9e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoInitialize all boolean value of DynamicField. Avoiding mistake.
Romain Forlot [Thu, 2 Mar 2017 21:24:32 +0000 (22:24 +0100)]
Initialize all boolean value of DynamicField. Avoiding mistake.

Change-Id: I9cd5551186debd153e838b6d4156430553d5235f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoClean and imrove log messages.
Romain Forlot [Thu, 2 Mar 2017 21:21:31 +0000 (22:21 +0100)]
Clean and imrove log messages.

Change-Id: I77c74851ec436de0c7a7c47993badb7d1e2c01ca
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoTests with CmakeTools extension for VSCode. Can install on target
Romain Forlot [Thu, 2 Mar 2017 21:20:10 +0000 (22:20 +0100)]
Tests with CmakeTools extension for VSCode. Can install on target
from VSCode.

Change-Id: I464d3379fe061605fcc84ba432e7a8a8b6ec6ec7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange id to an hexadecimal value.
Romain Forlot [Wed, 1 Mar 2017 18:29:31 +0000 (19:29 +0100)]
Change id to an hexadecimal value.

Change-Id: Iecf8179e2885a7d1392a854bcd56e731fed5bba0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: subscription and improve code readabilty
Romain Forlot [Wed, 1 Mar 2017 18:28:20 +0000 (19:28 +0100)]
Fix: subscription and improve code readabilty

There was probleme between char and string
conversion. Also, I get rid of iterator and
use direct access using operator[].

Change-Id: I235ef0dd3ef9d9cebb624491d86383392e9eb8d8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoNew way to return canfd_frame with now number of read bytes.
Romain Forlot [Wed, 1 Mar 2017 16:42:52 +0000 (17:42 +0100)]
New way to return canfd_frame with now number of read bytes.
This way, we can detect correctly the max data length and
set the data correctly.

Change-Id: I346df154df76dbd4a463d1fabfd9edd56faca506
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wrong format to display can_message_t information
Romain Forlot [Wed, 1 Mar 2017 16:41:16 +0000 (17:41 +0100)]
Fix: wrong format to display can_message_t information

Change-Id: I6c17c68d8e995022886750f2ef05348b544cbde5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMerge branch 'master' of github.com:iotbzh/CAN_signaling
Romain Forlot [Wed, 1 Mar 2017 16:07:49 +0000 (17:07 +0100)]
Merge branch 'master' of github.com:iotbzh/CAN_signaling

7 years agoWrong call to thread.join cause deadlock and thread termination.
Romain Forlot [Wed, 1 Mar 2017 16:07:20 +0000 (17:07 +0100)]
Wrong call to thread.join cause deadlock and thread termination.
Positionning the controlling boolean value will be enough for now

Change-Id: I28e2d175e23370746cc30c2403829ebdeec7c2bb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: miss 'if' brackets to get incomplete CAN frames correctly
Romain Forlot [Wed, 1 Mar 2017 16:06:17 +0000 (17:06 +0100)]
Fix: miss 'if' brackets to get incomplete CAN frames correctly
Fix: displaying can message frame with hexa format.

Change-Id: Iff658ac38f21a15945ed82509d4e291f0fda7503
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoUpdated the README.md to clarify the use of git submodule.
Loïc Collignon [Wed, 1 Mar 2017 15:19:25 +0000 (16:19 +0100)]
Updated the README.md to clarify the use of git submodule.

Change-Id: Iceec81be36b217f69565452955da2f4ea43e10e9
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
7 years agoChanged submodules URL to use https instead of ssh.
Loïc Collignon [Wed, 1 Mar 2017 15:14:29 +0000 (16:14 +0100)]
Changed submodules URL to use https instead of ssh.

Change-Id: I8614cca0ad386bdf6d2339e014a85d790da04d87
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
7 years agoChange data_ member of can_message_t object
Romain Forlot [Wed, 1 Mar 2017 14:58:42 +0000 (15:58 +0100)]
Change data_ member of can_message_t object
to a vector of uint8_t instead of an array

This is more flexible to allocate dynamically
the vector depending if we process classic CAN
frame or CAN FD frame which are 64bytes long.

Change-Id: I698002139d612e3aaaa33f0f5a895e16ff655f5d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: improve can_message read
Romain Forlot [Wed, 1 Mar 2017 14:05:18 +0000 (15:05 +0100)]
Fix: improve can_message read

Change-Id: If0c52c6df3f68e9b79fb851d64a729946cac6ef6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoDelete for good obsolete code
Romain Forlot [Wed, 1 Mar 2017 08:20:46 +0000 (09:20 +0100)]
Delete for good obsolete code

Change-Id: Ic56fadcc7e6265072e4e3413f914b735b56e903d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agotbf
Romain Forlot [Wed, 1 Mar 2017 07:41:29 +0000 (08:41 +0100)]
tbf

Change-Id: I30e16cd45d613db1aaf7d1064bfaf5c6013d991a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoImplement a new method returning the can device
Romain Forlot [Tue, 28 Feb 2017 20:29:17 +0000 (21:29 +0100)]
Implement a new method returning the can device
map.

Change-Id: Ie44bb825269034f9f071bd286c7830a77ba5c479
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: can bus object life is now expanded and don't
Romain Forlot [Tue, 28 Feb 2017 20:09:26 +0000 (21:09 +0100)]
Fix: can bus object life is now expanded and don't
die prematuraly.

can_bus_handler object is now a pointer living
forever.
can_bus_dev_t object is now stored as a shared
pointer into a variable member into can_bus_t.

So everyone survive now.

Change-Id: I52768dd7fe3c203a5f679f59afd1bcf330f3af35
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wrong argument passed to start_reading().
Romain Forlot [Tue, 28 Feb 2017 15:21:19 +0000 (16:21 +0100)]
Fix: wrong argument passed to start_reading().
Not needed to specify std::ref...

Change-Id: I0e5ae02554f8a0f07ec1d40670b9b089453804e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdded debugging messages.
Romain Forlot [Tue, 28 Feb 2017 15:06:15 +0000 (16:06 +0100)]
Added debugging messages.

Change-Id: I42d2576355f69ac167b170a2994c7360d8449fb7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMake the thread function members of can_bus_t and can_bus_dev_t objects.
Romain Forlot [Tue, 28 Feb 2017 15:05:37 +0000 (16:05 +0100)]
Make the thread function members of can_bus_t and can_bus_dev_t objects.

Change-Id: I3cf06998c6ff6d859c7fdf6bf52a9b6ff061c556
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoRe-arranging objects splitting all objects over
Romain Forlot [Tue, 28 Feb 2017 11:00:43 +0000 (12:00 +0100)]
Re-arranging objects splitting all objects over
separated files.

Change-Id: Ifbdb2ea08704324e505a48ba3124df6f2af63c6b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: start reading the can bus if it was correctly
Romain Forlot [Mon, 27 Feb 2017 22:17:43 +0000 (23:17 +0100)]
Fix: start reading the can bus if it was correctly
opened.

Change-Id: If285791aee51d4a57e17270e8ac458cb6869f970
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdded some DEBUG log messages around reading conf
Romain Forlot [Mon, 27 Feb 2017 22:03:55 +0000 (23:03 +0100)]
Added some DEBUG log messages around reading conf
file

Change-Id: Iec52801df6ce0c47c24412ac46332c301d5c46d6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wrong conf file name specified
Romain Forlot [Mon, 27 Feb 2017 22:03:12 +0000 (23:03 +0100)]
Fix: wrong conf file name specified
Comestic change about binding description and
prefix

Change-Id: Iffb3e0d13a81461db0f1300674c4fef3a6bde34f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: mismatch function signature and implementation
Romain Forlot [Mon, 27 Feb 2017 22:02:25 +0000 (23:02 +0100)]
Fix: mismatch function signature and implementation

Change-Id: I3e43ffda762117eac1b13da0d5a652338c6ad1f1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix decoder_t methods to get it compile
Romain Forlot [Mon, 27 Feb 2017 21:23:34 +0000 (22:23 +0100)]
Fix decoder_t methods to get it compile

Change-Id: I283480bf434b00ade15bcb1dbc9d097c338caab4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdded missing pthread lib
Romain Forlot [Mon, 27 Feb 2017 21:23:15 +0000 (22:23 +0100)]
Added missing pthread lib

Change-Id: I34c43af949a5f47334fa606acfe5b2bcccf59083
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix wrong returned value about getCanBuses.
Romain Forlot [Mon, 27 Feb 2017 20:30:05 +0000 (21:30 +0100)]
Fix wrong returned value about getCanBuses.

Why I keep this function anyway...

Change-Id: Ifcbc00625fcb065b73afed51fc712067aa9db412
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoIn class mutex and condition variable except for subscribed_signals map
Romain Forlot [Mon, 27 Feb 2017 20:29:07 +0000 (21:29 +0100)]
In class mutex and condition variable except for subscribed_signals map
For now...

Change-Id: I133deb39fcd0660064b3b3c2a52f86ad37cb29c2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoRemoved static libraries deployed by mistake
Romain Forlot [Mon, 27 Feb 2017 19:32:03 +0000 (20:32 +0100)]
Removed static libraries deployed by mistake

Change-Id: I25e8bf44463ef70c9910326a091aa2390d6f0652
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChanged the decoding function
Romain Forlot [Mon, 27 Feb 2017 19:25:52 +0000 (20:25 +0100)]
Changed the decoding function

Change-Id: Ib27fb13d4fb7959509400a3c2eff2859d1ce9c2b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange content target and use a testing
Romain Forlot [Mon, 27 Feb 2017 15:47:15 +0000 (16:47 +0100)]
Change content target and use a testing
CAN bus: vcan0

Change-Id: I95b8f3882f253524ef4836277ef1650f03ca89df
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoBuild and link statically external libraries
Romain Forlot [Mon, 27 Feb 2017 15:42:40 +0000 (16:42 +0100)]
Build and link statically external libraries
to the binding.

Change-Id: I22480cbbc234f6bc40e632b9ce45b7170cd85e54
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoImprove mutex lock logic.
Romain Forlot [Fri, 24 Feb 2017 14:14:48 +0000 (14:14 +0000)]
Improve mutex lock logic.

- Use of bracket instead of unlock method
- Change some mutex lock scope.
- Added subscribed_signals map object mutex to
manipulate it safely.

Change-Id: I770c0b5701db6b1151511f7360ec31ae6dcc1de9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoRemove socket read management by systemd event
Romain Forlot [Fri, 24 Feb 2017 11:10:02 +0000 (11:10 +0000)]
Remove socket read management by systemd event
loop and use classic thread with a blocking
read

Change-Id: Iac5428009b57c727bb32bd4893bc3fe282ba35c7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoImprove subscription/unsubscription operation.
Romain Forlot [Fri, 24 Feb 2017 10:06:48 +0000 (10:06 +0000)]
Improve subscription/unsubscription operation.

Break operations into 2 new functions to improve
readability and added some comments too.

Change-Id: I405622ef17787cb39d8d2b2530a2d6572ce4e366
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wrong if...else atomic expression
Romain Forlot [Fri, 24 Feb 2017 08:50:26 +0000 (08:50 +0000)]
Fix: wrong if...else atomic expression

Change-Id: I995e6c6eb5e7e6d3f7ade17b8386706a5144f3bb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdd comment
Romain Forlot [Fri, 24 Feb 2017 08:16:26 +0000 (08:16 +0000)]
Add comment

Change-Id: Ifc04a66e54889cc4f735cad1ac9caaeb31230566
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix mutex about can_frame. Wrong location about
Romain Forlot [Fri, 24 Feb 2017 07:56:25 +0000 (07:56 +0000)]
Fix mutex about can_frame. Wrong location about
can frame mutex and adding around can socket
init.

Change-Id: I90c2200abf517ad4a9660c99a3ca02e52e069374
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFirst draft about lock/wait thread management.
Romain Forlot [Thu, 23 Feb 2017 17:52:35 +0000 (17:52 +0000)]
First draft about lock/wait thread management.
Reordering include files

Change-Id: Ia6d9ee30eb4e1df0c380c26355679fe00b373aa8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMake binder_interface global variable rather than
Romain Forlot [Thu, 23 Feb 2017 14:09:30 +0000 (14:09 +0000)]
Make binder_interface global variable rather than
pass it over and over through class and functions

Change-Id: Ie32d44126a41125c6c45d18663b668328df44e2d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoCleaning, improve comments
Romain Forlot [Thu, 23 Feb 2017 10:32:17 +0000 (10:32 +0000)]
Cleaning, improve comments

Change-Id: I2115f7e7017786c343da4b70002c3b3785ba53ac
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoHeader include spring cleaning
Romain Forlot [Wed, 22 Feb 2017 18:26:23 +0000 (19:26 +0100)]
Header include spring cleaning

Change-Id: I28b5c9197daa30c7da4ef1835f0eb989613a7901
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agomake binder_interface global
José Bollo [Wed, 22 Feb 2017 18:11:46 +0000 (19:11 +0100)]
make binder_interface global

Change-Id: I90b17d702cebdcf2d78cc108c2ecb995c231527e
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
7 years agoImprove doxygen comments
Romain Forlot [Wed, 22 Feb 2017 18:01:01 +0000 (19:01 +0100)]
Improve doxygen comments

Change-Id: I7506997865726a6caa28177a1f85713ae924336f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoEnhance error handling about can_message_t class
Romain Forlot [Wed, 22 Feb 2017 16:47:39 +0000 (17:47 +0100)]
Enhance error handling about can_message_t class

Change-Id: I9fbda1110eea7a3bd7e5855739280aa10bce5a6b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange way to convert simplemessage into a json
Romain Forlot [Wed, 22 Feb 2017 12:06:24 +0000 (13:06 +0100)]
Change way to convert simplemessage into a json
object.

Improve doxygen comments

Change-Id: I794bdc10f9e1ce66ebd4e68dbd6e0c465e3ca5c4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoNo more warning about not defined functions
Romain Forlot [Wed, 22 Feb 2017 10:44:27 +0000 (11:44 +0100)]
No more warning about not defined functions
because of wrong header files inclusion.
Some variables are now accessible using functions
rather than using global variables that can not
be accessed through separated files.

Also fix timer returning function type.

Change-Id: I36138ff671c2537f595235273abaa34783be18e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoResolve circular header files inclusion
Romain Forlot [Wed, 22 Feb 2017 08:38:30 +0000 (09:38 +0100)]
Resolve circular header files inclusion

Change-Id: Ida3de058f1edd2892ebc858d1eb714471fd5f65c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agofirst draft to new subscribre unsubscibre method
Romain Forlot [Tue, 21 Feb 2017 17:19:03 +0000 (17:19 +0000)]
first draft to new subscribre unsubscibre method

Change-Id: I2a3fe7ac1d77cc893e9cc63c54895d521ab2bf01
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: decoder_t class decodeSignal method signature
Romain Forlot [Tue, 21 Feb 2017 17:16:59 +0000 (17:16 +0000)]
Fix: decoder_t class decodeSignal method signature

Change-Id: Id7ef4fe3b8d3f5b14fd447cf05865ba494862792
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAll queue under can_bus_t class and reading thread
Romain Forlot [Tue, 21 Feb 2017 16:30:30 +0000 (16:30 +0000)]
All queue under can_bus_t class and reading thread
function with an additionnal can_bus_t object argument

Change-Id: I6b0b9b66e83be59359bcd148e8b9f3350a085b64
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdded separated header files
Romain Forlot [Tue, 21 Feb 2017 15:03:39 +0000 (15:03 +0000)]
Added separated header files

Change-Id: Ife7701b54149c12bce969468adb667a6c101d01a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: force to pass a ref at threads launch
Romain Forlot [Tue, 21 Feb 2017 13:21:59 +0000 (13:21 +0000)]
Fix: force to pass a ref at threads launch

Change-Id: Ife4206d6f6dce6888157239cce56b0040e3d2cf4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: threads launching with wrong arguments
Romain Forlot [Tue, 21 Feb 2017 12:58:09 +0000 (12:58 +0000)]
Fix: threads launching with wrong arguments
Fix: wrong type identifier to returned sendto
function

Change-Id: I33bcb84211c665720422573b04b32ca71e13d3e5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMultifixes: class and methods, typo, comments
Romain Forlot [Tue, 21 Feb 2017 10:54:38 +0000 (10:54 +0000)]
Multifixes: class and methods, typo, comments

Change-Id: I473de66a9d4119ce64c04bd7fa59654774ac3b8f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFixed can bus class (almost)
Romain Forlot [Tue, 21 Feb 2017 08:15:58 +0000 (08:15 +0000)]
Fixed can bus class (almost)

Change-Id: Icb76d26749e0e7b5f122676861ed09ac0c03be30
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoHandle error in returning a vector by returning
Romain Forlot [Tue, 21 Feb 2017 07:42:46 +0000 (07:42 +0000)]
Handle error in returning a vector by returning
an empty vector.

Fix: typo

Change-Id: Ibe859d3e67f6eea96b50e04cd230657be56a18c6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoClean up include statement...
Romain Forlot [Mon, 20 Feb 2017 20:19:59 +0000 (20:19 +0000)]
Clean up include statement...

Change-Id: Ie909836171ea5eb030246255bb08f1c5b8a65641
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoSome cleaning and comments
Romain Forlot [Mon, 20 Feb 2017 19:37:50 +0000 (19:37 +0000)]
Some cleaning and comments

Change-Id: Iad73e3a34c5638e012819506b56741f62cfa3e30
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoCleaned up, a bit, include statement.
Romain Forlot [Mon, 20 Feb 2017 19:17:01 +0000 (19:17 +0000)]
Cleaned up, a bit, include statement.

Change-Id: Icdaa162f1b3b92e730fc7dc263c18c682a7f4098
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: OBD2_PIDS array initialization
Romain Forlot [Mon, 20 Feb 2017 09:50:32 +0000 (09:50 +0000)]
Fix: OBD2_PIDS array initialization

Change-Id: Ic2c297e4ff94a13872f066ca42ee42beb45451ca
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: timer.* issues
Romain Forlot [Fri, 17 Feb 2017 17:17:24 +0000 (17:17 +0000)]
Fix: timer.* issues

Change-Id: I1c3721403198b3c5525a811bd3c7cbf6b8e78e5b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoChange hpp include file directive
Romain Forlot [Fri, 17 Feb 2017 17:04:47 +0000 (17:04 +0000)]
Change hpp include file directive

Change-Id: I1df7ab41b19a2c065d8ed477115e21e0ded8659f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoSeparated can_bus and can_bus_dev object.
Romain Forlot [Fri, 17 Feb 2017 17:03:53 +0000 (17:03 +0000)]
Separated can_bus and can_bus_dev object.

Now there are as many thread reading as can bus device

Change-Id: I65928b39714f3a0e76e588de3db10d091ad5093d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAdded JSON conf file example
Romain Forlot [Fri, 17 Feb 2017 17:02:21 +0000 (17:02 +0000)]
Added JSON conf file example

Change-Id: I9d3eb88b575b3af943582dd69ca8df2bc3b66115
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoAddind missing library
Romain Forlot [Fri, 17 Feb 2017 14:53:54 +0000 (14:53 +0000)]
Addind missing library

Change-Id: Ic793d097eb9773e455e1bfbb95d57565a003cd53
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>