Loïc Collignon [Fri, 10 Mar 2017 09:16:05 +0000 (10:16 +0100)]
fixed the build script when rebuild action is triggered.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 09:11:44 +0000 (10:11 +0100)]
Finalize the class active_diag... to get it compile.
Fix subsequents bugs into the other depending class
diagnostic manager
Change-Id: I8920c489fc15a61a36ff29d58aab59c2e6388f85
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:09:23 +0000 (02:09 +0100)]
Change also where wgt file is since we build into a subdirectory
Change-Id: I8cf568292035f1e8fd73d41ed91d5bd7d9d7c512
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:06:57 +0000 (02:06 +0100)]
Adding requests to diagnostic manager implemented.
Needed overload of operator and constructor set for
active_diagnostic_message_t class. Without we can't make
the basic operation needed by the manager.
Get rid of original raw pointer on "entry" which avoid some
tests.
It miss the acceptance filters implementations for now.
Change-Id: I1ca61ff843c13255af6d9a60ce72a8b8bc9d1c18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:03:02 +0000 (02:03 +0100)]
Adding needed getter for diagnostic manager. Useful
to determine if both object use the same CAN bus device
Change-Id: I97dbf807198a420c305c8fbbd2cb4bfcdda4c294
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:02:00 +0000 (02:02 +0100)]
Adding needed function to get some time handle on request
for diagnostic at first.
Change-Id: I3ab966d6386bad52f68ebdbea723bb7507cfaf2a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 20:08:57 +0000 (21:08 +0100)]
add a helper script to build, can be use by VS2017.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 20:08:11 +0000 (21:08 +0100)]
add VS2017 files to .gitignore
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:56:56 +0000 (16:56 +0100)]
Fix: include statement with wrong path.
And minor fixes.
Change-Id: Ica55c0708edd86d0aa37e7117b3c3fad551a0167
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:11:43 +0000 (16:11 +0100)]
Added constructor to get vector initialized with default
objects initialized that can be grabed after at runtime.
Don't know the impact on performance for now about maximum
limit.
Change-Id: I220614d479b8254ae0efda66380e96434bcbfbb2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 15:28:33 +0000 (16:28 +0100)]
separation to a new file of can_message_set_t
Change-Id: If21021d8905d40d443d4432faeb38f8a3275697c
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:01:08 +0000 (16:01 +0100)]
Change FrequencyClock struct to class and rename it.
Change-Id: I1076ad90e14815f3d0ab71ca9fa359d1d3c1748d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 13:32:55 +0000 (14:32 +0100)]
fixed CMakeLists.txt
Change-Id: I62069f71b53a7a0e2131ca92834a9a85995308a7
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:07:57 +0000 (13:07 +0100)]
Fix: wrong tested variable for socket.
Change-Id: Ice2325441474f1a075140e13dfffa0261106dff7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:07:16 +0000 (13:07 +0100)]
C Header first
Change-Id: Ief8c66e99c689a362b645ad3b918d8b342ada59a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:06:56 +0000 (13:06 +0100)]
Add necessary to be able to initialize diagnostic manager shims.
We have to conform to functions signatures from isotp-c
to have it working.
Change-Id: I429def66f54e53277e87aa99e66292cdb47c1c5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:03:13 +0000 (13:03 +0100)]
Reorder to fix warning at compilation
Change-Id: I1e558720318d9251ddfbbf6bb66a0461aef98e4c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 10:57:35 +0000 (11:57 +0100)]
Changing to a raw pointer can_bus_dev member and add
a default constructor.
It is needed to initialize configuration_t correctly as
it allocate a diagnostic manager but do not initialize it
unless it is needed later. There is no need to initialize it
if we do not send and receive diagnostic requests.
Change-Id: I3d52d1ea92454e7b065479a2f0dd54a291ddd991
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:43:30 +0000 (10:43 +0100)]
Fix: wrong signature due to reference discarding "const".
Change-Id: I7dada9d01eb8619c3807647b6df378dd147bb7fb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:42:20 +0000 (10:42 +0100)]
Fix: bugs in class due to the wrapping of C socket
into a class.
Added missing include and adjust methods signature.
Change-Id: Id016b452e0b641a14482c288e4713acae941ee1d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:16:45 +0000 (10:16 +0100)]
Fix: use of new objects and type conversion missing.
Change-Id: I583ad536de619fed2be655a493299fe43cc65924
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:16:14 +0000 (10:16 +0100)]
Format
Change-Id: Ie9159b039e468e511b497884816453093048aa80
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:15:41 +0000 (10:15 +0100)]
Added new cpp files.
Change-Id: I7f8b524a1279267f0ebd94eef6ef72e2875a47f6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:36:10 +0000 (02:36 +0100)]
typo
Change-Id: I62d9e858409b464dd69ebfae76ca73097fae560e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:35:28 +0000 (02:35 +0100)]
Fix: include path (where I think to fix them...)
Change-Id: Ib44693efc9347fc4fdf40a1748725d5191303199
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:34:58 +0000 (02:34 +0100)]
Fix: missed method declaration
Change-Id: If44be94dfd847089d494088d33f7b6c7f5d9098e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:34:38 +0000 (02:34 +0100)]
Better use a reference
Change-Id: Ie060009315c99919271ac706fdc1ab384e3d7218
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:34:18 +0000 (02:34 +0100)]
Respect the signature requested by uds-c lib.
Change-Id: I7d7a96b45323f698e884c4db289370eec199d990
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:33:19 +0000 (02:33 +0100)]
Move some functions to configuration class.
Change-Id: I87b1b6961206ae3848cf6aca367698218fe1523e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:32:25 +0000 (02:32 +0100)]
Create getter/setter needed for can_signal_t class.
Change-Id: I8253fcbe7edb6673d9f6bcf85d6109800a4cf6e8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:28:27 +0000 (02:28 +0100)]
Fix: used new created classes.
Change-Id: Ib0188ac952f64b3bc2203c0310a21de380c75854
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:26:48 +0000 (02:26 +0100)]
Added a static method to get used by Diagnostic manager
that respect the requested signature.
Change-Id: Id10215597d65ecaf280fe6252d78bc74a306958e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:26:05 +0000 (02:26 +0100)]
Fix: wrong socket variable called.
Change-Id: Ib09b084e7202d184abf73cf92fea4afbcf4acf47
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 01:25:46 +0000 (02:25 +0100)]
Typo and formating.
Change-Id: I864a2fe7f974b0f2bf5000f55c2dc71ecf32a314
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 23:50:47 +0000 (00:50 +0100)]
Constructor making mandatory to pass a can_bus_dev_t
instance to initialize it as it is reference.
Change-Id: I0261a5e2fdca5a84fd736d7ceae837ff9156b935
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 23:46:58 +0000 (00:46 +0100)]
Misplaced test of rtr_flag bool and length assignation
Mini simplification of the method... More incoming.
Change-Id: I2e7c2c5226e33265591acc6c8bbbe5f5f670db18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 23:43:18 +0000 (00:43 +0100)]
Fix: method to allocate a new can_message_t object
from a canfd_frame. A new constructor added ad-hoc.
Change-Id: Id6b909666105da0c4885351db9291aa430d138f0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:59:58 +0000 (23:59 +0100)]
Again change enum name and add "_t" suffix to get
syntax coloration into IDE...
Neat, isn't it !
Change-Id: Ieee2618336be80ddf97ccaa29bc83098a6463c56
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:56:49 +0000 (23:56 +0100)]
Use the new created class and their respectives
methods to get their attributes.
Change-Id: Ib96031388356541615cd2c428d3ad1a73c79e215
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:49:12 +0000 (23:49 +0100)]
Use static method now as they are all static. No need
to instanciate an object to decode now.
Change-Id: Id9bf378642ad66b7b4f39d909678ecc5ebb756cc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:48:34 +0000 (23:48 +0100)]
Change all old struct name to the new class.
Change-Id: I8aa4430117c401182ef458a06a2aeb08957db1bb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:46:59 +0000 (23:46 +0100)]
Forward declaration needed instead of include the
whole file. Lighter.
Change-Id: I14af5868679e5c65bda9a4395b040cc28af04059
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:29:08 +0000 (23:29 +0100)]
Change CanMessageFormat name to make it
as the other type.
Change-Id: I4b3ae3998175613458492a0f02cce06a576cbfa8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 20:58:46 +0000 (21:58 +0100)]
Clean old C struct, now as C++ class
Change-Id: Iba4c4a47b140c53d766c348064857069feefdb19
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 20:54:03 +0000 (21:54 +0100)]
Added missing method of the class.
Change-Id: Ic03ec222e69efc7adde4680dc5612896eac562fe
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 20:46:58 +0000 (21:46 +0100)]
Make all class function as static to be accessible
without instance.
Change-Id: I80fcf55010b81e6f3af6892adf2c351d502f50dd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 20:45:49 +0000 (21:45 +0100)]
Poco-ification of CanSignal struct as can_signal_t class
Change-Id: I1239b862b255efaefc459d4f9d0a93c6be6ba2cb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 20:45:07 +0000 (21:45 +0100)]
Fix: declaration and implementation of needed methods
under their respective class as they were standalone
before that.
Change-Id: I3ca6fe68bb40f883106ddbe07db8f2dc7d4f618b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 22:10:44 +0000 (23:10 +0100)]
Cleaning old can_bus_dev_t now implemented
separatly
Change-Id: I4529100f118afe25aee747d36a77dc5b533878a5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Conflicts:
src/can/can-bus.hpp
Romain Forlot [Wed, 8 Mar 2017 17:37:43 +0000 (18:37 +0100)]
Make convert method static to get called at the return
statement of read.
Also clean unsafe function, that can't be called separatly
because they need to get called in a certain order.
Change-Id: I5670f0cd1c0fdea4f228045b9124ecd60097ebb2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 21:59:43 +0000 (22:59 +0100)]
Fix all doxygen comments about parameters.
Change-Id: Idbe268d07ebf53a63c9543d9cca94ded34a29731
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 21:59:04 +0000 (22:59 +0100)]
Move "config" variable as global.
Change-Id: I1760dce5ef5836c9392837f4a196382ee88dabd8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Conflicts:
src/configuration.hpp
Romain Forlot [Wed, 8 Mar 2017 12:57:55 +0000 (13:57 +0100)]
Fix: wrong assignement of can_bus_t object.
Fix: const function added by mistake.
Change-Id: I69dc19922c9e48fc073f1a3e00dd243188110971
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 12:37:18 +0000 (13:37 +0100)]
Define predefined OBD2 signals by default.
Change-Id: Ide948c64fe2085b98acf7cdb70e6baf7b6a669ed
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 12:36:30 +0000 (13:36 +0100)]
Miss removed header file include
Change-Id: Iea45260ff78fadced7c9eb3ccefbc05341be25e4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 12:21:54 +0000 (13:21 +0100)]
Fix missing constructor declaration
Change-Id: I22dcc2a52fcbe6e37c820fe378bfb7dbbea8c25b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 21:53:22 +0000 (22:53 +0100)]
Separate methods declarations and implementations.
Get out examples objects to test into another cpp that
will be used to be the template for the futur generated
code.
Change-Id: Ic630478b5419e7a18e4e6446edbac7fbe68299b9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Conflicts:
src/configuration.hpp
Romain Forlot [Wed, 8 Mar 2017 12:17:03 +0000 (13:17 +0100)]
Fix : wrong attribute type
Change-Id: I8a87c295d4d76a5551fbb67b04b9fee69644eb00
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 12:15:47 +0000 (13:15 +0100)]
Fix: missing method declaration
Change-Id: Iac5872ffe9f4b26e7c966e5ea29516f193ba547d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 11:53:59 +0000 (12:53 +0100)]
Remove now unused function that has moved into configuration class
Change-Id: I1f16a7acb32407420b2c5f5deb5b815829b0b610
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 11:55:47 +0000 (12:55 +0100)]
Make a global variable to a configuration object.
With afb interface, it will be the last global variable
needed as it regroup all needed stuff to other class and
functions.
Change-Id: I3d82b6f748ff22a9a975d15ab9df51f63005737f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 21:22:41 +0000 (22:22 +0100)]
Remove moved functions into configuration class
Change-Id: Ia8aa6a9f6211c2e040f53972ba689aecdeda9011
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 11:53:27 +0000 (12:53 +0100)]
Fix: wrong method signature.
Change-Id: Id836fac13d66443c313403a572ab840eecb8321d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 11:52:46 +0000 (12:52 +0100)]
Make dumb poco class from old C struct
Change-Id: I1cae74b33e1351bb84d002e86f93c9329f8389f0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 21:21:15 +0000 (22:21 +0100)]
Add movable constructor to the class
Change-Id: I4d050fda9b189e4d88393013c2b6c893063f24db
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 08:44:53 +0000 (09:44 +0100)]
Added a warning that it is an example code
Change-Id: Ib66e49960a348896020fba56f7d98910623af83f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Wed, 8 Mar 2017 13:47:38 +0000 (14:47 +0100)]
separation of can_bus_t and can_bus_dev_t and use of the new socket class.
Change-Id: I5f292ab18737fa48259f357d660fed27fb8fb4be
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Wed, 8 Mar 2017 13:40:24 +0000 (14:40 +0100)]
added a socket class to wrap the C socket API.
Change-Id: Id90c60caba93b65011def0cc01232a7a2d7dbac4
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Wed, 8 Mar 2017 13:39:48 +0000 (14:39 +0100)]
added a parent CMakeLists.txt to allow build in root dir and use by IDEs.
Change-Id: I1d5e3a85c582ed2c711d3138df0030655ce09d5e
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Wed, 8 Mar 2017 13:37:26 +0000 (14:37 +0100)]
added some ignore to skip KDevelop files.
Change-Id: I602b92268f82250730818027c846b569db7f2b59
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Wed, 8 Mar 2017 11:44:50 +0000 (12:44 +0100)]
Change doxygen comments
Change-Id: Ia635a7483e2fcda3b98fd3d3b3f7e996d26926d0
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Wed, 8 Mar 2017 01:41:56 +0000 (02:41 +0100)]
Beginning of work of get central configuration object
that will be used by the binding to access generated
elements. It will hold generated structure/objects and
make a resume to the binding configuration.
Idea is to have an object that can be inherited
in the generated code to extend its functionnalities
or change some of its behoviors.
Change-Id: If2ce5cbe2eb98a74a8e3f13000ee02855674216f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 7 Mar 2017 23:21:21 +0000 (00:21 +0100)]
It isn't needed to initialize diag manager
for each can_bus_dev_t instance
Indeed, generator will write the diag manager objects statically with the
correct can_bus_dev_t instance to use.
Change-Id: Ib52d93bff576ef962dc141f5936133e878977017
Romain Forlot [Tue, 7 Mar 2017 14:37:10 +0000 (15:37 +0100)]
Introducing active-diagnostic-message that will be hold
by Diagnostic manager in its queue and list.
Change-Id: I565d06634a55b99cc97f36ec6d695b3b0bf21dca
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 7 Mar 2017 14:36:18 +0000 (15:36 +0100)]
Fix: typo, and dirty fix to get compiled ftm.
Change-Id: I74042051346a0f0f4de7152e2a668c041edaebde
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 7 Mar 2017 14:35:37 +0000 (15:35 +0100)]
Introducing diagnostic manager class.
It will hold communication through uds-c lib allowing
to communication with diagnostic protocol obd2. It is
attached to can_bus_dev_t class 'cause it must regularly
send CAN message through it.
Change-Id: I2d9d8dfaca10e9865bf82b0ae83e65490ca982f8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 7 Mar 2017 14:31:20 +0000 (15:31 +0100)]
Make an extern get_signal_id() function plug to get_pid()
member function from class obd2_signals class.
Change-Id: I5a0f1cfd0c2fb9374cc3928861ca4e8a52911942
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 7 Mar 2017 08:30:50 +0000 (09:30 +0100)]
Fix: wrong function signature and get out from class
temporarly to get compiled project.
Change-Id: I7235f503c42a3e31d09094c42882b74e5e809493
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 16:08:57 +0000 (17:08 +0100)]
Include file changes, typo and renaming operation.
Change-Id: I6643333cfcc8bea120496c53f1cd3b8596e33398
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 21:39:41 +0000 (22:39 +0100)]
Fix: typo
Change-Id: I882595f4a0f28c60b12f8c6ed0bff11a80af29af
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 21:39:31 +0000 (22:39 +0100)]
Finalize new directories organization.
Change include statements and CMakeLists.txt accordingly
to the new layout.
Change-Id: Ief0821f7f6636b072cf26c7d8d8fcc16fe43ab01
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 21:28:50 +0000 (22:28 +0100)]
Beginning of work on obd2 object and
files reorganization.
Change-Id: Idaa7ad05c45d734ce771506fd6e41f1a09a6ac66
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 18:16:30 +0000 (19:16 +0100)]
Raw import openXC function to detect obd2 response.
Change-Id: Ieea0396979302329f5884ebef2064bdc7015a45f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 18:08:32 +0000 (19:08 +0100)]
Comment pass to cpp file instead of hpp
Change-Id: I13f3b3d81485ec59a636f11140074d9f25f87428
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 17:45:35 +0000 (18:45 +0100)]
Sort and comment the code
Change-Id: I1860c0d5fb03ce2217d5553159a090298596d939
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 16:00:12 +0000 (17:00 +0100)]
Fix: clear pointer vector before fill it.
Clearer indentation
Change-Id: I9fdea8d03bf33bf0ada3504770b52a21f30b57a0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 15:58:04 +0000 (16:58 +0100)]
Include new signals.xpp files to the compilation
Change-Id: If105a195f24f90d8a75793e127488563ca299851
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 6 Mar 2017 15:57:14 +0000 (16:57 +0100)]
Change way to find signals to make it a little bit more generic.
Now we have basically 3 functions :
- one for subscription which return signal name into a vector
- one to find from CanSignal vector
- a last to find from Obd2Pid vector
Name of some function has been changed.
May be reworked later.
Change-Id: Ie72969fd20503fc1f9291958dc2ac5d827a6be59
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 3 Mar 2017 14:12:17 +0000 (15:12 +0100)]
change all genericName to generic_name. Now all
objects use the same variable name
Change-Id: I8a232bc8fd7e580bd8088e6b2ae7a90666ef9c62
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 3 Mar 2017 14:11:33 +0000 (15:11 +0100)]
Change TARGET variable name and remove CMakeTools
helpers modules requirements
Change-Id: Ifaa03b13671c62f877e391e7cd6f0ff0b40fd356
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 3 Mar 2017 07:49:00 +0000 (08:49 +0100)]
tbf
Change-Id: I4e46542258b8dab0c0e266adddf9bfc7a4111376
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 22:23:55 +0000 (23:23 +0100)]
Clean up uneeded members and functions
Change-Id: Idc9ebe9cfc6e348c378c1489971600b8f125e6e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 22:23:32 +0000 (23:23 +0100)]
Fix: unsynchronization between queues.
Ressources not enough protected with mutex, I extend
the scope of the lock to make sure that event flow go
through synchronously.
Change-Id: I77a80ab69eb768a211c537e0f33580379832a465
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 22:16:56 +0000 (23:16 +0100)]
Fix: no json data for subcribed events
Change-Id: I9c260559d28bfe4bf26a77403254cd46a84a7d6f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 22:06:22 +0000 (23:06 +0100)]
Fix: Make sure can_message_t.data_ member has been
clear before use it again.
Change-Id: Ib073d67651cd3272190ef7464e806cf1f22b4cf3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 22:05:50 +0000 (23:05 +0100)]
Debugging message cook
Change-Id: If93bf9bf7c6e2f429a4313a7f6500ded950229c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 21:35:22 +0000 (22:35 +0100)]
Adding DEBUG messages to track error on STL container
Fix: iteration around signal vector.
Change-Id: I188cfa8be452ba5268f236b5a8cd1f2bce89058b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 21:34:23 +0000 (22:34 +0100)]
Fix: Wrong set up of vector.
Change-Id: Id9fa04541a62714802a64492e3981b204756212e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 21:33:38 +0000 (22:33 +0100)]
Reserve new space to data_ can_message_t member only if the
new incoming can frame if bigger than the old one.
Change-Id: I39634cc0d01b300ea471b358e13d704b8eff351c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 2 Mar 2017 21:32:53 +0000 (22:32 +0100)]
Fix: multiple subscription and maintain subscribed_signals coherence
across usage.
- Transmission of a reference instead of copy.
- Don't use anymore iterator on subscribed_signals map
Change-Id: I5e5b7b0bb8598be3bb0ec59c29418ee937ddcc9e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Code Review / apps / agl-service-can-low-level.git / log