Loïc Collignon [Fri, 17 Mar 2017 12:23:11 +0000 (13:23 +0100)]
added toyota's exemple.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Fri, 17 Mar 2017 11:55:47 +0000 (12:55 +0100)]
Typo and formating and rework somes sentences.
Change-Id: If222728bfc9120065fd56f0877d3736634f6fc52
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 17 Mar 2017 11:48:46 +0000 (12:48 +0100)]
Comments fixes, typo and formating.
No more warning when generate the docs and all comments follow the same
formating.
Change-Id: I80d4c5c2d64401c2e53a550c60155680c4f968ce
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Fri, 17 Mar 2017 11:37:13 +0000 (12:37 +0100)]
moved exemples files.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Fri, 17 Mar 2017 09:29:26 +0000 (10:29 +0100)]
Convert svg to png for the doc
Change-Id: Ia62cba8da3db425d63c18104d597cd577f9651ab
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 17 Mar 2017 09:20:44 +0000 (10:20 +0100)]
Adding some abstract to the READme.
Present the CAN binding architecture.
Change-Id: I7ab2a96e468a57e882a2eca93aedaacdc057794b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 17 Mar 2017 00:52:40 +0000 (01:52 +0100)]
Improve READme instructions.
Change-Id: I8b507d3e34ed3d34680e6e15b7f97b7e17fc1c4f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 18:25:11 +0000 (19:25 +0100)]
Diagnostic requests will occur depending on their frequency.
Hardcoded offset was for testing purpose, now we can use frequency offset.
Change-Id: I920e61cd8f587ead9c77aec158edb4dee28b927d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 18:23:55 +0000 (19:23 +0100)]
Wrong error handling when fire diagnostic request.
As returned code was negative value the sd_event_source stopped considering
that was an error. If statement was to check that sd_event_set_enabled was
ok, so unref and return wasn't at the right location...
Change-Id: I91cc943c20af80a31b4f66f5714ccef93c0fdbd2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 18:11:43 +0000 (19:11 +0100)]
Generate a configuration example with diagnostic messages filled too.
It was filled by hand for the moment.
Change-Id: Ie72cd670bbc9c7a568507290f4bb25019ec58098
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 18:10:38 +0000 (19:10 +0100)]
Fix: decoded name will be prefixed as at subscription.
Reason is that the simple message is used to match a subscribed signals
in the map. So it has to be the same that at the subscription.
Change-Id: Ie9504583948027523a7288b5e4a20707c49b6d59
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 14:54:56 +0000 (15:54 +0100)]
Doxygen base configuration file and logo.
Change-Id: If1fbbefa386e1e72121ff28fce6f55569129272c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 14:54:31 +0000 (15:54 +0100)]
gitignore update
Change-Id: I97af1fab19d7d071e7c34d4149ae67442f257690
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 14:54:22 +0000 (15:54 +0100)]
Include cleaning
Change-Id: I5df96540400b833e684001f8fc5fa33ff1892bae
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 12:14:02 +0000 (13:14 +0100)]
Adding missing doxygen comments.
Made some cleaning about unused things or obsolete.
Review existing comments, adding missing comments.
Reformat some long long constructor.
Change-Id: Ibae247d1295a7a85b49d0ecee473022755d42b8b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 17:17:16 +0000 (18:17 +0100)]
Generated cpp file example.
Change-Id: I1608db0120a0501af0e4327fe348ef149d90bad4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 17:16:56 +0000 (18:16 +0100)]
Use index number between objects to set their links.
Needed to use generator.
Change-Id: I82b44fa1e53c55e2cd90ae7017906a22b7f0636e
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Thu, 16 Mar 2017 09:52:55 +0000 (10:52 +0100)]
added a folder to ignore in .gitignore.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 01:18:00 +0000 (02:18 +0100)]
Implement check of supported diagnostic PID.
Supported boolean member about diagnostic messages is now used. When
a response is received, completed but not successful, then set the diagnostic
message as not supported and clean the request from the queue.
Subscription remains for now, not cool but will be fix soon.
Change-Id: Ia5dc78d4a770f80f144724f4df6eabd2ffd4b8cc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 00:34:20 +0000 (01:34 +0100)]
Improve comments
Change-Id: I1e43b0aeaff738db11695e77fee23e8c9809f0c1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 00:34:08 +0000 (01:34 +0100)]
Make unsubscription works with diagnostic message too.
Now unsubscription really make unsubscription and stop polling diagnostic
request.
Change-Id: I31830c7af97506e1231fb5f1244c350520a2df29
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 23:54:46 +0000 (00:54 +0100)]
Fix comments
Change-Id: Ia838d06885bc95196c5afc3668c0b028cb0f2763
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 23:54:34 +0000 (00:54 +0100)]
Fix diagnostic message name mismatch at decoding.
Retrieve adr name prefixed will add uneeded prefix as it is already present.
At build time of a Diagnostic request from a diagnostic message, this prefix
is added so adr name is already correct.
*adr: active diagnostic request
Change-Id: Ie5c364bf47a28c80290021651941cd37fa26321a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:47:21 +0000 (23:47 +0100)]
Follow rename operation in CMakeLists.txt
Rename has been made with filter-branch using utility
git-mv-with-history, so file history follow the rename operation.
This is a commit to fix include and CMake file.
Change-Id: I8542c7def3143854a2008fa069dd3232f2497394
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:31:23 +0000 (23:31 +0100)]
Small fixes
Align frequency type to float and removed useless code.
Change-Id: I13d9407808c42ece0d3fd761351752ad661e01e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:30:37 +0000 (23:30 +0100)]
Finalization of decoding part of diagnostic messages.
Diagnostic request must have a name to be subscribed. Else, we
can't decode or event push for now.
Change-Id: I0901a71da31320d8598e512614437aceb552713d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:20:27 +0000 (23:20 +0100)]
Retrieve easily Diagnostic Request PID from an Active Diagnostic Request
Change-Id: I787cd94b338c458fda0259bd2bcf47a1fa85cc3f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:18:33 +0000 (23:18 +0100)]
Ease use of openXC structures.
Add some helpers functions used to check VehicleMessage validity or build
default VehicleMessage struct.
Change-Id: Ia1cca8b4cb3dd70a739d0f2ee9165b72fdac48d4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:16:59 +0000 (23:16 +0100)]
Rename class and 1:1 map to JSON description file
Added decoder and callback member that will be set by generator and taken
at submission to be used later, storing them into an active diagnostic
request instance, when response CAN message comes in.
Change-Id: I9ded05de3bb28ec55e4e007d72d0e1924141a6a6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:10:46 +0000 (23:10 +0100)]
Make available decoding OBD2 messages method to be use as callback.
Change the method to static 'cause it will be call from outside of the class.
Change-Id: I88dcd845559fac7892cd489cd6e8198c143ee2a8
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 22:07:34 +0000 (23:07 +0100)]
Simplification of checking Diagnostic response.
A CAN message will be considered as a Diagnostic response when its
arbitration ID is between standardized 0x7E8 and 0x7EF.
Checking which request belong to that response will done in later methods
Change-Id: I7a093edf44b62a4552b90fe3d8935f94dc677cf4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 16:58:50 +0000 (17:58 +0100)]
Improve memory allocation about Signal states.
Returning to Signal states map avoiding hole in vector allocation as we did
not know how many state a Signal can takes. So a map may be a better choice
Will see.
Change-Id: Ie3ccdbd31296c5c0ebaefc109e75f2e0cde03756
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 15 Mar 2017 12:04:42 +0000 (13:04 +0100)]
Revert accessing CAN device with a map indexing on dev name
Main reason for that behavior revert is because of generator that rely
on CAN device name and so we have point on these object by specify the
device name.
Instead of shared pointer between objects, instead binding is based on
device name. With a device name you can get the shared pointer on it using
new static method from can_bus_t object.
Change-Id: I331e0ad8d03c88a15c697d12a9fce3699b0cd962
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:51:38 +0000 (00:51 +0100)]
Uniformization between get_name() method of signals.
can_signal_t and active_diagnostic_message return name
with prefix using this method. If you need without it then
use get_generic_name.
Change-Id: I6b153eb20214049c10619d39fcc65c8641a9e32f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:50:17 +0000 (00:50 +0100)]
Littles comments improvments
Change-Id: Idcc7e5b4dedad8e39eb829b25502d7dea3e5b29a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:49:55 +0000 (00:49 +0100)]
Change way to check prefix of signals name.
Change-Id: I9a0726ab41c4801e7a5305731ce78ddd03aff9e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:48:49 +0000 (00:48 +0100)]
Improve shims_logger function to get full details.
Change-Id: I752db65cb3fbca4d33b932f3a0c597adfaf79903
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:48:15 +0000 (00:48 +0100)]
Get recurring requests works.
Implements event_loop logic.
Change-Id: Ia5ac32820a0421bbcb69d8b0dd3bea2b7b582444
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:47:06 +0000 (00:47 +0100)]
Simplification of diagnostic manager. Delete uneeded vector
Control size manually, don't rely on STL container.
Change-Id: Iede2f9b233c5b8a6dc77c9b146ffc92da8e7a989
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:44:51 +0000 (00:44 +0100)]
Return period without unit conversion.
If conversion must be made then make it at the call
not upstream.
Change-Id: Ief6dee40355c7b39b5e27d0ba3dc02717fadf43b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 23:43:59 +0000 (00:43 +0100)]
Search signals against name not generic_name. It's made
to get able to get difference between classic CAN messages
and diagnostic messages based on name signals prefix.
Change-Id: I696facc58f38150e0457d519dcabffba750a8db3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 16:21:48 +0000 (17:21 +0100)]
Less control before process the CAN message.
Change-Id: I341d29d217b2a92652e9985d8c93829e0211bddc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 16 Mar 2017 16:20:42 +0000 (17:20 +0100)]
Implement regular event launching using systemd event loop
Regular events is made launch a timerfd event from binder event loop and then
in the event handler, reschedule next launch in the future based upon the
signal frequency.
Change-Id: I0b1e84eb2135474f4bcc5ee256ba513eea4035a6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 10:07:59 +0000 (11:07 +0100)]
Improve logging messages and change string conversion to char
for the needed case. They were some inversion between needs of
char variable and string.
Fix: don't add diagnostic request if it is an unsubscrition
operation.
Change-Id: I1acedc413e7c5fe57da86812faf8d3c83d13c405
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 09:48:07 +0000 (10:48 +0100)]
Move diagnostic requests scheduling to diagnostic manager
while adding the request. It is more logic to make that here
than in the subscription operation.
Change-Id: I19b29bc11c5fb6e5828a0bf189fac1333b0199ed
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 09:03:42 +0000 (10:03 +0100)]
Fix: Initialization and entries flow
between diagnostic manager vector.
Change-Id: I9ea196b5dc5bbf2dd4509080a9a58d754fa42b6c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 14 Mar 2017 09:01:02 +0000 (10:01 +0100)]
Enabling recurrent check of diagnostic requests.
Change-Id: I16aff65c5ce22faac78e3f1d99ce7b33941c007c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 23:13:57 +0000 (00:13 +0100)]
Improve Doxygen comments and formating.
Change-Id: Ia39e78aca00a49c7cee5e42d26ba1ef2b49d3709
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 22:11:52 +0000 (23:11 +0100)]
Improve: DEBUG messages.
Change-Id: Ib52f22e7bc5bc5d14edbb31ad6006caee23c4098
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 22:11:41 +0000 (23:11 +0100)]
Fix: return before initialization of diagnostic manager.
Change-Id: I8485dec1ec5bb5dbea7edf4d9ac3a7d800b567b2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 22:11:18 +0000 (23:11 +0100)]
Make decoder systematic use of openxc-utils to build
its objects. We don't want random initialization on
boolean value of openxc_DynamicField (has_string, has_numeric...)
else we have a risk that the final decoded and convert into json
object will not be the good one.
Change-Id: If4d69e6ace615fd8e097ba9a04e5482c82b9a7db
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 22:08:43 +0000 (23:08 +0100)]
Implement signals states decoder and change map
to a vector.
Change-Id: I185724f2966fecac6659d401751da56d2886ed9d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 22:07:33 +0000 (23:07 +0100)]
Search into generic_name as well as name + prefix, but
always register generic_name into subscribed_signals.
It will be the output on event and make easier to find
the subscribed signals into the map without prefix.
Change-Id: Iaf0060bedb54003b0c77121afd2bd35d832dba25
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 16:46:50 +0000 (17:46 +0100)]
Adding/Fix classes constructors to make them correspond
to the ones generated.
Change-Id: I6b0b778f59ac52fe66e36a327f60ae58550ac271
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 16:46:13 +0000 (17:46 +0100)]
Separation of classes in the same file.
Change-Id: Ifc690cc27028659ffaf5a8a2e9caabc1e0718fd4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 14:03:00 +0000 (15:03 +0100)]
Move member from obd2_signals_t class to
active_diagnostic_request_t (adr)class. It's more logical
to have them here as call about incoming diagnostic CAN
messages are made against adr class not obd2_signal_t that
it's a subset of diagnostic messages.
It's made to handle obd2 requests as well as normal UDS
diagnostic request for constructor proprietary diagnostic
signals.
Change-Id: I96c714640d6ecfa25dfc9942974057c1797eb0e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 13:58:22 +0000 (14:58 +0100)]
Get decoding diagnostic request from decoding thread of can_bus_t
Decoding divided in 2 subfunctions dedicated to decode either
pure CAN messages or diagnostic (obd2) message. About now,
a diagnostic request has a name then it will be pushed
on the event_queue as a SimpleMessage. Without name full
details of diagnostic response will be pushed as diagnostic
response. This behavior follows the one from OpenXC.
Change-Id: I255f3f6487fa9511ea47c74606014995a7b0f720
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 08:45:01 +0000 (09:45 +0100)]
Change the way to check signal type making prefix_
attribute as static with a static class method which
will check that the beginning of string argument
matches the prefix.
Change-Id: Idb129c7179391da61447996560957b2791aa9383
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 08:20:27 +0000 (09:20 +0100)]
Reordering class method.
Change-Id: I61cca1117a987280383538a0b0e307429bee4fc3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 11:55:31 +0000 (12:55 +0100)]
Adding instruction to use the binding.
Miss an example with an UI or CLI interface.
Change-Id: Ib26fe53f16fbdeb79f79fee15fce20ce3342d210
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 08:18:34 +0000 (09:18 +0100)]
Fix: set to microsecond frequency check of diag request
Change-Id: I871ff68afd7f398d4c7d3a550c8926c1f7e67cb3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 08:02:45 +0000 (09:02 +0100)]
fix: test for opened CAN socket.
Change-Id: If9e3a0511c7ccc703817069a56bd38d7e64ebb09
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 13 Mar 2017 07:45:22 +0000 (08:45 +0100)]
Keep subscription to signal simplier without doubling
functions dedicated to different signal type as they
aren't so much difference between.
Change-Id: Ic2090c2d755136183dfc08a9b84efa3388d3747b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 23:04:37 +0000 (00:04 +0100)]
Default value about thread state set at false.
Change-Id: I1934aa4d9a9d945a32d8e369cf0f36b1e06d3f34
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 23:01:41 +0000 (00:01 +0100)]
Change configuration location into an etc directory.
Change-Id: I4648f2eb203f37844bfb8deb2527f93b4852e82c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 22:26:25 +0000 (23:26 +0100)]
Fix: wrong location to make the increment because we use
the device after so... This was total crap !
Change-Id: I9bb43c3f75c613a5927f342b3c574871c0eb65bb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 21:42:15 +0000 (22:42 +0100)]
Fix CMakeLists file to get isotp correctly linked and adding
missing libssytemd
Change-Id: Id065ff16a7f582ba1cf88423c75bf4c11fb026d9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:52:05 +0000 (19:52 +0100)]
Missing include header and code reordering and cleaning.
Change-Id: I37b2b2b439bb72d2230d606b9ddd52c3eb08ea8f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:51:38 +0000 (19:51 +0100)]
Change method returned value. Needed with send_request()
method to retrieve the active_diagnostic_request.
Change-Id: Icfba704e40be211021dc81ec18fa3602d736afdb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:48:21 +0000 (19:48 +0100)]
Implemente way to send diagnostic request when subscribed.
When subscribed, the signal is added to recurring request list
of diagnostic manager and an event is added to the systemd
event loop with timer set using frequency parameter from the
requested signal.
Change-Id: I4d604c498047d7744c090b7f03fce0f2b427fd01
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:44:07 +0000 (19:44 +0100)]
Use of signals prefix to be able to distinguish type of
messages to be processed.
For now, processing prefix is hardcoded but idea is to
process them dynamically if possible. To be studied.
Change-Id: Iac0c96228fc5f53e3c637e54350188ff3de6d57f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:38:49 +0000 (19:38 +0100)]
Make diagnostic manager initialization processus.
It is initiliazed with by default the first CAN bus
device in the CAN bus device list from CAN bus manager.
The object is instancied at configuration_t object first
invokation and after all CAN buses has been initialized then
the diag manager is initialized too.
Change-Id: I4894f2c62f575676c34efec3608b97de8c5326e1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 12 Mar 2017 18:24:54 +0000 (19:24 +0100)]
Adding diagnostic_messages from diagnostic.json file
from openxc example. The json is now a mixed example
between CAN messages and diagnostic messages.
Change-Id: I94ed5ac7d48e1fb1bb42b3df00d953d45ee0fc7d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 15:08:06 +0000 (16:08 +0100)]
We doesn't modify member once getted, we can use const return
and const method.
Change-Id: I0f7465af74b1c9a546af45a0d1eea33c93537e0c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 14:53:27 +0000 (15:53 +0100)]
Manage prefix on CAN and OBD2 prefix. Searching signals
is made on generic_name (without prefix) and returned
vector of string is filled with name with prefix. Then
you can process on them based upon their name differently.
OBD2 signals will generated recurring request on diagnostic
manager and decoding will not be handled the same way too.
Change-Id: I2c5239ef49661941a0a748debe0bd536b2954b3a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 14:15:30 +0000 (15:15 +0100)]
Remove uneeded define as it was already present in uds.h
Change-Id: I04091b35ec072e9c19f5af0689ed89db0d5070bd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 14:14:56 +0000 (15:14 +0100)]
Instead of a global pointer, config is now a Singleton.
Change-Id: I0cfc34f330c531ba5f070542a1cb723be4bcc70a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 14:14:05 +0000 (15:14 +0100)]
Also initialize the id_ renamed address_ member. This member
is mapped to the address node from json
Change-Id: Ied13067723552c2396337a9f85fe5e1418ba8caf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 12:09:19 +0000 (13:09 +0100)]
Keep raw pointer for now as we have to move them around vector.
Change-Id: I8a518540b54552d60c6fd1054a0fc41dda5400b4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Fri, 10 Mar 2017 09:16:05 +0000 (10:16 +0100)]
fixed the build script when rebuild action is triggered.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 09:11:44 +0000 (10:11 +0100)]
Finalize the class active_diag... to get it compile.
Fix subsequents bugs into the other depending class
diagnostic manager
Change-Id: I8920c489fc15a61a36ff29d58aab59c2e6388f85
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:09:23 +0000 (02:09 +0100)]
Change also where wgt file is since we build into a subdirectory
Change-Id: I8cf568292035f1e8fd73d41ed91d5bd7d9d7c512
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:06:57 +0000 (02:06 +0100)]
Adding requests to diagnostic manager implemented.
Needed overload of operator and constructor set for
active_diagnostic_message_t class. Without we can't make
the basic operation needed by the manager.
Get rid of original raw pointer on "entry" which avoid some
tests.
It miss the acceptance filters implementations for now.
Change-Id: I1ca61ff843c13255af6d9a60ce72a8b8bc9d1c18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:03:02 +0000 (02:03 +0100)]
Adding needed getter for diagnostic manager. Useful
to determine if both object use the same CAN bus device
Change-Id: I97dbf807198a420c305c8fbbd2cb4bfcdda4c294
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 10 Mar 2017 01:02:00 +0000 (02:02 +0100)]
Adding needed function to get some time handle on request
for diagnostic at first.
Change-Id: I3ab966d6386bad52f68ebdbea723bb7507cfaf2a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 20:08:57 +0000 (21:08 +0100)]
add a helper script to build, can be use by VS2017.
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 20:08:11 +0000 (21:08 +0100)]
add VS2017 files to .gitignore
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:56:56 +0000 (16:56 +0100)]
Fix: include statement with wrong path.
And minor fixes.
Change-Id: Ica55c0708edd86d0aa37e7117b3c3fad551a0167
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:11:43 +0000 (16:11 +0100)]
Added constructor to get vector initialized with default
objects initialized that can be grabed after at runtime.
Don't know the impact on performance for now about maximum
limit.
Change-Id: I220614d479b8254ae0efda66380e96434bcbfbb2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 15:28:33 +0000 (16:28 +0100)]
separation to a new file of can_message_set_t
Change-Id: If21021d8905d40d443d4432faeb38f8a3275697c
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 15:01:08 +0000 (16:01 +0100)]
Change FrequencyClock struct to class and rename it.
Change-Id: I1076ad90e14815f3d0ab71ca9fa359d1d3c1748d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Loïc Collignon [Thu, 9 Mar 2017 13:32:55 +0000 (14:32 +0100)]
fixed CMakeLists.txt
Change-Id: I62069f71b53a7a0e2131ca92834a9a85995308a7
Signed-off-by: Loïc Collignon <loic.collignon@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:07:57 +0000 (13:07 +0100)]
Fix: wrong tested variable for socket.
Change-Id: Ice2325441474f1a075140e13dfffa0261106dff7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:07:16 +0000 (13:07 +0100)]
C Header first
Change-Id: Ief8c66e99c689a362b645ad3b918d8b342ada59a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:06:56 +0000 (13:06 +0100)]
Add necessary to be able to initialize diagnostic manager shims.
We have to conform to functions signatures from isotp-c
to have it working.
Change-Id: I429def66f54e53277e87aa99e66292cdb47c1c5f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 12:03:13 +0000 (13:03 +0100)]
Reorder to fix warning at compilation
Change-Id: I1e558720318d9251ddfbbf6bb66a0461aef98e4c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 10:57:35 +0000 (11:57 +0100)]
Changing to a raw pointer can_bus_dev member and add
a default constructor.
It is needed to initialize configuration_t correctly as
it allocate a diagnostic manager but do not initialize it
unless it is needed later. There is no need to initialize it
if we do not send and receive diagnostic requests.
Change-Id: I3d52d1ea92454e7b065479a2f0dd54a291ddd991
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:43:30 +0000 (10:43 +0100)]
Fix: wrong signature due to reference discarding "const".
Change-Id: I7dada9d01eb8619c3807647b6df378dd147bb7fb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:42:20 +0000 (10:42 +0100)]
Fix: bugs in class due to the wrapping of C socket
into a class.
Added missing include and adjust methods signature.
Change-Id: Id016b452e0b641a14482c288e4713acae941ee1d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 9 Mar 2017 09:16:45 +0000 (10:16 +0100)]
Fix: use of new objects and type conversion missing.
Change-Id: I583ad536de619fed2be655a493299fe43cc65924
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Code Review / apps / agl-service-can-low-level.git / log