Add gitreview file for Super Salmon branch

Update the .gitreview file.

Bug-AGL: SPEC-5331
Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Change-Id: I867a4201aef90b6e75de31c9ed6bafeb9bb5685f

Add gitlab issue/merge request templates

Add template files for gitlab

Bug-AGL: SPEC-4474
Signed-off-by: Jan-Simon Moeller <jsmoeller@linuxfoundation.org>
Change-Id: Id0e7df16cfd1e4d47beb71eff56f350a5ce74adc

fix history segfault following transport disconnect

The segmentation fault manifests if the remote
disconnects pbap transport followed by a refresh
pbap data operation.
The root cause is a read operation of
vcard data for the calls history, ignoring the error
triggered while attempting to access the
corresponding file on the remote device.
The current patch introduces the missing check for
errors.

SPEC-3652
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I916ba5b8b5fc29aa9b928dbf2ed3e7c892d15891

test & deleteme

Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I9efa151af54ae87cbf7e67bb6b985a76e0814549

fix contacts data caching mechanism

* Substitute  calls to persistence binding's
non existent 'write' verb with 'insert' verb
(part of the current api), eliminating
runtime warnings.
* Update code to conform to v3 bindings:
'afb_service_call_sync' is a deprecated method
for appfw v3 bindings, substitute with the recommended
'afb_api_call_sync' method.
* Rebalance refcount for query object.

Bug-AGL: SPEC-3619
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Change-Id: I1453a86ca24b9e90128d9e8bd2ee8f588fe5faa8

fix(bluetooth-pbap.lua): add import test

Complete the missing verb test.

In this service, import verb is the precondition of the other verbs,
such as contacts, history.

Bug-AGL: SPEC-3458

Change-Id: I7206f30bd4b58f4ec41c1693bea543c7c886e8ec
Signed-off-by: Li, Xiaoming <lixm.fnst@cn.fujitsu.com>

Update autobuild scripts

Update autobuild scripts with reworked version that fixes building
outside of the source tree.

Bug-AGL: SPEC-2049, SPEC-3300

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ideb9fe6fb2f50c26440288f095e1a25c148dcbc0

Update autobuild script to create new targets

Update autobuild script to create multiple widget target debug, coverage and all

Bug-AGL: SPEC-2049

Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
Change-Id: I5ec7dfd6e0b0cbf71c9f2fe2a7fde3fe310a6f80

Update .gitreview file

This updates the gitreview file in the project

.

Change-Id: I981a3533700fb81a783d6d7de8c9d694e73b54f6
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>

binding: pbap: add missing return after afb_req_fail call

To avoid calling afb_req_success after failure return after
the afb_req_fail call in contacts verb.

Bug-AGL: SPEC-2630
Change-Id: I2d521d7c04a4be7dd49e8a63cf1ac267de636de8
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

fix(test/CMakeLists.txt): make test wgt work

Bug-AGL: SPEC-2795

Change-Id: I6921c02a76fe903beb5502dbe8e5644c34e7735c
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>

fix(confg.cmake): set PROJECT_URL to slience CMake warning

CMake Warning at /xdt/sdk/sysroots/x86_64-aglsdk-linux/usr/share/
cmake-3.12/Modules/CMakeAfbTemplates/cmake/cmake.d/
02-variables.cmake:98 (message):
  No homepage url found.  Please set a PROJECT_URL cmake variable in
  your config.cmake.
Call Stack (most recent call first):
  /xdt/sdk/sysroots/x86_64-aglsdk-linux/usr/share/cmake-3.12/Modules/
  CMakeAfbTemplates/cmake/common.cmake:101 (include)
  /xdt/sdk/sysroots/x86_64-aglsdk-linux/usr/share/cmake-3.12/Modules/
  CMakeAfbTemplates.cmake:19 (include)
  conf.d/cmake/config.cmake:166 (include)
  CMakeLists.txt:21 (include)

Bug-AGL: SPEC-2804

Change-Id: Iad7cc6476d2e07629299edc1bae092a533065a46
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>

fix(bluetooth-pbap-binding.c): Remove -Wformat warning

agl-service-bluetooth/agl-service-bluetooth-pbap/binding/
bluetooth-pbap-binding.c:173:13: warning: format ‘%ld’ expects argument
of type ‘long int’, but argument 7 has type ‘size_t’
{aka ‘unsigned int’} [-Wformat=]
AFB_ERROR("Read only %ld/%ld bytes from %s", n, size, filename);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~
agl-service-bluetooth/agl-service-bluetooth-pbap/binding/
bluetooth-pbap-binding.c:173:13: warning: format ‘%ld’ expects argument
of type ‘long int’, but argument 8 has type ‘size_t’ {aka ‘unsigned int’}
[-Wformat=]

Bug-AGL: SPEC-2422

Change-Id: I90504163278b3bbd415b73021bd32eaa2a759572
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>

Link to library libm

The binding used lrint since a long time but wasn't
linked against libm. It implied that loading of the
binding by the binder was failing because the symbol
"lrint" wasn't resolved.

This change add an explicit link to libm.

Bug-AGL: SPEC-2742

Change-Id: I4bfb78c0e5eca2fbb330a81b69fc1794642b7fff
Signed-off-by: José Bollo <jose.bollo@iot.bzh>

binding: pbap: move data transfer results to shared directory

Data transfers needs to be stored in /run/user/UID/usrshr to
get the User::App-Shared Smack label on creation from obexd

Bug-AGL: SPEC-2695
Change-Id: Ib32b1d02bb008311bbad975263af28452bf1647e
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

Revert "binding: bluetooth-pbap: add scope-platform permission to config.xml.in"

This reverts commit f207663c1dd42351e858907f4b1020af492f0e73.

Bug-AGL: SPEC-2575 SPEC-2695
Change-Id: I9baebc0a58b876fb230f550a11f72fdf17cf8ea0
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: add check on file pointer

Avoid segfaulting if obex data transfer result cannot be
accessed due to permissions.

Bug-AGL: SPEC-2695
Change-Id: Iae75af3e44f7e8265f1a9a52d2343d358c985bfc
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: add scope-platform permission to config.xml.in

Add urn:AGL:permission::partner:scope-platform to run on the platform scope.

Bug-AGL: SPEC-2575
Change-Id: I4a12158de80b791a6af25c947592e58a27bf7c96
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: add import verb to improve transfer of contacts

Previously contacts are requested on every connection of a device by
OBEX transfers, and due to issues with transfer rates it should be only
done when requested.

import verb requests new phonebook transfer, and returns data as the
contacts verb currently does.

Also this patchset switchs from the canonical MAC address to using the
identifier from the Bluetooth stack for better connection tracking.

Bug-AGL: SPEC-2541
Change-Id: I27ad0626248e8dba0cacd65f34843b8eec2ca754
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

Adding tests for agl-service-bluetooth-pbap.
Running the tests requires actual paired and currently connected phone with phonebook entries.

Bug-AGL: SPEC-2524
Signed-off-by: Edi Feschiyan <edi.feschiyan@konsulko.com>
Change-Id: I1713d8976b8855f2d802a9ed51728272735a463a

binding: bluetooth-pbap: parse fn correctly for UTF-8 charset

Don't include CHARSET=UTF-8 or the like in the JSON output.

Bug-AGL: SPEC-2392
Change-Id: I85322e710b737bdfa58fe80ff5f0bbc0e298250b
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: add vcard parser framework

Parse the vCard information within the binding itself, and
reduce service consumers processing and dependencies.

Bug-AGL: SPEC-2392
Change-Id: Ie7654c4ba6d269cb8224e61021e19739614afb4e
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: save cached contacts by per device

Use the respective device's MAC address as an key for caching
of contacts. This allows multiple devices to be paired with
each having their own cached results.

Bug-AGL: SPEC-2311
Change-Id: Iadc4da383a5e0860866414c9228e2e10ba238395
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: use persistence binding for caching

Caching of contacts moved into storing in the persistence binding

Bug-AGL: SPEC-2311
Change-Id: Ie9fa7b3e01f84f17101b211204575fc77bdc9a67
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: remove useless .gitmodules

Bug-AGL: SPEC-2268
Change-Id: I91cb1edf6a31322679d9fb2b27646a5cc45c68dc
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

autobuild: fix warnings due to cp command exit error

- bring latest version of autobuild script in
- move conf.d/autobuild to root folder
- update autobuild script to fix warnings triggered by
  cp operation error.

Change-Id: I23c00cce5257dcc3a9fc381f8a1306e3535c7e98
Bug-AGL: SPEC-2164
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>

binding: bluetooth-pbap: fix device disconnect check

address parameter in properties isn't usually sent in a disconnect
so just use the bluetooth stack device name.

Change-Id: I75a7a7212fe06f63816e8cdadd0f29610ce80c82
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: cache contacts list on connection

Populating the contacts list can take several seconds for the OBEX
transfer to complete. So to avoid phone UI delays service is started
at startup, and populates a cached version of contacts for clients.

Change-Id: I1687fc6bc075964b71be4515c5048bff1861b4ec
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: remove compiler warnings

Remove compiler warnings on gdbus generated code by regenerating
with gdbus-codegen 2.56.3

Change-Id: I1a5f136873a44a09cb0cc2b13aa273a38f5d45e4
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: fix hang when an invalid handle was requested

If an invalid handle was requested the wait condition wouldn't ever return.
This patchset handlest the error condition and gracefully alerts the user.

Change-Id: I05fdc6dfff998789aaa9332b1cc755b8e3fd970a
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: add initial README.md

Bug-AGL: SPEC-2095
Change-Id: Ib932342dd9f3da2b5f40648c2c11de325a519639
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth: change 'card' to 'handle' as field name

To keep parameter and field repsonses consistent name 'card' to 'handle'
which entry verb uses.

Bug-AGL: SPEC-2095
Change-Id: I7964469a631b5aeb19814b595c4c4f4ca394040a
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: bluetooth-pbap: upgrade bluetooth binding calls to version 2.0

Bug-AGL: SPEC-1630
Change-Id: If9efc97fb5f89a31ca08eb1189156a3519475601
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

Migrate app-templates to CMake module

Bug-AGL SPEC-1682

Change-Id: I74bf7414e3925c6aab8f8895885551c473219ce4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

binding: pbap: upgrade afb framework to version 3

Change-Id: I8c580ca04151e10581bcdf51dca7fc408ae85f7b
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

Use feature 'required-binding'

The feature "urn:AGL:widget:required-binding" is now
preferred to the feature "urn:AGL:widget:required-api"
for requiring a local binding.

Bug-AGL: SPEC-1800

Change-Id: I6fd143c82298e9afa3d8eb7c3788bd3890810b4b
Signed-off-by: Jose Bollo <jose.bollo@iot.bzh>

binding: bluetooth: pbap: remove session-dump.xml

Remove xml file that is likely only useful for initial development.

Change-Id: I65a895ab708fd6402853de2efa45f49b959975ae
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: pbap: change default build to RELEASE

By default the build should be RELEASE and not the DEBUG option

Change-Id: Idc1c9173b47c1cad655368eca1f2909415c7147b
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

binding: pbap: add missing conf.d/autobuild files

Add missing build scripts along with uprev the conf.d/app-templates
git submodule

Change-Id: I48a477451867fd8098d58b6f18eaa3525123d59d
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>

Send connection status upon event subscribe

When the status event is subscribed, immediately
send the current PBAP connection status.

Bug-AGL: SPEC-1519

Change-Id: I222789f81040c80fb67dac63c889c96586ba0dbd
Signed-off-by: Matt Porter <mporter@konsulko.com>

Add connection status event and verb

Adds a status event and a verb which reports the
current PBAP device connection status. This allows
applications to determine when to refresh data or
display alternative data if a PBAP connection is
unavailable.

Bug-AGL: SPEC-1519

Change-Id: I7c3bd7081be3a850cebb3c708a0be95fc685a6fc
Signed-off-by: Matt Porter <mporter@konsulko.com>

Add LICENSE file

Copyright notices cite Apache 2.0 so add the missing
LICENSE file.

Bug-AGL: SPEC-1437

Change-Id: I028f8e6fc8306943cdd870f7275efb75086c5a38
Signed-off-by: Matt Porter <mporter@konsulko.com>

Initial Bluetooth PBAP binding

Supports the following features:

  - retrieval of phonebook contacts
  - retrieval of call history (incoming/outgoing/missed/combined lists)
  - retrieval of individual contact entry by handle
  - search for contact by phone number

Bug-AGL: SPEC-1437

Change-Id: I1d0d5c4c02e5ba4a5db1bcfc932421fd9d478426
Signed-off-by: Matt Porter <mporter@konsulko.com>

Initial empty repository