Romain Forlot [Mon, 25 Nov 2019 11:39:30 +0000 (12:39 +0100)]
init: Fix wrong diagnostic bus name returned.
We use the bus name which isn't correct because it isn't the device name.
Change-Id: I5c9313817a3f3d423f8934cfab03e2cf20d48af2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 18:52:30 +0000 (19:52 +0100)]
all: format
Remove unecessary brackets and replace if possible
if...else by ternary operator.
Change-Id: Ibe46b83dea976e050b9cd9eb7ee7ab2c33b63905
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 15:07:17 +0000 (16:07 +0100)]
decoder/encoder: typo
Change-Id: I9ebea118770a9ffe0dd4321408643e76250e3635
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 13:08:41 +0000 (14:08 +0100)]
converter: Use unsigned int whenever it's possible
Use unsigned int whenever it is possible instead of uint32_t.
This let the compiler decide the type. We do not need to use
uint32_t explicitly for the converter.
Change-Id: Ic2af875e7435668928c454df76e59c5c43b08407
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 12:39:52 +0000 (13:39 +0100)]
bitfield-c: use unsigned int instead of uint8_t
Use unsigned int instead of uint8_t upon destination and source array length.
This is needed to handle gathered multi-frames message data which could
be greater than 1 simple messages.
Change-Id: I107bff383c2d0771dbc2a30770ec5c195b1c22ac
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 11:42:01 +0000 (12:42 +0100)]
decoder/encoder: simplification of code.
- Useless tests removed
- Bit operation changed to more readable ones
- Handle correctly mask to decode signal on 1 byte or in-between bytes more clearly.
- using static_cast now instead of C casting method.
- Avoid manual vector initialization and using default constructors instead.
- Avoid using intermediate variables when this isn't necessary.
Change-Id: I049d65f460109772b57df7572bdac8e6500242e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 23 Nov 2019 08:00:50 +0000 (09:00 +0100)]
encoder: use switch case to handle CAN protocols
Better using switch case than if...else. This would be more extendable
and readable.
Change-Id: I5fb03531ad77441bcb7d1620bdb07d82aa6a4eb4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 21 Nov 2019 16:59:07 +0000 (17:59 +0100)]
message: Correctly detect extended CAN id.
Previous test was always true. This fix the wrong test and then
add the EFF flag correctly on messages using extended
CAN id.
Change-Id: I69686fd3d5a39ea3a0d1980b4bfa88fe36fb7fe5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 21 Nov 2019 15:13:52 +0000 (16:13 +0100)]
socket: Raise an error if open function failed.
The socket opening wasn't tested and we fails later on another function
using the wrongly opened socket. This would not happens anymore.
Change-Id: I9b30bd9fc13b99277cbef6f7aeaddadc57ad0b18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 21 Nov 2019 12:44:24 +0000 (13:44 +0100)]
low-can-hat: improve format
Weird way test to make test are now fixed to be more readable.
Change-Id: I81d716ac3799c4217e720a13d8ba78a46996a2c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 21 Nov 2019 10:21:08 +0000 (11:21 +0100)]
low-can-cb: Fix add a missing include.
Since binding separation in 3 parts binding+lib+plugins we got
a include missing about find_if function.
Change-Id: Iae9ff1a72a06875aec2d0a08d049f4a00bbfecc3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 20 Nov 2019 18:46:11 +0000 (19:46 +0100)]
low-can-cb: improve readability
Just make thing more readable by define variables at the beginning of
functions. And directly assign them if possible.
Also improve format using the same format than in the rest of the project.
Change-Id: I5cc7685b80734d0eb43a29fc06b2a8434f3469fa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 20 Nov 2019 14:31:14 +0000 (15:31 +0100)]
can-bus: Use configuration from JSON file
Use configuration from JSON file instead of the old INI file. Now all configuration files
lies within the binding tree.
Change-Id: Id986d19751db958ad5cf3b7f2b2c5443d4ceb062
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 20 Nov 2019 12:02:24 +0000 (13:02 +0100)]
message: More explicit define about CAN protocols.
Change a bit CAN binding define about used protocol. There was a mistake
about BCM define which isn't a protocol at all but a maner to filter
and retrieve CAN message through SocketCAN. Also FD_FRAME was using the
same name than SocketCAN which isn't a good idea, better to distinguis both
of them.
Change-Id: I255fa03029c7d5f90a33448e5e7692d8c249279b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 20 Nov 2019 09:49:27 +0000 (10:49 +0100)]
decoder: fix left behind character
Change-Id: I28cf984024356925469b4971b993718276d1240f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 19 Nov 2019 18:25:26 +0000 (19:25 +0100)]
low-can-cb: Mark the end of the CtlSections array
Change-Id: I433f4f699f3234fc07fcd909cd6b77b84e447ad7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 19 Nov 2019 15:44:38 +0000 (16:44 +0100)]
converter: littles improvements.
Change-Id: I9198835b96c66c140f8b1d4167828302b9dc4959
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 19 Nov 2019 11:44:05 +0000 (12:44 +0100)]
examples: Update using new Generator
New generator including new signals capabilities:
- sign
- big_endian frame
- default length
Change-Id: Icf2e4dd7ef880a73527103c90a8063cf3d042e41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 19 Nov 2019 08:14:35 +0000 (09:14 +0100)]
plugins: Use agl-vcar plugin by default
Change-Id: I8935210e4cc2ec290a809bc1bfece4c36d367cda
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Fri, 15 Nov 2019 11:46:44 +0000 (12:46 +0100)]
cmake: separate binding into lib+binding+plugins
This separation is needed to be more flexible and be able to load plugins
representing CAN signals dictionnaries instead of using a hardcoded one.
Change-Id: I8e07eed0dea36473d43b8d68416e8ca210269980
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Corentin Le Gall [Mon, 18 Nov 2019 15:48:20 +0000 (16:48 +0100)]
Fix bit_position swapping
-Added an attribute to signals that tells if the bit_position
has been swapped.
-Test if bit_size and bit_position gives an "out of range" data
Change-Id: I589565ca923ec807da2d4f0db7c4c92fb737b579
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Clément Bénier [Fri, 15 Nov 2019 10:20:34 +0000 (11:20 +0100)]
sign: handle decode methods sign from can value
- add enumeration that represents the way of encoding:
enum sign_t
{
UNSIGNED = 0,
SIGN_BIT = 1,
ONES_COMPLEMENT = 2,
TWOS_COMPLEMENT = 3,
SIGN_BIT_EXTERN = 4
};
- the function handle_sign allows to transform value if negative and
return the sign of the value in order to be multiplied at the end ot the
parcing
Change-Id: I5766a286488170d930422474b4c4f3a8578ca726
Signed-off-by: Clément Bénier <clement.benier@iot.bzh>
Corentin Le Gall [Thu, 14 Nov 2019 18:13:25 +0000 (19:13 +0100)]
can: Add big endian CAN frame layout handle
- can-decoder.cpp: translate_signal() : Tests "frame_layout_is_little".
If false the signal's bit position is changed to fit the layout.
- message-definition.cpp: Added the new attribute
"frame_layout_is_little" and its getter.
- signals.cpp: Added a setter to the bit_position attribute.
- converter.cpp: Added a methode to convert a big endian bit_position
to a right (little endian) bit_position.
Change-Id: I004c9069eb00f389564927cd12d1b30470c3a59d
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Romain Forlot [Thu, 14 Nov 2019 14:09:57 +0000 (15:09 +0100)]
application: Add dedicated function to set parents
Change-Id: Iedd493b9e4043290dae0aa9d1d94a3d9179525ae
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 14 Nov 2019 11:51:29 +0000 (12:51 +0100)]
low-can-cb: Retrieve application from external controller data
Change-Id: Iaa55b00539b1435b00fe076918d5eda5eeb5db30
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 12 Nov 2019 16:06:46 +0000 (17:06 +0100)]
message_set: Remove build warning using C++ string
Change-Id: Ibf8e24a81466eab7aa11ed2100892f5796557b5e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 12 Nov 2019 15:20:00 +0000 (16:20 +0100)]
examples: updates
Change-Id: I9c71038690d301e513f736a3405c3367f64fdbda
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 12 Nov 2019 13:44:02 +0000 (14:44 +0100)]
test: Update tests with new transport
Change-Id: I3a0e4ea451f9e01fc13b7498b9eb20e81548ce5d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 12 Nov 2019 11:16:53 +0000 (12:16 +0100)]
doc: Update documentation
Change-Id: Ifbeb00ef74d7a83db66808ae59dc9422b2e8593a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 10 Nov 2019 18:17:18 +0000 (19:17 +0100)]
can_message: add missing signature due to conflict
Change-Id: Ib705ae7c500bb9d3abc863053943298c87896bd2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 10 Nov 2019 15:48:14 +0000 (16:48 +0100)]
hat: Move some binding functions into the hat
Change-Id: I3a9f616078bc7fa9317995ec4300ee2b61aa4b08
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 10 Nov 2019 12:47:44 +0000 (13:47 +0100)]
messsage_definition: add name getter method
Change-Id: I8c31ed12cc8e1eeb1a758a908181e96be799ad4e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sun, 10 Nov 2019 09:18:45 +0000 (10:18 +0100)]
message_set: New methods to add messages at init
Change-Id: Ic2e8169c9e3392198f5e0f6f5d28c2eea1ec98d4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 9 Nov 2019 17:09:30 +0000 (18:09 +0100)]
binding: add preinit function to load the config
Make as the others bindings using controller and load its configuration file
at preinit step.
Change-Id: I344c1982893e47600a0b8cd03542de8069a42d24
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 9 Nov 2019 15:59:36 +0000 (16:59 +0100)]
All: Make format coherent with the whole project
Add a space after a comma
Change some aligments
Change-Id: I5069120f4bbb33742bb4990e2e1f391ec8d5eeb6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 9 Nov 2019 12:21:43 +0000 (13:21 +0100)]
diag-mng: Change way to initialize the diag bus
This was kind of hardcoded and now, it is initialized by a configuration key
of the controller configuration JSON file.
Change-Id: I6e24c28781c08bd8e99de33f16b5ae10d1a6a9a1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Sat, 9 Nov 2019 08:22:17 +0000 (09:22 +0100)]
all: Copyright update
Change-Id: I9794c48d0f7567cc3fdc7dff21b4fcee47296514
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 7 Nov 2019 16:04:12 +0000 (17:04 +0100)]
message_set: typedef long type signature
Convert two long types using typedef to get shorter one
Change-Id: I9f5612def1bce512516a6e1a45711486368bbc51
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Thu, 7 Nov 2019 15:29:32 +0000 (16:29 +0100)]
controller:initialize an empty message_set to fill
Initialize an empty message_set to fill later when loading the Plugins
Add the required method to be able to add a message_set
Change-Id: I1dc784648f69832de8681184adaccbf5300f831d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Thu, 7 Nov 2019 13:16:16 +0000 (14:16 +0100)]
controller: Prepare project ot use the Controller
Change-Id: I39c39da66f9a0716bd75dc82824941508c236bf2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Thu, 7 Nov 2019 09:06:25 +0000 (10:06 +0100)]
write: Add feature to build messages and fix some functions
Allows to build a message (J1939,BCM) with a signal and a value.
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: Iadca13a927ff83f713f39da441c88356695a1285
Arthur Guyader [Wed, 6 Nov 2019 17:51:23 +0000 (18:51 +0100)]
examples: update examples and can_samples
Update of examples for new features (is_fd,is_extended,is_j1939).
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: I8c3afbafdde4f5818d73c0e71a3b7e47fb7d8fc6
Romain Forlot [Wed, 6 Nov 2019 14:41:23 +0000 (15:41 +0100)]
j1939: don't process signals using same bus
Change-Id: I8733a35e4f9cb3d0f2fce818b55a010fec19dc66
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 6 Nov 2019 10:31:50 +0000 (11:31 +0100)]
j1939: update using latest commits in linux-next
Change-Id: Id01e92330582da299af675676987cd667272e2c5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 6 Nov 2019 08:46:31 +0000 (09:46 +0100)]
converter: decoder: use appropriate int types
Change-Id: I7e977647b23ecd5be1f58486af857e3b7132b48f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 5 Nov 2019 18:33:29 +0000 (19:33 +0100)]
all: Format one line 'if' or 'for' statement.
Change-Id: I58ae7a48de5569c488f9d265946a81f180051ce2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 5 Nov 2019 14:37:47 +0000 (15:37 +0100)]
subscription: Optimizing opening sockets
Also review some aligment and make more space between bool ops
Change-Id: Id1880cbde10cc8deec66a6be163d8a012dbaa0f9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 5 Nov 2019 12:55:19 +0000 (13:55 +0100)]
can: clean and format
Little optimization in create_rx_filter_can function and
make format coherent on bit operations.
Change-Id: Ic9c53ba4c937604bbf3500ee89c7b5a5dbca7cfd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 5 Nov 2019 09:14:35 +0000 (10:14 +0100)]
can: Fix receiving and sending extended CAN frames
Change-Id: I672450b51b46082b6a913bef2d6e27d64c49e6fc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 4 Nov 2019 16:17:27 +0000 (17:17 +0100)]
can: Remove extended flags
It doesn't matters to know whether or not a can signal is
using standard or extended CAN ID because this could be
retrieved using bit mask on the CAN ID when receiving and
sending.
Change-Id: Id96c576045bf087df51beb011742ad631336f814
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Mon, 4 Nov 2019 12:21:08 +0000 (13:21 +0100)]
cmake: Remove build warnings
Remove unused flag with C++.
Change-Id: I85376914f64b9dfe9015a6439185ad6a53cdb117
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Scott Murray [Wed, 13 Nov 2019 05:37:23 +0000 (00:37 -0500)]
Add steering wheel LIN message signal definitions
Add signal definitions for the button status information in the
steering wheel demo LIN message.
Bug-AGL: SPEC-2951
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Id4909161f8f159858a3d29e310a3b43a787f2d03
Li Xiaoming [Fri, 30 Aug 2019 01:45:56 +0000 (09:45 +0800)]
refactor(config.xml.in):Replace required api with required binding
Appfw docs:
"required-api local": OBSOLETE SINCE FF (AGL6), PROVIDED FOR
COMPATIBILITY.Use the feature urn:AGL:widget:required-binding instead.
Bug-AGL: SPEC-2781
Change-Id: I9627f1c59d89f9687c09a41a3bedf1c56bb90f59
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>
Arthur Guyader [Wed, 28 Aug 2019 09:34:00 +0000 (11:34 +0200)]
Update documentation
Bug-AGL : SPEC-2779
Change-Id: I461f7e32322faba7e822791ff2e3851039e03548
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 09:51:26 +0000 (11:51 +0200)]
Remove file socketcan-j1939 that was not removed before
Bug-AGL : SPEC-2780
Change-Id: I4ddf9389faffebe0334b0004b69bb7336277c29d
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Thu, 29 Aug 2019 10:46:13 +0000 (12:46 +0200)]
Remove in function convert_from_addr, the variable flags was not used
Bug-AGL : SPEC-2780
Change-Id: Ib31a32565c3bc38ea039003bd924a43318fb7c4e
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:49:37 +0000 (15:49 +0200)]
Remove in function rx_filter_can, the variable val was not used
Bug-AGL : SPEC-2780
Change-Id: Ifce6e67fd55699d088952b0f722694d211ec7398
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 13:40:55 +0000 (15:40 +0200)]
Add new decoders bytes for signal of long size
This commit adds the decoder bytes. It allows to
return a sequence of bytes in hexadecimal form.
Bug-AGL : SPEC-2780
Change-Id: I27180774f044c48a9d7baa2739b15a2e85b8b2e2
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 09:41:57 +0000 (11:41 +0200)]
Change signature of decoders
This commit changes the signature of decoders. It is
now necessary to specify the version of the signals
so that the low-can-generator generates the associated
wrapper and not need to modify the decoder already
developed.
Bug-AGL : SPEC-2780
Change-Id: I044b1a3a6bacb9fc59bd6d3f77a1dbc437a3aa86
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:48:29 +0000 (14:48 +0200)]
Add some typedef to reduce the size of the lines
Bug-AGL : SPEC-2779
Change-Id: Iebcf7492133cd7789d301593ff999b24ae10a054
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Wed, 28 Aug 2019 08:36:40 +0000 (10:36 +0200)]
Change vector to list to allow to remove signal.
This commit allows to remove signals. We need that because
subscription to an iso tp message needs to be individual.
Bug-AGL : SPEC-2779
Change-Id: I1d6410ebfc8ea82d33addf1bb828d9cd810b006a
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:45:58 +0000 (14:45 +0200)]
Update bit position and bit size in signal
It's necessary to change the size of attributes
to manage multi packet signal.
Bug-AGL : SPEC-2779
Change-Id: If211c218ffa5a2e81ccfb32d3a5eeae0267e8f74
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:44:48 +0000 (14:44 +0200)]
Add feature ISO TP (multi frames and peer to peer)
This commit adds the ISO TP feature. The ISO TP protocol
allows to communicate between two ECU. The protocol
allows multi packets management.
Bug-AGL : SPEC-2779
Change-Id: Ic222615b547f28e926930e6c1dea2c0265055afd
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:43:08 +0000 (14:43 +0200)]
Replace all enum types with masks
This commit allows to change all enum types by masks.
Now to implement new protocol you don't need to add
more attribute in class. All can be contained in
the flags field.
Bug-AGL : SPEC-2779
Change-Id: I814d0052139be5d5efefc9ff1b4b558f46b85e90
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:46:08 +0000 (15:46 +0200)]
Update function tx_send for multi frame prevision
Bug-AGL : SPEC-2779
Change-Id: Ib0b04fe3648c5b83c23327431e21161b6b2489b6
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Wed, 14 Aug 2019 11:28:11 +0000 (13:28 +0200)]
Only defined signals can be written
This commits ensure that only known signals
could be written using the binding's api.
Before that you was able to wrote raw frames
on the CAN bus without any checks if this
was a known signals to the binding.
Bug-AGL : SPEC-2779
Change-Id: Ied6680e926f2a9c221fee31d8fb78d2d39c41132
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:41:46 +0000 (15:41 +0200)]
Update function rx_filter_can for multi frame prevision.
This commit updates the functions rx_filter_can to anticipate
the development of the multi-frame.
Bug-AGL : SPEC-2779
Change-Id: I5f67cf84e5d3e47c75c588f8776ead92eb6c3c8e
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:39:33 +0000 (15:39 +0200)]
Change function get_bcm_msg to return a reference.
Bug-AGL : SPEC-2779
Change-Id: I303d2423151dac497917299737070ffb645267d3
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:40:08 +0000 (14:40 +0200)]
Move attributes flags and maxdlen
This commit moves attributes flags and maxdlen from
class can_message_t to class message_t.
Bug-AGL : SPEC-2779
Change-Id: I56f9cd54d8b9822636311c603501326b36692cf4
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Wed, 14 Aug 2019 11:22:15 +0000 (13:22 +0200)]
Add function remove last bcm frame
This commit creates the function remove_last_bcm_frame.
This function removes the last bcm frame of the subscription.
Bug-AGL : SPEC-2779
Change-Id: I5bb6f07a8d677c4aa882549fc1950f00a0b1da04
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:33:13 +0000 (15:33 +0200)]
Add many frames in a subscription in the function tx_send.
This commit convert the message to a vector of canfd_frame.
If there are several canfd frames then we add all of them
to the subscription.
Bug-AGL : SPEC-2779
Change-Id: I876aaf5ab7fed2fedb79367f77b987ba4745cdfc
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 13:32:20 +0000 (15:32 +0200)]
Add function to convert vector to canfd or can frame.
This commit allows to convert the data vector to canfd or
can frame. In the two cases the struct is a canfd frame,
but if the type is not fd, the max size of a frame is 8.
Bug-AGL : SPEC-2779
Change-Id: I60edf6a602a47572d5e5bfb508c7ca6d8761832b
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 12 Aug 2019 14:27:51 +0000 (16:27 +0200)]
Add function get_data_vector with index
This commit adds the function get_data_vector to get
another vector between the index indicates.
Bug-AGL : SPEC-2779
Change-Id: I704d78467839ee7f9a2fec397e9b0db8da43d79d
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Mon, 26 Aug 2019 14:48:28 +0000 (16:48 +0200)]
Update function to encode and decode message
This commit update encoder and decoder files.
This new implementation allows to manage larger signals.
Bug-AGL : SPEC-2779
Change-Id: Iec6dfbd279863aa8b8e8f9e3ce951f0c8aa80dae
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:37:01 +0000 (14:37 +0200)]
Update j1939 decode with function to_hex
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: Ia10abfd73a6ea9d42770566e23bc4b206723f081
Arthur Guyader [Mon, 12 Aug 2019 09:51:34 +0000 (11:51 +0200)]
Add file converter to manage all conversions
This commits create a class converter
to access conversions functions.
For example to_hex, or for future usage
in multi packet signal_to_bits_bytes.
Bug-AGL : SPEC-2779
Change-Id: Ife652006a7756547184ed548bda5ffef0d09d941
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Arthur Guyader [Tue, 27 Aug 2019 12:34:37 +0000 (14:34 +0200)]
Uniform indentation with tabulation
Bug-AGL : SPEC-2779
Change-Id: I834221ae1a04fdb188062ce1b7251e648c4845de
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Romain Forlot [Mon, 12 Aug 2019 15:58:50 +0000 (17:58 +0200)]
Fix: only one subscription could be made
Only one subscription could be made and then only one subscriber
could receive associated events. As the relationship between events
and subscriber is not 1-1 but 1-N, so this was the mistake. Now 1 event
is created for N subscriber where before there was 1 event for 1
subscriber and subsequent subscribers could not receive same events
than the ones already subscribed.
Bug-AGL: SPEC-2726
Change-Id: I4e4a80ac9f9b6b4c6b006108ee55f355a7c1e377
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Mon, 29 Jul 2019 13:21:08 +0000 (15:21 +0200)]
Update documentation.
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: I9e6b07ef48d634fe643e0eb2477fedfd34a7abb9
Arthur Guyader [Mon, 29 Jul 2019 13:20:32 +0000 (15:20 +0200)]
Add tests for J1939 features.
This commit adds tests for the J1939 features.
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: I2545eb2f9a27561714fc5efcbd885afcb237770d
Arthur Guyader [Mon, 29 Jul 2019 12:53:14 +0000 (14:53 +0200)]
Integrate the J1939 features : address claiming and write.
This commit allows to write J1939 messages and add the management
of the address claiming.
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: I1bb95a7ba6f6ebe463319c3972d9d46897181d51
Arthur Guyader [Mon, 29 Jul 2019 10:19:13 +0000 (12:19 +0200)]
Add feature to build messages and fix some functions
Allows to build a message (J1939,BCM) with a signal and a value.
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: Iadca13a927ff83f713f39da441c88356695a1285
Arthur Guyader [Tue, 2 Jul 2019 15:46:16 +0000 (17:46 +0200)]
Update examples and can_samples
Update of examples for new features (is_fd,is_extended,is_j1939).
Bug-AGL: SPEC-2386
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Change-Id: I8c3afbafdde4f5818d73c0e71a3b7e47fb7d8fc6
Romain Forlot [Mon, 1 Jul 2019 16:55:23 +0000 (18:55 +0200)]
signals.cpp: Make an insensitive string comparison
When sending a CAN signal make an case-insensitive comparison as it isn't
necessary to be strict on that, so case insensitive if fine.
Update the documentation accordingly.
Bug-AGL: SPEC-2582
Change-Id: I998b64cdd9a381da3da582aeba42ab726fff1259
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Sebastien Douheret [Thu, 27 Jun 2019 18:41:05 +0000 (20:41 +0200)]
Fix spelling
Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Change-Id: Iea56414f8ccf3d96b2fc67126b066c4032fe86a8
Sebastien Douheret [Thu, 27 Jun 2019 18:32:38 +0000 (20:32 +0200)]
Fix invalid markdown filename in documentation
Bug introduced by previous commit ID
b8261a3b218
Bug-AGL: SPEC-2386
Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Change-Id: I3694f955109e5828bdf0209cc705655a0ed002c0
Romain Forlot [Tue, 25 Jun 2019 14:23:02 +0000 (16:23 +0200)]
Minor improvements
- Remove now unused forward declaration of active_diagnostic_request_t
- Factorize calling the signals_manager at binding initialization.
- retab...
Bug-AGL: SPEC-2386
Change-Id: I418fddd80ef8b856c198dc697760a6edf0918012
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Fri, 24 May 2019 10:17:17 +0000 (12:17 +0200)]
Add J1939 frame example.
Bug-AGL: SPEC-2386
Change-Id: I4478b3cd1e60a8e46e4602c38265962c4c3575a8
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Fri, 24 May 2019 10:17:12 +0000 (12:17 +0200)]
Update the documentation for J1939.
Bug-AGL: SPEC-2386
Change-Id: Ice568aebb10cc6eb3d7ac013b2e6ce08451332ba
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 25 Jun 2019 13:33:12 +0000 (15:33 +0200)]
Updating application-generated.cpp.
This commit updates differents application-generated.cpp files
with the low-can generator updated with j1939.
This commit adds the description of j1939 messages.
Bug-AGL: SPEC-2386
Change-Id: I798a7da34c1be3526fec6bc3e424a6b88eaf46ff
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 25 Jun 2019 14:24:39 +0000 (16:24 +0200)]
Small fixes (include and pointer)
Bug-AGL: SPEC-2386
Change-Id: I3a622b9d236283aff479f187451cd86557a9aba7
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 25 Jun 2019 14:21:31 +0000 (16:21 +0200)]
Modify function to open socket j1939
The function open_socket has been modified
to open a j1939 socket with a filter
Bug-AGL: SPEC-2386
Change-Id: Ieed5c1d14efdb469f5a7b831c9e8a950e04e9d42
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Fri, 24 May 2019 10:16:57 +0000 (12:16 +0200)]
Add the possibility to subscribe an id or a pgn
The commit allows at the time of subscription to do:
-> low-can subscribe {"id": 48}
-> low-can subscribe {"pgn": 61442}
The generation of event_filter has been extracted in a separate function.
Bug-AGL: SPEC-2386
Change-Id: I592e668c63be448562b27c81fcdc111cd34f3676
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 26 Jun 2019 13:51:19 +0000 (15:51 +0200)]
Rename some of the classes removing can- prefix
This commit renames files and classes :
- can_message_definition_t -> message_definition_t
- can_message_set_t -> message_set_t
- can_signals_t -> signals_t
This prepares the implementation of j1939 protocol.
Bug-AGL: SPEC-2386
Change-Id: Ie3ee4f25c236c861b92eb12a56fa03a5a9afffbb
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 26 Jun 2019 08:05:42 +0000 (10:05 +0200)]
New constructor j1939 message definition
Add a new constructor for the j1939 message definition
with additional name and data length member.
Bug-AGL: SPEC-2386
Change-Id: Iff531f122942b6741a6a97718e639a4814b8d2bf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 26 Jun 2019 08:34:04 +0000 (10:34 +0200)]
Change can_message_t class usage for new j1939
This commit transforms the class can_message_t as the base class
and creates two derived classes: j1939_message_t and can_message_t.
Bug-AGL: SPEC-2386
Change-Id: I6d3afd8e4f5abff2cd0ec4e9910bd52a2893de76
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Wed, 26 Jun 2019 07:14:42 +0000 (09:14 +0200)]
Add CMake option to compile with J1939
Add option USE_FEATURE_J1939 to compile j1939 in file config.cmake
This will be set up by default depending on the presence on the
building host of the J1939 CAN module headers.
Bug-AGL: SPEC-2386
Change-Id: I54d4594ff01d4e509bfa0862f3cb486562024aed
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 25 Jun 2019 15:12:37 +0000 (17:12 +0200)]
Use subscription's sockets as shared_ptr
This change is made to leverage C++ to read and write the different socket
classes depending on CAN protocol used.
Bug-AGL: SPEC-2386
Change-Id: I5e25e271fc82e9627f836aeb43b2af5ef25db83a
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Romain Forlot [Tue, 25 Jun 2019 15:13:22 +0000 (17:13 +0200)]
Use shared_ptr to set message_set parent
Better to use shared_ptr instead of raw pointer if possible.
Bug-AGL: SPEC-2386
Change-Id: Id853d8ac6cddd1e53edd84e3bf27b0f1f5d92d4b
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
Arthur Guyader [Fri, 24 May 2019 10:16:28 +0000 (12:16 +0200)]
Implement a new socket type CAN for j1939 protocol
This commit implements a new socket class for the j1939 protocol and
prepares the bases classes by modifying the write and read methods.
Bug-AGL: SPEC-2386
Change-Id: I16ba493418a4bb37a0262b61a2a2629be6ab5051
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>