message: move bit position flag and action

Separate some define to be in a dedicated header file that will
be installed on the system. Then the low-can-generator could use it
instead of having to copy those defines in the generator code.

Change-Id: I1716c8b20f0811ca4ac1e8f13609f05ad7d24d1f
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter : Add "0x" for hex data

Change-Id: I9a46b0b87d56a73fb75fafafb0509ca66bb68dd3
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: Fix copying all bytes but the last one

Change-Id: I8c2fce0f8080f213fda26a054f691ba3ed457bda
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

plugins: Remove J1939 condition in CMakeLists file

Remove condition to fix library link problem. This makes
the build not happens at all if you don't have the J1939
CAN Kernel module isn't installed.

Change-Id: I52f7bf2d6806e33505450c809a5ce7c463d91ab9
Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can-bus: process signal rework to subscribe message

This commits allows to subscribe message and have all signals
in one frame.

Change-Id: I95de0e46b30be09a47a04754266cb55650eeec31
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can_decoder : Move frame swap to only do it one time

This commit allows to swap only one time a data message.

Change-Id: I566c6ad72e266cd59a4397ab1a5ef423d752cf75
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

openxc-utils : Add json value for DynamicField

Change-Id: I93d31768804d4e30994897487e9fd312a56c547b
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low_can_subscription: Add msg_def and create_rx for message

This commit adds message_definition variable to subscribe to
message and not signals. And the function that init rx_filter
for message.

Also patch the error message

Change-Id: I98b0b4dc8fec6ccef6e103fcb8aae136f708aa16
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

Cleanup examples, tests, configuration and plugins

This commit updates all files external to the code.

Change-Id: I910bc300c53b7669573bba414db7d7ad74313697
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

signal_t : Remove attribute is_big_endian

It is not used in the actual context.

Change-Id: I6334ff9a037cec4f61deea56048b3109ad1362ab
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

Update flag FRAME_LAYOUT_IS_BIGENDIAN to BYTE_FRAME_IS_BIG_ENDIAN

Change-Id: I13a3392aecd8d57fac6f94346c4cf209595775b4
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

format: remove uneeded brackets.

Change-Id: I0689d62e32b9b60059adc2d4be78fa3b2581441c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter: Improve the continental bit calcul

This is an improvment of the bit_position computing. This now operate only
on full bytes to get the position.

Change-Id: Idb4993a3c9922d50d02379139e7cbbe5a2cb501b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

examples: Update examples j1939

Change-Id: I060994c4b553c6ae52becd52f8b0bfa795230743
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder: Add new decoders: ascii, date, time

Change-Id: I392bff2c1f4062aee186875335786fcda9cc0649
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can_bus: Add unit in the json that low-can emits

This commit allow if the unit is defined to display it
in the json emmits by low-can.

Change-Id: Ia09d4d9614eba6de93292ffab351fa1f4e612b73
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

tests: Test the value of signals decoded

This commit adds test to check if the value of signals
is well decoded.

Change-Id: I64f489d6428bf593dfda08dc6aacbdacd9d18d73
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

test: Add tests filter

This commit patch an error in the test low-can_FikterTest01.lua.
This test crash other tests if not patch.

Change-Id: I2163811853ddc1ab7b84616b006c302d9e1b27fc
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

j1939: Follow updates of the kernel

This commit patch j1939 feature after the update of the
kernel from linux-can-next to mainline.
Now promisc option removes filter of the bind.
The option is now a parameter in the event_filter.
The feature recv_own isn't available, you can't receive
on the same socket an emit frame from you.
Not a big problem because receive and send method use two
different sockets in the implementation.

Change-Id: I5ac410177c1512090827870300b8aa1679477b84
Signed-off-by: Arthur GUYADER <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

socket-j1939: Function add_filter return int to check error

Change-Id: Ia79320108e8293d2b7a5beba4f49036999d5ebbb
Signed-off-by: Arthur GUYADER <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

msg_def: returns pgn if j1939 used

This commit patch function get_id. It was only capable to return
id and id extended. Now it returns also pgn.

Change-Id: If5feb7e2ee3bc5ca33b16620d1b998c95414dda8
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

diag_mngr: No diagnostic msg if no diagnostic_bus

Change-Id: I840fc6cc7e9cfd171b03cac508fedb8ece4b976d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can-cb: Little opti

Change-Id: I6f3e84700563fc60e643d770365c98342214bedd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: Rework message flags

Adding bit_position and frame manipulation flags

Change-Id: Ibd727a54a33a78b49f2c319b4b70dcda21ea87cb
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

encoder: use contructor to initialize the vector

Instead of initilizing using a for loop...
Also fixes a wrong watched bit using a bcm socket

Change-Id: Ib65a3da06dbd249c97b8ec11823247120505d545
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter: Improve bit_position computation

- Fix wrong bit_position swap computed:
Need to multiply then lenght in bytes by 8 to get it for bits.

- Add a continental bit_position function:
This allow to get the correct bit_position using the weird Continental.
bit numbering method where the Frame is read using little endianness
and bit count using a big endianness

- Use define CHAR_BIT instead of hardcoded 8 value

Change-Id: I8d458ab457f80e5fa116af942acfceaaef51b763
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder: reformat function to parse the bitfield

Change-Id: Ia024b9d87d219f69aac0613d6e14b623e37300a6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: Default frame layout as little endian.

Change the flags to be enable if frame use big endian rather than
little

Change-Id: I09ae9c54f1d807da4e740457cf04a001723edb0e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

diag-mngr: Fix sending and change init

This commit fix the wrong bcm ival1 value set because the struct
hasn't been initialized so it use a wrong value that can not be
handled by the socket.

Initialize diagnotstic manager depending on JSON configuration file

This avoid to request engine_speed signal when there isn't any diagnostic_bus
configured in the JSON file.

Change-Id: I98145a6e20c29a644c856d818f104c6bd8069f9f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

socket-bcm: Format, simplification of open socket

Change-Id: I8a012285a8d06f3c5778c82e543c944d8fa20e3c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder: rework how to swap frame layout.

This also change the bit_position to retrieve the bit word starting from the left
or the right of the frame depending on the endianness of the frame layout.

Change-Id: I28658e9d46bd35d8ecabeece317331832229384a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: optimize getting subpart of a vector

Change-Id: Ifdaea3bf0969f15eb70629a92c0293ddeee33491
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

msg_definition: integrate frame layout as a flag

Integrate frame layout as a flag instead of a separate boolean

Change-Id: I0fe32fd8a80238006ef89152af25001ecdf018c9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

misc: Some cleanup and fixes about signatures.

Change-Id: Ib3e1df0d3741274336c8806ae82082e33d4d3a92
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

ini-config: remove ini-config lib

No need to use ini-config now that the config is hold by the controller
JSON configuration file.

Bug-AGL: SPEC-2988

Change-Id: If82d22266fb2d592c140b81cda783ee63f1f13be
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

all: format typo

Bug-AGL: SPEC-2988

Change-Id: I81c01a817cd31d577068350d8445a1df2751bff7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

config: Fix wrong controller configuration file name

Bug-AGL: SPEC-2988

Change-Id: I6491c1bb4b64d7f005f220e4d2358ce787bf84af
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

init: Improve error message when not finding config file

Bug-AGL: SPEC-2988

Change-Id: I9a9dec6e577881bbd784bcae1d17ddb244d94599
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can: Fix init failing when using without J1939

Return variable was initialized to 1 instead of 0 and without using J1939
this variable isn't reaffected and so the final test fails.

Bug-AGL: SPEC-2386

Change-Id: I53b7cd757b3b344d66ab18ba9795284105cbcfcc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

cmake config: WIDGET ENTRY POINT FIX

renamed afb-low-can-binding.so

Bug-AGL: SPEC-2988

Change-Id: If72c1fc75891b01c3baaa9c8d776e3a2e5ea128c
Signed-off-by: Clément Bénier <clement.benier@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter: Fix to_hex conversion

Convert byte to hex without forgetting '0's.
ex: Before: '10' -> 'a'
    After: '10' -> '0a'

Bug-AGL: SPEC-2991

Change-Id: I7346893eaf83aaa9294e48c20cbffd1a61789b51
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

plugins: Conditionnal building of the j1939 plugin

Bug-AGL: SPEC-2988

Change-Id: Idf77aa32ca4fd44163d93d0515f21d51f1d7abd7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

apidef: fix no preinit defined.

This commit fixes the binding initialization by specifying a
preinit function that parse and load the controller configuration

Bug-AGL: SPEC-2988

Change-Id: I040c401fa2818d056a61a2858829bc4db2cffece
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

cmake: fix lib not populated and RPATH usage

RPATH as to be used as target property.

Bug-AGL: SPEC-2988

Change-Id: Ifaa66ceafbe7ed5f7de553b14da2dd8c5b1e8f9d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message-def: Fix code to avoid warnings

Bug-AGL: SPEC-2988

Change-Id: I8ded9847a5923b3a78afc953551fc6daaf40b355
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

socketcan-bcm: Fix wrongly opened socket

This commit fixes a problem once a bcm socket has been opened
but the following ioctl failed. Before we still return the socket
number instead of returning a negative value as error.
This resulted in problem because the subscription was considered as valid
and binding was continuing using the closed file descriptor.

Bug-AGL: SPEC-2988

Change-Id: Iaa64e7bb00980cb8c0e7080aca238cfb57d628b6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

init: Fix wrong diagnostic bus name returned.

We use the bus name which isn't correct because it isn't the device name.

Bug-AGL: SPEC-2988

Change-Id: I5c9313817a3f3d423f8934cfab03e2cf20d48af2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

all: format

Remove unecessary brackets and replace if possible
if...else by ternary operator.

Bug-AGL: SPEC-2991

Change-Id: Ibe46b83dea976e050b9cd9eb7ee7ab2c33b63905
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder/encoder: typo

Bug-AGL: SPEC-2991

Change-Id: I9ebea118770a9ffe0dd4321408643e76250e3635
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter: Use unsigned int whenever it's possible

Use unsigned int whenever it is possible instead of uint32_t.
This let the compiler decide the type. We do not need to use
uint32_t explicitly for the converter.

Bug-AGL: SPEC-2988

Change-Id: Ic2af875e7435668928c454df76e59c5c43b08407
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

bitfield-c: use unsigned int instead of uint8_t

Use unsigned int instead of uint8_t upon destination and source array length.
This is needed to handle gathered multi-frames message data which could
be greater than 1 simple messages.

Bug-AGL: SPEC-2988

Change-Id: I107bff383c2d0771dbc2a30770ec5c195b1c22ac
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder/encoder: simplification of code.

- Useless tests removed
- Bit operation changed to more readable ones
- Handle correctly mask to decode signal on 1 byte or in-between bytes more clearly.
- using static_cast now instead of C casting method.
- Avoid manual vector initialization and using default constructors instead.
- Avoid using intermediate variables when this isn't necessary.

Bug-AGL: SPEC-2988

Change-Id: I049d65f460109772b57df7572bdac8e6500242e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

encoder: use switch case to handle CAN protocols

Better using switch case than if...else. This would be more extendable
and readable.

Bug-AGL: SPEC-2988

Change-Id: I5fb03531ad77441bcb7d1620bdb07d82aa6a4eb4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: Correctly detect extended CAN id.

Previous test was always true. This fix the wrong test and then
add the EFF flag correctly on messages using extended
CAN id.

Bug-AGL: SPEC-2988

Change-Id: I69686fd3d5a39ea3a0d1980b4bfa88fe36fb7fe5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

socket: Raise an error if open function failed.

The socket opening wasn't tested and we fails later on another function
using the wrongly opened socket. This would not happens anymore.

Bug-AGL: SPEC-2988

Change-Id: I9b30bd9fc13b99277cbef6f7aeaddadc57ad0b18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can-hat: improve format

Weird way test to make test are now fixed to be more readable.

Bug-AGL: SPEC-2988

Change-Id: I81d716ac3799c4217e720a13d8ba78a46996a2c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can-cb: improve readability

Just make thing more readable by define variables at the beginning of
functions. And directly assign them if possible.
Also improve format using the same format than in the rest of the project.

Bug-AGL: SPEC-2932

Change-Id: I5cc7685b80734d0eb43a29fc06b2a8434f3469fa
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can-bus: Use configuration from JSON file

Use configuration from JSON file instead of the old INI file. Now all configuration files
lies within the binding tree.

Bug-AGL: SPEC-2988

Change-Id: Id986d19751db958ad5cf3b7f2b2c5443d4ceb062
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

fix: missing include to find find_if function

Change-Id: I099b951011442ffaebf75a319236a39553999a41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message: More explicit define about CAN protocols.

Change a bit CAN binding define about used protocol. There was a mistake
about BCM define which isn't a protocol at all but a maner to filter
and retrieve CAN message through SocketCAN. Also FD_FRAME was using the
same name than SocketCAN which isn't a good idea, better to distinguis both
of them.

Bug-AGL: SPEC-2988

Change-Id: I255fa03029c7d5f90a33448e5e7692d8c249279b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder: fix left behind character

Bug-AGL: SPEC-2988

Change-Id: I28cf984024356925469b4971b993718276d1240f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can-cb: Mark the end of the CtlSections array

Bug-AGL: SPEC-2988

Change-Id: I433f4f699f3234fc07fcd909cd6b77b84e447ad7
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

converter: littles improvements.

Bug-AGL: SPEC-2988

Change-Id: I9198835b96c66c140f8b1d4167828302b9dc4959
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

examples: Update using new Generator

New generator including new signals capabilities:

- sign
- big_endian frame
- default length

Bug-AGL: SPEC-2988

Change-Id: Icf2e4dd7ef880a73527103c90a8063cf3d042e41
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

plugins: Use agl-vcar plugin by default

Bug-AGL: SPEC-2988

Change-Id: I8935210e4cc2ec290a809bc1bfece4c36d367cda
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

cmake: cleaning and set RPATH for binding

Cleaning and set RPATH to find the low-can library

Change-Id: I6e68a61bbeca385433028a716b9ac6d5e7f28769
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

decoder: Fix bit_position swapping

-Added an attribute to signals that tells if the bit_position
has been swapped.
-Test if bit_size and bit_position gives an "out of range" data

Bug-AGL: SPEC-3022

Change-Id: I589565ca923ec807da2d4f0db7c4c92fb737b579
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

sign: handle decode methods sign from can value

- add enumeration that represents the way of encoding:
    enum sign_t
    {
UNSIGNED = 0,
SIGN_BIT = 1,
ONES_COMPLEMENT = 2,
TWOS_COMPLEMENT = 3,
SIGN_BIT_EXTERN = 4
    };

- the function handle_sign allows to transform value if negative and
return the sign of the value in order to be multiplied at the end ot the
parcing

Bug-AGL: SPEC-3021

Change-Id: I5766a286488170d930422474b4c4f3a8578ca726
Signed-off-by: Clément Bénier <clement.benier@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can: Add big endian CAN frame layout handle

- can-decoder.cpp: translate_signal() : Tests "frame_layout_is_little".
If false the signal's bit position is changed to fit the layout.

- message-definition.cpp: Added the new attribute
"frame_layout_is_little" and its getter.

- signals.cpp: Added a setter to the bit_position attribute.

- converter.cpp: Added a methode to convert a big endian bit_position
to a right (little endian) bit_position.

Bug-AGL: SPEC-2988

Change-Id: I004c9069eb00f389564927cd12d1b30470c3a59d
Signed-off-by: Corentin Le Gall <corentin.legall@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

application: Add dedicated function to set parents

Bug-AGL: SPEC-2988

Change-Id: Iedd493b9e4043290dae0aa9d1d94a3d9179525ae
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

low-can-cb: Retrieve application from external controller data

Bug-AGL: SPEC-2988

Change-Id: Iaa55b00539b1435b00fe076918d5eda5eeb5db30
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

examples: updates

Bug-AGL: SPEC-2988

Change-Id: I9c71038690d301e513f736a3405c3367f64fdbda
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

test: Update tests with new transport

Bug-AGL: SPEC-2386

Change-Id: I3a0e4ea451f9e01fc13b7498b9eb20e81548ce5d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

doc: Update documentation

Bug-AGL: SPEC-2988

Change-Id: Ifbeb00ef74d7a83db66808ae59dc9422b2e8593a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can_message: add missing signature due to conflict

Bug-AGL: SPEC-2988

Change-Id: Ib705ae7c500bb9d3abc863053943298c87896bd2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

hat: Move some binding functions into the hat

This is needed to move using a splitted binding/library
model to have plugins linked to the lib as well as the
binding to get there symbols

Bug-AGL: SPEC-2988

Change-Id: I3a9f616078bc7fa9317995ec4300ee2b61aa4b08
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

binding: add preinit function to load the config

Make as the others bindings using controller and load its configuration file
at preinit step.

diagnostic-manager: Change way to initialize the diag bus

This was kind of hardcoded and now, it is initialized by a configuration key
of the controller configuration JSON file.

Bug-AGL: SPEC-2988

Change-Id: I344c1982893e47600a0b8cd03542de8069a42d24
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

All: Make format coherent with the whole project

Add a space after a comma
Change some aligments

Bug-AGL: SPEC-2988

Change-Id: I5069120f4bbb33742bb4990e2e1f391ec8d5eeb6
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

all: Copyright update

Bug-AGL: SPEC-2988

Change-Id: I9794c48d0f7567cc3fdc7dff21b4fcee47296514
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

message_set: typedef long type signature

Convert two long types using typedef to get shorter one

Bug-AGL: SPEC-2988

Change-Id: I9f5612def1bce512516a6e1a45711486368bbc51
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

controller: Prepare project ot use the Controller

Initialize an empty message_set to fill later when loading the Plugins
Add the required method to be able to add a message_set

Bug-AGL: SPEC-2988

Change-Id: I1dc784648f69832de8681184adaccbf5300f831d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

j1939: don't process signals using same bus

Bug-AGL: SPEC-2991

Change-Id: I8733a35e4f9cb3d0f2fce818b55a010fec19dc66
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

all: Format one line 'if' or 'for' statement.

Bug-AGL: SPEC-2988

Change-Id: Ic3b9670a2ce9e982220c54f3632f690ee4eea686
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

app-generated: update for generated steering wheel

Change-Id: I8af34595e4ea4d72af726c6c5db3ac05dda85bf2
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

subscription: Optimizing opening sockets

Also review some aligment and make more space between bool ops

Bug-AGL: SPEC-2988

Change-Id: I613f294a630caf48eea7bb0c7b9c36b07cbacfbf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

socketcan-j1939: format how to define_opt()

Bug-AGL: SPEC-2932

Change-Id: Ifec401451dc541b71dc2f98d25f5c953f1bcf532
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can: clean and format

Little optimization in create_rx_filter_can function and
make format coherent on bit operations.

Bug-AGL: SPEC-2988

Change-Id: Ic9c53ba4c937604bbf3500ee89c7b5a5dbca7cfd
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can: Fix receiving and sending extended CAN frames

Bug-AGL: SPEC-2779

Change-Id: I672450b51b46082b6a913bef2d6e27d64c49e6fc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

can: Remove extended flags

It doesn't matters to know whether or not a can signal is
using standard or extended CAN ID because this could be
retrieved using bit mask on the CAN ID when receiving and
sending.

Bug-AGL: SPEC-2988

Change-Id: Id96c576045bf087df51beb011742ad631336f814
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

cmake: Remove build warnings

Remove unused flag with C++.

Bug-AGL: SPEC-2988

Change-Id: I85376914f64b9dfe9015a6439185ad6a53cdb117
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

j1939: Following kernel updates

Compatatibility for latest kernel/glibc version
See: https://github.com/torvalds/linux/commit/0768e17073dc527ccd18ed5f96ce85f9985e9115

Follow j1939 integration in the kernel which remove SO_J1939_RECV_OWN

Bug-AGL: SPEC-2932

Change-Id: Id01e92330582da299af675676987cd667272e2c5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

Change example message 0x3D9 back to non-FD

Update agl-vcar example definition to change message 0x3D9 back to
regular CAN so it will be usable on non-FD capable hardware again.

Bug-AGL: SPEC-3012

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I74064c5a8f4111f8f774104d27b86c8f15451539
(cherry picked from commit 12e75ea716e1b5054be0228e2859e14a11be622a)

Fix filter bitmask generation

Fix filter bitmask generation in encoder_t::encode_data; the mask
bits need to be left-aligned in each byte, not right-aligned.

Bug-AGL: SPEC-3013

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ie084f81e3d8c06e69b5bb7562055187395099ac7

Update steering wheel LIN message definition

The steering wheel LIN message does not work in low-can after it has
been updated to include commit "Update function rx_filter_can for
multi frame prevision." (59bffa4 in master, a41ee0d in halibut), due
to the length value now being required in the message definition.
The length has been added to the definition for agl-vcar and the
application-generated.cpp files regenerated. As well, the new J1939
and FD flags have been added to the message definition for
consistency.

Bug-AGL: SPEC-2951

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ice079268827dfbb2bf2c79b6c5e897dcab8fc433

Add steering wheel LIN message signal definitions

Add signal definitions for the button status information in the
steering wheel demo LIN message.

Bug-AGL: SPEC-2951

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Id4909161f8f159858a3d29e310a3b43a787f2d03

refactor(config.xml.in):Replace required api with required binding

Appfw docs:
"required-api local": OBSOLETE SINCE FF (AGL6), PROVIDED FOR
COMPATIBILITY.Use the feature urn:AGL:widget:required-binding instead.

Bug-AGL: SPEC-2781

Change-Id: I9627f1c59d89f9687c09a41a3bedf1c56bb90f59
Signed-off-by: Li Xiaoming <lixm.fnst@cn.fujitsu.com>

Update documentation

Bug-AGL : SPEC-2779

Change-Id: I461f7e32322faba7e822791ff2e3851039e03548
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>

Remove file socketcan-j1939 that was not removed before

Bug-AGL : SPEC-2780

Change-Id: I4ddf9389faffebe0334b0004b69bb7336277c29d
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>

Remove in function convert_from_addr, the variable flags was not used

Bug-AGL : SPEC-2780

Change-Id: Ib31a32565c3bc38ea039003bd924a43318fb7c4e
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>

Remove in function rx_filter_can, the variable val was not used

Bug-AGL : SPEC-2780

Change-Id: Ifce6e67fd55699d088952b0f722694d211ec7398
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>