apps/agl-service-can-low-level.git
5 years agoFix branch in .gitreview 29/22929/1 8.0.3 halibut/8.0.3 halibut_8.0.3
Scott Murray [Wed, 13 Nov 2019 03:36:52 +0000 (22:36 -0500)]
Fix branch in .gitreview

Branch was incorrectly set to master instead of halibut.

Bug-AGL: SPEC-2952

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: I38fcc5f3162c6588db7944a118c384abbb00680b

5 years agosignals.cpp: Make an insensitive string comparison 02/21802/2 7.99.3 8.0.0 8.0.1 8.0.2 halibut/7.99.3 halibut/8.0.0 halibut/8.0.1 halibut/8.0.2 halibut_7.99.3 halibut_8.0.0 halibut_8.0.1 halibut_8.0.2
Romain Forlot [Mon, 1 Jul 2019 16:55:23 +0000 (18:55 +0200)]
signals.cpp: Make an insensitive string comparison

When sending a CAN signal make an case-insensitive comparison as it isn't
necessary to be strict on that, so case insensitive if fine.

Update the documentation accordingly.

Bug-AGL: SPEC-2582

Change-Id: I998b64cdd9a381da3da582aeba42ab726fff1259
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoFix spelling 82/21782/1 7.99.2 halibut/7.99.2 halibut_7.99.2
Sebastien Douheret [Thu, 27 Jun 2019 18:41:05 +0000 (20:41 +0200)]
Fix spelling

Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Change-Id: Iea56414f8ccf3d96b2fc67126b066c4032fe86a8

5 years agoFix invalid markdown filename in documentation 81/21781/1
Sebastien Douheret [Thu, 27 Jun 2019 18:32:38 +0000 (20:32 +0200)]
Fix invalid markdown filename in documentation

Bug introduced by previous commit ID b8261a3b218

Bug-AGL: SPEC-2386

Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
Change-Id: I3694f955109e5828bdf0209cc705655a0ed002c0

5 years agoMinor improvements 33/21733/4
Romain Forlot [Tue, 25 Jun 2019 14:23:02 +0000 (16:23 +0200)]
Minor improvements

- Remove now unused forward declaration of active_diagnostic_request_t
- Factorize calling the signals_manager at binding initialization.
- retab...

Bug-AGL: SPEC-2386

Change-Id: I418fddd80ef8b856c198dc697760a6edf0918012
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdd J1939 frame example. 14/21414/11
Arthur Guyader [Fri, 24 May 2019 10:17:17 +0000 (12:17 +0200)]
Add J1939 frame example.

Bug-AGL: SPEC-2386

Change-Id: I4478b3cd1e60a8e46e4602c38265962c4c3575a8
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUpdate the documentation for J1939. 13/21413/11
Arthur Guyader [Fri, 24 May 2019 10:17:12 +0000 (12:17 +0200)]
Update the documentation for J1939.

Bug-AGL: SPEC-2386

Change-Id: Ice568aebb10cc6eb3d7ac013b2e6ce08451332ba
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUpdating application-generated.cpp. 12/21412/11
Romain Forlot [Tue, 25 Jun 2019 13:33:12 +0000 (15:33 +0200)]
Updating application-generated.cpp.

This commit updates differents application-generated.cpp files
with the low-can generator updated with j1939.

This commit adds the description of j1939 messages.

Bug-AGL: SPEC-2386

Change-Id: I798a7da34c1be3526fec6bc3e424a6b88eaf46ff
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoSmall fixes (include and pointer) 11/21411/10
Romain Forlot [Tue, 25 Jun 2019 14:24:39 +0000 (16:24 +0200)]
Small fixes (include and pointer)

Bug-AGL: SPEC-2386

Change-Id: I3a622b9d236283aff479f187451cd86557a9aba7
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoModify function to open socket j1939 10/21410/10
Romain Forlot [Tue, 25 Jun 2019 14:21:31 +0000 (16:21 +0200)]
Modify function to open socket j1939

The function open_socket has been modified
to open a j1939 socket with a filter

Bug-AGL: SPEC-2386

Change-Id: Ieed5c1d14efdb469f5a7b831c9e8a950e04e9d42
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdd the possibility to subscribe an id or a pgn 09/21409/10
Arthur Guyader [Fri, 24 May 2019 10:16:57 +0000 (12:16 +0200)]
Add the possibility to subscribe an id or a pgn

The commit allows at the time of subscription to do:

-> low-can subscribe {"id": 48}
-> low-can subscribe {"pgn": 61442}

The generation of event_filter has been extracted in a separate function.

Bug-AGL: SPEC-2386

Change-Id: I592e668c63be448562b27c81fcdc111cd34f3676
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoRename some of the classes removing can- prefix 07/21407/10
Romain Forlot [Wed, 26 Jun 2019 13:51:19 +0000 (15:51 +0200)]
Rename some of the classes removing can- prefix

This commit renames files and classes :
- can_message_definition_t -> message_definition_t
- can_message_set_t -> message_set_t
- can_signals_t -> signals_t

This prepares the implementation of j1939 protocol.

Bug-AGL: SPEC-2386

Change-Id: Ie3ee4f25c236c861b92eb12a56fa03a5a9afffbb
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoNew constructor j1939 message definition 46/21746/1
Romain Forlot [Wed, 26 Jun 2019 08:05:42 +0000 (10:05 +0200)]
New constructor j1939 message definition

Add a new constructor for the j1939 message definition
with additional name and data length member.

Bug-AGL: SPEC-2386

Change-Id: Iff531f122942b6741a6a97718e639a4814b8d2bf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoChange can_message_t class usage for new j1939 08/21408/10
Romain Forlot [Wed, 26 Jun 2019 08:34:04 +0000 (10:34 +0200)]
Change can_message_t class usage for new j1939

This commit transforms the class can_message_t as the base class
and creates two derived classes: j1939_message_t and can_message_t.

Bug-AGL: SPEC-2386

Change-Id: I6d3afd8e4f5abff2cd0ec4e9910bd52a2893de76
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdd CMake option to compile with J1939 45/21745/1
Romain Forlot [Wed, 26 Jun 2019 07:14:42 +0000 (09:14 +0200)]
Add CMake option to compile with J1939

Add option USE_FEATURE_J1939 to compile j1939 in file config.cmake
This will be set up by default depending on the presence on the
building host of the J1939 CAN module headers.

Bug-AGL: SPEC-2386

Change-Id: I54d4594ff01d4e509bfa0862f3cb486562024aed
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUse subscription's sockets as shared_ptr 32/21732/3
Romain Forlot [Tue, 25 Jun 2019 15:12:37 +0000 (17:12 +0200)]
Use subscription's sockets as shared_ptr

This change is made to leverage C++ to read and write the different socket
classes depending on CAN protocol used.

Bug-AGL: SPEC-2386

Change-Id: I5e25e271fc82e9627f836aeb43b2af5ef25db83a
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUse shared_ptr to set message_set parent 31/21731/3
Romain Forlot [Tue, 25 Jun 2019 15:13:22 +0000 (17:13 +0200)]
Use shared_ptr to set message_set parent

Better to use shared_ptr instead of raw pointer if possible.

Bug-AGL: SPEC-2386

Change-Id: Id853d8ac6cddd1e53edd84e3bf27b0f1f5d92d4b
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoImplement a new socket type CAN for j1939 protocol 06/21406/10
Arthur Guyader [Fri, 24 May 2019 10:16:28 +0000 (12:16 +0200)]
Implement a new socket type CAN for j1939 protocol

This commit implements a new socket class for the j1939 protocol and
prepares the bases classes by modifying the write and read methods.

Bug-AGL: SPEC-2386

Change-Id: I16ba493418a4bb37a0262b61a2a2629be6ab5051
Signed-off-by: Arthur Guyader <arthur.guyader@iot.bzh>
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoModify to receive signal with bigger value than the number of states 66/21566/2
Hiroki Koga [Wed, 5 Jun 2019 08:37:11 +0000 (17:37 +0900)]
Modify to receive signal with bigger value than the number of states

Fix the bug about a part of decode_state in can-signals.cpp.

If a state of signal is allocated not in order, the signal
which is bigger value than the number of states cannot be received,
because can_signal_t::get_states compares signal value with
the number of states.
By this modification, get_states is changed to judges
whether a signal value exists in states or not.

Bug AGL: SPEC-2504

Change-Id: Ia67413507950654567808f7a08d0b0b3b47cbd23
Signed-off-by: Hiroki Koga <hiroki@witz-inc.co.jp>
5 years agoRequire to run at platform scope 33/21633/1
José Bollo [Wed, 15 May 2019 11:09:31 +0000 (13:09 +0200)]
Require to run at platform scope

Add the required permission
urn:AGL:permission::partner:scope-platform
to run at platform scope.

Bug-AGL: SPEC-545
Bug-AGL: SPEC-2006

Change-Id: I8878ecad50bcf2c0f8fd8419e43f1009a22a1d85
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
5 years agoFix: double free issue 06/21206/5 7.99.1 halibut/7.99.1 halibut_7.99.1
Romain Forlot [Fri, 18 Jan 2019 13:42:34 +0000 (14:42 +0100)]
Fix: double free issue

handle is already freed during the active_diagnostic_request destruction.

Bug-AGL: SPEC-2415

Change-Id: Ia26d5c9d2974ca34d411c3182b218141a84c8f21
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoRemoving submodule 07/21207/3
Romain Forlot [Tue, 30 Apr 2019 13:52:16 +0000 (15:52 +0200)]
Removing submodule

Migration wasn't complete, submodule deinit didn't achieve to erase the
submodule or something wasn't pushed, anyway we have to manually remove
the submodule to get rid of it.

And this commit adds the afb-helpers library as a link dependency

Bug-AGL: SPEC-2139

Change-Id: Iedbdb2d75fc75de553254b266c319bd1538d95c3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agodocumentation: fix broken links in documentation 36/21036/1
Clément Bénier [Mon, 15 Apr 2019 12:54:53 +0000 (14:54 +0200)]
documentation: fix broken links in documentation

- use relative links

Change-Id: Ic8d85e6cad82e272d136b2bc4c9a1f965b101fbc
Signed-off-by: Clément Bénier <clement.benier@iot.bzh>
5 years agodocs: Fix broken links 81/20881/1
Pierre MARZIN [Tue, 2 Apr 2019 13:51:57 +0000 (15:51 +0200)]
docs: Fix broken links

Change-Id: Icc71985cab22e015fa4b901a9545bec3e2cb524d
Signed-off-by: Pierre MARZIN <pierre.marzin@iot.bzh>
5 years agobinding: can-low-level: remove useless .gitmodules 27/20727/1
Matt Ranostay [Sat, 16 Mar 2019 00:30:43 +0000 (17:30 -0700)]
binding: can-low-level: remove useless .gitmodules

Bug-AGL: SPEC-2268
Change-Id: I48725d0589f188511873fa91d49cd425e1dd2ceb
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
5 years agoautobuild: fix warnings due to cp command exit error 47/20347/2
Raquel Medina [Tue, 26 Feb 2019 22:37:54 +0000 (00:37 +0200)]
autobuild: fix warnings due to cp command exit error

- bring latest version of autobuild script in
- move conf.d/autobuild to root folder
- update autobuild script to fix warnings triggered by
  cp operation error.

Change-Id: I81b8000f6b11ac2571a8dbb329d45ec417092c99
Bug-AGL: SPEC-2164
Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
5 years agoAdd fake can data for dashboard 47/19947/1
zheng_wenlong [Wed, 6 Feb 2019 08:25:30 +0000 (17:25 +0900)]
Add fake can data for dashboard

Add these fake can data.
We want to modify dashboard, let is show more information.
  accelerator.pedal.position
  steering.wheel.angle
  transmission.gearinfo
  transmission.mode
  turnsignal.status
  lightstatus.brake
  parking.brake.status

Change-Id: Ief9f29684f3463af0d0f98f1dd213b633d1889bb
Signed-off-by: zheng_wenlong <wenlong_zheng@nexty-ele.com>
5 years agodocs: add yaml book 65/19265/1 6.99.3 6.99.4 7.90.0 guppy/6.99.3 guppy/6.99.4 guppy_6.99.3 guppy_6.99.4 halibut/7.90.0 halibut_7.90.0
Frederic Marec [Mon, 17 Dec 2018 15:15:11 +0000 (16:15 +0100)]
docs: add yaml book

Bug-AGL: SPEC-1988

Change-Id: I67cf5f375d8f363e830ba9d04ff62ea7a3939510
Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
5 years agoSmalls improvements 57/18757/3
Romain Forlot [Fri, 7 Dec 2018 16:17:43 +0000 (17:17 +0100)]
Smalls improvements

- Improve robustness reading a BCM socket
  Adding checks on system calls and remove the initialization of the
  struct that will hold the received message, not so much needed in
  that case.
- More accurate log message at subscription/unsubscription step whether
  this is a FD CAN messages or not and if this a subscription or an
  unsubscription that is requested.
- Initialize the full struct of vehicle message to avoid memory warning
  about conditionnal jump based on uninitialized bytes.
- Memleak: Free raw pointer on active diagnostic requests

Change-Id: I4bbf4d851c0fa1efdb6fa6034fac3d1dcafa1a73
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoSimpler handling of binding subscriptions 55/18755/3
Romain Forlot [Mon, 10 Dec 2018 17:08:47 +0000 (18:08 +0100)]
Simpler handling of binding subscriptions

Don't use a child class for subscription, only use one because there
isn't other different subscriptions type to be implemented about now
and if so then we could split again.

Remove functions no longer useful and move afb events and afb
subscriptions part to low-can-subscription

Change-Id: Ie3e4255961ac557465098cdb48730098a950461a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoFilter tests improvements 53/18753/3
Romain Forlot [Thu, 29 Nov 2018 18:00:02 +0000 (19:00 +0100)]
Filter tests improvements

- Unsubscribe using the tear down feature instead of invoking it inside a test
which could not be called if a previous assertion failed.
- Always use the same event so make the 'api' and 'evt' variables at file scope.
- Asserting the bash script's return launcher execution

Change-Id: I6be151d07f890aef053a5ada06216aac7941c165
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoCleaning the code for now unused functions 51/18751/3
Romain Forlot [Fri, 7 Dec 2018 16:36:38 +0000 (17:36 +0100)]
Cleaning the code for now unused functions

Also formating and retabulating some comments

Change-Id: I95eda93e78fabeb336ca02e94307364954ab2318
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoCAN FD implementation 49/18749/3
Romain Forlot [Fri, 28 Sep 2018 15:12:18 +0000 (17:12 +0200)]
CAN FD implementation

Add a flag to CAN message definitions which set the message as using FD
protocol if true.

Use a new generated file with the new FD flag field on the message
definitions.

Change BCM socket "struct" using an union to store the CAN frames either
using the FD struct or the classic non FD struct. A BCM socket can only
one frame type once configured.

Use as much as possible the "struct canfd_frame" in the binding and only
make a difference before writing or reading the socket. From a memory
point of view both struct are identical and only the last member differ
and could hold more data with messages of 64 bytes long. So the
canfd_frame is compatible with the can_frame and can be differentiated
by a flag set in the can_id member.

Remove now unused code processing can_frame.

Keep the diagnostic manager using the classic CAN frame.

Set the maximum number of frames that a BCM socket can handle to 257.

Bug-AGL: SPEC-1980

Change-Id: Ifcc041281ea6745fc25cbd384743761f4446f489
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdds more tests about writing on CAN bus 43/18143/3 6.99.1 6.99.2 guppy/6.99.1 guppy/6.99.2 guppy_6.99.1 guppy_6.99.2
Romain Forlot [Wed, 21 Nov 2018 13:24:40 +0000 (14:24 +0100)]
Adds more tests about writing on CAN bus

This commit adds comprehensive tests about writing messages
on CAN bus.
Increase timeout to use in native test to be able to complete
the test suite.

Bug-AGL: SPEC-1965

Change-Id: Ica555dbac1038bb50e5f76c516c1198a78475a9e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoRework writing CAN message on CAN buses. 09/18109/4
Romain Forlot [Tue, 20 Nov 2018 18:55:23 +0000 (19:55 +0100)]
Rework writing CAN message on CAN buses.

- Adds the possibility to use a custom encoder function
- Use of wrap_json functions instead of raw json-c functions
- Return the error informations in the request return.
- Reduce conditionnal imbrication

Bug-AGL: SPEC-1965

Change-Id: I766b3cf3e6998d03a8a2f3e51117e8b26fc9b56f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUse newly generated cpp file with default encoders 07/18107/3
Romain Forlot [Tue, 20 Nov 2018 18:47:49 +0000 (19:47 +0100)]
Use newly generated cpp file with default encoders

Change-Id: I7bf15568a16e0c84c4f590ca07eba48ecd34157f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoHandle several can_frame in a BCM message 05/18105/3
Romain Forlot [Tue, 20 Nov 2018 18:46:00 +0000 (19:46 +0100)]
Handle several can_frame in a BCM message

Also clean an unused function

Change-Id: I4faabf5a1af53da898ee70f2bc4b528acea3ded3
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdds a new function to build from a json_object. 03/18103/3
Romain Forlot [Tue, 20 Nov 2018 18:40:47 +0000 (19:40 +0100)]
Adds a new function to build from a json_object.

Build an openxc_DynamicField from a json_object.

Change-Id: I57033daca5fd4f198b872f015255893d9f8f9303
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdjust "encoder" signature to fit cpp usage 01/18101/3
Romain Forlot [Tue, 20 Nov 2018 18:38:15 +0000 (19:38 +0100)]
Adjust "encoder" signature to fit cpp usage

Adjust "encoder" signature to fit cpp usage like for the decoder functions.

Change-Id: I5872c5e32fd69356124fefbc82fd1f77ab8acbf4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoCode format and style changes 99/18099/3
Romain Forlot [Tue, 20 Nov 2018 18:35:22 +0000 (19:35 +0100)]
Code format and style changes

Change-Id: Icfb7cdb53deba8d82b91f884c6b815adf0f17adf
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoUpdate gitignore 97/18097/1
Romain Forlot [Tue, 20 Nov 2018 18:55:30 +0000 (19:55 +0100)]
Update gitignore

Change-Id: Iacc55ff5e0b9723897db190db3e5cd73cab8e7b9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
5 years agoAdded afb-helpers submodule 95/18095/1
Romain Forlot [Tue, 20 Nov 2018 16:57:54 +0000 (17:57 +0100)]
Added afb-helpers submodule

Use the afb helpers lib to be able to use wrap_json functions.

Change-Id: I3a66ac4eb7d80ff921de13a7e749311d33f0572e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoChange .gitmodules following submodule migration 71/17771/3
Frederic Marec [Tue, 6 Nov 2018 16:26:09 +0000 (17:26 +0100)]
Change .gitmodules following submodule migration

Remove app-template in .gitmodules
Remove .gitmodules

Change-Id: I41808c8135cfb24baaaaba526781fc149fd918fe
Signed-off-by: Frederic Marec <frederic.marec@iot.bzh>
6 years agoMigrate app-templates to CMake module 21/17621/1
Romain Forlot [Wed, 31 Oct 2018 15:40:59 +0000 (16:40 +0100)]
Migrate app-templates to CMake module

Bug-AGL SPEC-1682

Change-Id: I9f8e4f8bb2c7a020e41215022d2528ea9c26afe1
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoMigration to binding v3 07/17007/6
Romain Forlot [Thu, 11 Oct 2018 10:25:27 +0000 (12:25 +0200)]
Migration to binding v3

Change-Id: I0bcccb15200064bd7d83edbf06c1e7202069189a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUpdated app-templates submodule 09/17009/5
Romain Forlot [Thu, 11 Oct 2018 12:19:42 +0000 (14:19 +0200)]
Updated app-templates submodule

Submodule conf.d/app-templates f0b24b0..0f25ab2:
  > Adding warning message to migrate on CMake module
  > common.cmake: fixed erroneous search path for os-release
  > Fix: missing gcov symbol in compiled binaries
  > app-templates doc: Changed doc to fit new format.
  > Update Docs
  > Fix: typo

Change-Id: Ie81d583faf3b703d773dadc82f2fe88453951c2d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoChange the project name 69/17169/2
Romain Forlot [Thu, 11 Oct 2018 12:18:00 +0000 (14:18 +0200)]
Change the project name

Change the project name to be consistent with other AGL services project.

Change-Id: I2dbd53f59673217c8796bc23c208ed55c1b1716f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUse feature 'required-binding' 45/17045/1
Jose Bollo [Tue, 9 Oct 2018 10:01:16 +0000 (12:01 +0200)]
Use feature 'required-binding'

The feature "urn:AGL:widget:required-binding" is now
preferred to the feature "urn:AGL:widget:required-api"
for requiring a local binding.

Bug-AGL: SPEC-1800

Change-Id: I67508e271b184de362597eeaf20d86bdb17fbd9a
Signed-off-by: Jose Bollo <jose.bollo@iot.bzh>
6 years agoUse the unified script to launch tests 87/16787/1
Romain Forlot [Tue, 25 Sep 2018 12:54:34 +0000 (14:54 +0200)]
Use the unified script to launch tests

This use the dedicated script to launch tests on native
development environment and get rid of the dedicated script
afb-test.sh.

Change-Id: Iaefa95bfd9c842da5ef87bd1adba87d5241a3d8c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agodoc: Changed doc to new format 95/16695/1 6.90.0 guppy/6.90.0 guppy_6.90.0
Sebastien Douheret [Thu, 20 Sep 2018 06:34:53 +0000 (08:34 +0200)]
doc: Changed doc to new format

- split book.json to match new format
- changed description in README.md
- remove useless files

Change-Id: Ie41edb058cf7cfc4920c5c84767097c4e46d34cb
Signed-off-by: Sebastien Douheret <sebastien.douheret@iot.bzh>
6 years agoReach fixture files in all cases. 39/16539/1
Romain Forlot [Wed, 12 Sep 2018 14:01:59 +0000 (16:01 +0200)]
Reach fixture files in all cases.

Depending if you are executing tests on a board or natively
with one or more binders you have to reliably be able to reach
your fixtures files. Using the bindingRootDir you always point to
the right directory and know exactly where are your files.

Change-Id: I61e7cd9d7ff43637dff6e63ffc82a7485cf92443
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoCleaning, set up binding version in config.cmake 23/16323/1 5.99.4 5.99.5 5.99.6 flounder/5.99.4 flounder/5.99.5 flounder/5.99.6 flounder_5.99.4 flounder_5.99.5 flounder_5.99.6
Romain Forlot [Sat, 28 Jul 2018 00:30:14 +0000 (02:30 +0200)]
Cleaning, set up binding version in config.cmake

Change-Id: I2e8d89b09982c9f3770a5a3e10d281e0ad87651c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUse TEST app-templates labels 67/16167/1
Romain Forlot [Tue, 14 Aug 2018 16:33:27 +0000 (18:33 +0200)]
Use TEST app-templates labels

Change-Id: I03b12b6edd04eae51efba509e6d92be3a91702de
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoSpecify the API name to be tested 65/16165/1
Romain Forlot [Tue, 14 Aug 2018 16:56:34 +0000 (18:56 +0200)]
Specify the API name to be tested

Since the API is hardly guessable we need a variable
to be able to build a test widget using CMake template
function that will configure the config.xml file
automatically

Change-Id: Ibbb50c8a84356bbe39427453ccf1ebd0785286e5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUse dedicated API name for the test 63/16163/1
Romain Forlot [Mon, 13 Aug 2018 08:49:36 +0000 (10:49 +0200)]
Use dedicated API name for the test

Use dedicated API name for the test and not using the generic
one already used by the raw afb-test.

Change-Id: I79eb590a9a1d8c2538bd1b9d8bfc5a8537cf6c00
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUpdate gitignore 29/15829/1 5.99.3 flounder/5.99.3 flounder_5.99.3
Romain Forlot [Sat, 28 Jul 2018 00:34:44 +0000 (02:34 +0200)]
Update gitignore

Change-Id: I510914c895cafedba5c407fe6ea9e23414eae076
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoSeveral tests improvements and fixes 25/15825/2
Romain Forlot [Fri, 27 Jul 2018 18:02:56 +0000 (20:02 +0200)]
Several tests improvements and fixes

- New tests about authenticate and write on CAN bus.
- Fixes diagnostic messages handling, all diagnostic messages are received
through the same handle then in its data there is the detailled message
name.
- Set after and before method the same between the both file then they could
be played separately. About now setting multiple times those methods will override
them and the latest set wins
- Disable the Step3 for now because of segfault
- Fix unsubscribe argument to match the previous subscription else
it doesn't match and verb call fails
- Fix: typo,wrong variable

Change-Id: I2f4c2873e57611c946a99d4313021bb7bfea679c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoUpdated examples files and default configuration 23/15823/1
Romain Forlot [Fri, 27 Jul 2018 17:51:52 +0000 (19:51 +0200)]
Updated examples files and default configuration

Let use the new decoder's function and set some hvac signals
as writable to be able to test this feature.

Change-Id: I27e1c2be069b8bb55ed931ad1fb629aa2d4e5b86
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoTiny doc fix 21/15821/1
Romain Forlot [Fri, 27 Jul 2018 17:50:04 +0000 (19:50 +0200)]
Tiny doc fix

Change-Id: Ic3f1c572fccacb1c78e38c6a94aafcd0f9740aff
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoAlign config.cmake file with app-template update 89/15589/3 5.99.2 flounder/5.99.2 flounder_5.99.2
Romain Forlot [Wed, 18 Jul 2018 13:12:20 +0000 (15:12 +0200)]
Align config.cmake file with app-template update

Submodule conf.d/app-templates 92646f6..f94e45e:
  > Align sample on actual default compile options
  > Add support to binding version 3.
  > Warning if not using wgtpkg-pack to make a widget
  > Rework CMAKE_INSTALL_PREFIX and INSTALL_PREFIX var
  > Be able to overwrite BUILD_TYPE using CLI
  > Use CACHE variable for other common CMAKE variable
  > Fix:: wrong wgt using RELEASE BUILD TYPE
  > Fix: SYSROOT location detection... Wrong test.
  > Change the default debug compilation options.
  > Clearer coverage compilation options configuration
  > Don't overwrite the autobuild script if it exists
  > Disable the in-tree build method.
  > Detect Yocto as OS distribution
  > Fix: wrong compile options added

Change-Id: I9d9f607108160e818e8d6345e9c45c02736d7355
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoRemove generated files from git repo 87/15587/3
Romain Forlot [Wed, 18 Jul 2018 12:15:51 +0000 (14:15 +0200)]
Remove generated files from git repo

This files is generated by afb-genskel tools at build time.
Having it in the repo could make some unwanted side effects.

Change-Id: Ib5c6b010fe56245694fe267aca0548575b6e063b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoAdded frequency filter test 23/15623/1
8000ff [Tue, 24 Jul 2018 09:24:20 +0000 (11:24 +0200)]
Added frequency filter test

Change-Id: I9b80a713f5696e36e4acbe815dc3422281b6e0d3
Signed-off-by: 8000ff <clementmallejac@gmail.com>
6 years agoImproved testing procedures 23/15523/1
8000ff [Fri, 20 Jul 2018 08:47:28 +0000 (10:47 +0200)]
Improved testing procedures

 - Deleted deprecated low-can-tests.lua

 - Renamed low-can-coverage.lua as it does not describe its purpose

 - Added 2 new canreplay files

 - Added new test file for testing subscription filters

 - Edited the test configuration to play the new test file

Change-Id: I11315581a5fac7428ed17d3ef299a9f0e96ce7f4
Signed-off-by: 8000ff <clementmallejac@gmail.com>
6 years agocan-low-level: add missing hidden attribute to config.xml.in 17/15317/1
Matt Ranostay [Wed, 11 Jul 2018 19:09:59 +0000 (12:09 -0700)]
can-low-level: add missing hidden attribute to config.xml.in

Change-Id: I270b26f79548a784840a7466bd77a6df46741530
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
6 years agoAdd tests 15/14815/5 sandbox/excale/wip
Romain Forlot [Tue, 19 Jun 2018 16:40:32 +0000 (18:40 +0200)]
Add tests

Create first tests to be used with afb-test binding
The test binding is now found using pkg-config command.

Change-Id: Ib1cd08236b6b8fab93ccb67ac613a9c83908d12e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoMake Built type overwritten by cli possible. 83/15083/2
Romain Forlot [Fri, 6 Jul 2018 14:08:48 +0000 (16:08 +0200)]
Make Built type overwritten by cli possible.

Settings a CMAKE CACHE variable make the first definition
to be not overwritten by a next assignement. Then a cli
variable is then possible more without force.

Change-Id: Iaad2ffa9d51cd2c77c51e94533979d3ee3f9dd32
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoFix: correctly stop the binding. 79/15079/3
Romain Forlot [Fri, 6 Jul 2018 12:38:02 +0000 (14:38 +0200)]
Fix: correctly stop the binding.

Automatically destroying C++ objects wasn't sufficient since
it uses thread with locks that were waiting forever if there is
no CAN bus activity. Now correctly wake-up the threads to ends
them even if there without activity on the CAN bus.

Change-Id: I69d74a34a8dbea4df7c8090aa47abf1c43133020
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoAdd CAN sample for the agl-vcar configuration 13/14813/1
Romain Forlot [Wed, 20 Jun 2018 13:24:29 +0000 (15:24 +0200)]
Add CAN sample for the agl-vcar configuration

Change-Id: Ib6a479f30e271ef26955ad3359eda87469f1277a
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoMerge "Fixing typos made in comments" 5.99.1 flounder/5.99.1 flounder_5.99.1
Jan-Simon Moeller [Fri, 25 May 2018 18:53:52 +0000 (18:53 +0000)]
Merge "Fixing typos made in comments"

6 years agoFixing typos made in comments 45/13945/6
ydimitrov [Fri, 18 May 2018 20:12:14 +0000 (21:12 +0100)]
Fixing typos made in comments

This change set fixes the comments made by previous contributors

v2: Fix line end

v3: Making changes to comments as suggested by reviewers

v4: Removing trailing spaces

v5: Clearing small typo in low-can-cb.cpp on line 142

Change-Id: Ifbcfc3b2d131d1db0b25e472955b21e98cc09f45
Signed-off-by: ydimitrov <y.dimitrov.14@gmail.com>
6 years agoFix compilation warning
Romain Forlot [Wed, 16 May 2018 21:33:45 +0000 (23:33 +0200)]
Fix compilation warning

Change-Id: I3ea7b3aa91d4251f90a4ccf5da83ae8de7a58db4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoFix gitreview file after repo move 49/13949/1
ydimitrov [Mon, 14 May 2018 12:43:51 +0000 (13:43 +0100)]
Fix gitreview file after repo move

After the git repo moved we need to adapt the .gitreview file.

Change-Id: I316cf29f01ce5c39be024297279e9161936b03f4
Signed-off-by: ydimitrov <y.dimitrov.14@gmail.com>
6 years agoDetect engine state and use it during diagnostic messages subscriptions 43/13743/2
Jonathan Aillet [Mon, 9 Apr 2018 07:50:15 +0000 (09:50 +0200)]
Detect engine state and use it during diagnostic messages subscriptions

Get engine state recurringly by requesting a permanent
diagnostic messages request.
Use these information to warn that diagnostic request won't have any responses
at the moment of subscription if engine is off.

Bug-AGL: SPEC-1347

Change-Id: If8bd79bba89acd1c8f5452d3efdbf00a89f8cc77
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoAdd possibility to subscribe to a recurring request permanently 41/13741/2
Jonathan Aillet [Mon, 9 Apr 2018 07:25:47 +0000 (09:25 +0200)]
Add possibility to subscribe to a recurring request permanently

Add possibility to subscribe to a recurring request that won't be deleted
when no subscriber is detected.
For now, this functionnality is implemented for internal use only.

Bug-AGL: SPEC-1347

Change-Id: I48f6f647677596ba7920c4348d5406ea7bf1081b
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoAdd saving of diagnostic messages information 39/13739/2
Jonathan Aillet [Mon, 9 Apr 2018 07:02:52 +0000 (09:02 +0200)]
Add saving of diagnostic messages information

Add saving of diagnostic messages receive state, last value,
and timestamp associated to it.
Add methods to get/set these information.
Add initialisation for added atributes.
Add boolean to set receive state at initialisation.
Generate all 'diagnostic-message.cpp' containing diagnostic messages
to add receive state initialisation.

Bug-AGL: SPEC-1347

Change-Id: Iee82ca3b5f79fd267717ae074d5456b8cbc1c377
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoCorrect errors in comments
Jonathan Aillet [Thu, 29 Mar 2018 07:18:58 +0000 (09:18 +0200)]
Correct errors in comments

Change-Id: I1e02bdfe2473e776e35694b883f084077227853c
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoFix name to fit rename of git repository.
Romain Forlot [Fri, 23 Mar 2018 16:02:04 +0000 (17:02 +0100)]
Fix name to fit rename of git repository.

Bug-AGL: SPEC-1276

Change-Id: I279620c1be00db03f06f6dd882b3b579c80480c4
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoChange subscribed signals search to check filters as well
Jonathan Aillet [Fri, 2 Mar 2018 10:51:42 +0000 (11:51 +0100)]
Change subscribed signals search to check filters as well

When a new subscription is made, search in existing subscription for a
combination of a signal and a filter instead of searching for just a signal.
In this way, each subscription will receive signals according to
their requesting filter.

Bug-AGL: SPEC-1339

Change-Id: I22cb96a2dbaaf48dbd77025ff1610bde151b19b4
Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoDelete obsolete references.
Jonathan Aillet [Thu, 1 Mar 2018 15:05:15 +0000 (16:05 +0100)]
Delete obsolete references.

Delete obsolote references such as use of acceptance filters,
timers, etc.

Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoCorrection of 'typo' in documentation.
Jonathan Aillet [Mon, 5 Mar 2018 16:58:42 +0000 (17:58 +0100)]
Correction of 'typo' in documentation.

Signed-off-by: Jonathan Aillet <jonathan.aillet@iot.bzh>
6 years agoRun by default with system low-can service
Romain Forlot [Tue, 2 Jan 2018 11:59:28 +0000 (12:59 +0100)]
Run by default with system low-can service

Change-Id: I0f72898d764e2c3e50998e62cfa2a16ead02b74b
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoMake low-can use afb-genskel by default
Romain Forlot [Tue, 2 Jan 2018 11:58:48 +0000 (12:58 +0100)]
Make low-can use afb-genskel by default

Cleaning header file inclusion

Change-Id: Ic0dd9637ecd491692bd4b8b39e9602e85498c0a9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agodocs: bump version to 5.0-EE
Stephane Desneux [Fri, 22 Dec 2017 01:07:29 +0000 (02:07 +0100)]
docs: bump version to 5.0-EE

Change-Id: I69d573124b86429bb9b0f548542262e0538fd5f0
Signed-off-by: Stephane Desneux <stephane.desneux@iot.bzh>
6 years agoCode enhancements mem leaks and uninitialized byte
Romain Forlot [Thu, 21 Dec 2017 12:45:58 +0000 (13:45 +0100)]
Code enhancements mem leaks and uninitialized byte

Change-Id: I40632b6212118278f5877957a480122e9383e3bc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoInitialize struct to avoid unexpected behavior
Romain Forlot [Thu, 7 Dec 2017 11:41:03 +0000 (12:41 +0100)]
Initialize struct to avoid unexpected behavior

Change-Id: I8c160b427f0844e9bc6c7e65fb48cd122160bc65
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoFix wrong config.xml file used to build widget
Romain Forlot [Tue, 5 Dec 2017 09:07:16 +0000 (10:07 +0100)]
Fix wrong config.xml file used to build widget

Bug-AGL: SPEC-966

Change-Id: I39d226c6f6268ec880739e6b9230eb42ce475971
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoFails write request if CAN signal not writable
Romain Forlot [Thu, 30 Nov 2017 10:49:15 +0000 (11:49 +0100)]
Fails write request if CAN signal not writable

Change-Id: I8d75a232ba7fad9cc95f286e521c2451a3a29061
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoFix permission label
Romain Forlot [Thu, 30 Nov 2017 08:43:58 +0000 (09:43 +0100)]
Fix permission label

Change-Id: I1c7299bdf9ff024f676b88860c8d31076f6806e0
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoCorrectly reconstituting entire CAN frame
Romain Forlot [Thu, 30 Nov 2017 08:43:46 +0000 (09:43 +0100)]
Correctly reconstituting entire CAN frame

Change-Id: I39d226c6f6268ec880739e6b9230eb42ce475971
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
6 years agoDeprecate cmake variables not useful
Romain Forlot [Wed, 29 Nov 2017 09:02:32 +0000 (10:02 +0100)]
Deprecate cmake variables not useful

Mechanism to build 3rdparty external libs isn't unique
and should not be handled by app-templates

Change-Id: Ib8a030184820da6577fa37f74331aaf7d6155916
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFixed error after hard c/c ...
Romain Forlot [Fri, 17 Nov 2017 15:36:45 +0000 (16:36 +0100)]
Fixed error after hard c/c ...

Change-Id: I9dda0f1029735cab178f911d94a28b30a5c26123
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoWrong manipulation create those files. Deleting
Romain Forlot [Fri, 17 Nov 2017 14:11:14 +0000 (15:11 +0100)]
Wrong manipulation create those files. Deleting

Change-Id: I2fc9ae613f243d94bcb72aefe24e777a9b1d0b98
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoCleaning
Romain Forlot [Fri, 17 Nov 2017 09:17:33 +0000 (10:17 +0100)]
Cleaning

Change-Id: I61d47837feab0ead59be1b1c4c5e163c4a604df9
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoHandle space in project path
Romain Forlot [Fri, 17 Nov 2017 10:07:55 +0000 (11:07 +0100)]
Handle space in project path

Change-Id: I9c39a4fec5469216df31eb14f535cfda3907cdc1
Bug-AGL: SPEC-1117
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix: wgt config file usage to build widget
Romain Forlot [Tue, 14 Nov 2017 15:44:28 +0000 (16:44 +0100)]
Fix: wgt config file usage to build widget

Change-Id: Ia160a42163d47f2b92f246cf1159da9fa2110527
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoSend entire CAN message rather than CAN signal.
Romain Forlot [Wed, 8 Nov 2017 08:55:23 +0000 (09:55 +0100)]
Send entire CAN message rather than CAN signal.

Old behavior send only the CAN signal, now we retrieve
the CAN message value instead and send the CAN message with
all CAN signals composing the message.

Change-Id: I2394cc30630601e46aa939ddda88e8616372179e
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoUpdate app-templates and autobuild script
Romain Forlot [Wed, 8 Nov 2017 08:10:57 +0000 (09:10 +0100)]
Update app-templates and autobuild script

Change-Id: I9ab84291aa785b87091cec4f775fb7e4cd31809c
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoFix wrong filter condition (Thanks Parai Wang)
Romain Forlot [Wed, 8 Nov 2017 08:09:46 +0000 (09:09 +0100)]
Fix wrong filter condition (Thanks Parai Wang)

Change-Id: I7d3eccc2d4b99d543b669c7b3c8d7a38670d860f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoMake write permission use the same name everywhere
Romain Forlot [Thu, 19 Oct 2017 10:17:17 +0000 (12:17 +0200)]
Make write permission use the same name everywhere

Confusion made with permission generated and legacy one
which weren't the same.
Removing unused source file

Change-Id: I74f70b45358c052049ff84b872c0381915e27344
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
7 years agoDetails usage of write verb in docs.
Romain Forlot [Thu, 19 Oct 2017 09:17:02 +0000 (11:17 +0200)]
Details usage of write verb in docs.

Formating

Change-Id: I17dd96a8fa64f09272f5c30ef77c6b41a21dea7d
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>