From: Romain Forlot <romain.forlot@iot.bzh>
Date: Wed, 4 Dec 2019 15:19:28 +0000 (+0100)
Subject: message: optimize getting subpart of a vector
X-Git-Tag: 8.99.5~37
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=refs%2Fchanges%2F59%2F23259%2F6;p=apps%2Fagl-service-can-low-level.git

message: optimize getting subpart of a vector

Change-Id: Ifdaea3bf0969f15eb70629a92c0293ddeee33491
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
---

diff --git a/low-can-binding/can/message/message.cpp b/low-can-binding/can/message/message.cpp
index 191e1f23..22887c9a 100644
--- a/low-can-binding/can/message/message.cpp
+++ b/low-can-binding/can/message/message.cpp
@@ -85,28 +85,16 @@ const uint8_t* message_t::get_data() const
 ///
 const std::vector<uint8_t> message_t::get_data_vector(int start, int end) const
 {
-	std::vector<uint8_t> ret;
-	if(start >= 0)
-	{
-		if(end<length_)
-		{
-			for(int i=start;i<=end;i++)
-			{
-				ret.push_back(data_[i]);
-			}
-		}
-		else
-		{
-			for(int i=start;i<length_;i++)
-			{
-				ret.push_back(data_[i]);
-			}
-		}
-	}
-	else
+	if ( start > length_ || end > length_ )
 	{
 		AFB_ERROR("Error index to get data vector, [%d-%d] - for length %d", start, end, length_);
+		return data_;
 	}
+
+	std::vector<uint8_t>::const_iterator first = data_.begin() + start;
+	std::vector<uint8_t>::const_iterator last = data_.begin() + end;
+	std::vector<uint8_t> ret(first, last);
+
 	return ret;
 }