From: Marius Vlad <marius.vlad@collabora.com>
Date: Thu, 6 Apr 2023 07:59:37 +0000 (+0300)
Subject: compositor: Don't reuse previous return values
X-Git-Tag: 17.90.0~34
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=f825bf9e71ac5adfcbdc6ef7f6c2fef8555ee4a3;hp=2e91c40bde5253a30716092af31e4cf07febda44;p=src%2Fagl-compositor.git

compositor: Don't reuse previous return values

In case we couldn't enable the output do not return early without
setting the proper return value. This causes an issue later one, because
the signal list isn't initalized, taking down the compositor with a crash.

Bug-AGL: SPEC-4734
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
Change-Id: Ia5ebc226f6b8f702e710a5976c471d04302bcb00
---

diff --git a/src/compositor.c b/src/compositor.c
index 5ef3b34..250c90c 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -838,7 +838,7 @@ remote_output_init(struct ivi_output *ivi_output,
 		goto err;
 	}
 
-	if (weston_output_enable(ivi_output->output) < 0) {
+	if ((ret = weston_output_enable(ivi_output->output)) < 0) {
 		weston_log("Enabling remoted output \"%s\" failed.\n",
 				output_name);
 		goto err;