From: Romain Forlot <romain.forlot@iot.bzh>
Date: Fri, 19 May 2017 12:09:40 +0000 (+0200)
Subject: Using reference make std::move useless.
X-Git-Tag: 3.99.1~16
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=bd5201c8abf77de3aae3183069de558c8dd4c40f;p=apps%2Flow-level-can-service.git

Using reference make std::move useless.

Change-Id: I9b9b6a2fbaecae8acc4f8f1eef0ea8d2f084fb9f
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
---

diff --git a/CAN-binder/low-can-binding/can/can-message-definition.cpp b/CAN-binder/low-can-binding/can/can-message-definition.cpp
index a9ee20c..ec6292a 100644
--- a/CAN-binder/low-can-binding/can/can-message-definition.cpp
+++ b/CAN-binder/low-can-binding/can/can-message-definition.cpp
@@ -63,7 +63,7 @@ can_message_definition_t::can_message_definition_t(
 	frequency_clock_{frequency_clock},
 	force_send_changed_{force_send_changed},
 	last_value_{CAN_MESSAGE_SIZE},
-	can_signals_{std::move(can_signals)}
+	can_signals_{can_signals}
 {}
 
 const std::string can_message_definition_t::get_bus_name() const
diff --git a/CAN-binder/low-can-binding/can/can-message-set.cpp b/CAN-binder/low-can-binding/can/can-message-set.cpp
index dcb859d..5b3a220 100644
--- a/CAN-binder/low-can-binding/can/can-message-set.cpp
+++ b/CAN-binder/low-can-binding/can/can-message-set.cpp
@@ -27,8 +27,8 @@ can_message_set_t::can_message_set_t(
 		const std::vector<std::shared_ptr<diagnostic_message_t> >& diagnostic_messages)
 	: index_{index}
 	, name_{name}
-	, can_messages_definition_{std::move(can_messages_definition)}
-	, diagnostic_messages_{std::move(diagnostic_messages)}
+	, can_messages_definition_{can_messages_definition}
+	, diagnostic_messages_{diagnostic_messages}
 {}
 
 /// @brief Return vector holding all message definition handled by this message set.