From: Romain Forlot <romain.forlot@iot.bzh>
Date: Wed, 17 May 2017 23:03:01 +0000 (+0200)
Subject: Improve objects construction.
X-Git-Tag: 5.0.2~202
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=8c316219e6b02885f316ca996b98d85322519bc8;p=apps%2Fagl-service-can-low-level.git

Improve objects construction.

Use of a ref to initialize bus_ string member. const value doesn't make
sense.

Change-Id: I96f504ee11a754b3130289d27afa02a6fa811014
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
---

diff --git a/CAN-binder/low-can-binding/can/can-message-definition.cpp b/CAN-binder/low-can-binding/can/can-message-definition.cpp
index 04f94244..19f06fb1 100644
--- a/CAN-binder/low-can-binding/can/can-message-definition.cpp
+++ b/CAN-binder/low-can-binding/can/can-message-definition.cpp
@@ -17,12 +17,12 @@
 
 #include "can-message-definition.hpp"
 
-can_message_definition_t::can_message_definition_t(const std::string bus)
+can_message_definition_t::can_message_definition_t(const std::string& bus)
 	: parent_{nullptr}, bus_{bus}, last_value_{CAN_MESSAGE_SIZE}
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string bus,
+	const std::string& bus,
 	uint32_t id,
 	frequency_clock_t frequency_clock,
 	bool force_send_changed)
@@ -35,7 +35,7 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string bus,
+	const std::string& bus,
 	uint32_t id,
 	can_message_format_t format,
 	frequency_clock_t frequency_clock,
@@ -50,7 +50,7 @@ can_message_definition_t::can_message_definition_t(
 {}
 
 can_message_definition_t::can_message_definition_t(
-	const std::string bus,
+	const std::string& bus,
 	uint32_t id,
 	can_message_format_t format,
 	frequency_clock_t frequency_clock,
@@ -82,7 +82,7 @@ can_message_definition_t::can_message_definition_t(
 	can_signals_{b.can_signals_}
 	{}*/
 
-const std::string& can_message_definition_t::get_bus_name() const
+const std::string can_message_definition_t::get_bus_name() const
 {
 	return bus_;
 }
diff --git a/CAN-binder/low-can-binding/can/can-message-definition.hpp b/CAN-binder/low-can-binding/can/can-message-definition.hpp
index 5d8514fa..a9acd4a7 100644
--- a/CAN-binder/low-can-binding/can/can-message-definition.hpp
+++ b/CAN-binder/low-can-binding/can/can-message-definition.hpp
@@ -54,12 +54,12 @@ private:
 
 public:
 	//can_message_definition_t(const can_message_definition_t& b);
-	can_message_definition_t(const std::string bus);
-	can_message_definition_t(const std::string bus, uint32_t id, frequency_clock_t frequency_clock, bool force_send_changed);
-	can_message_definition_t(const std::string bus, uint32_t id, can_message_format_t format, frequency_clock_t frequency_clock, bool force_send_changed);
-	can_message_definition_t(const std::string bus, uint32_t id, can_message_format_t format, frequency_clock_t frequency_clock, bool force_send_changed, std::vector<std::shared_ptr<can_signal_t> > can_signals);
+	can_message_definition_t(const std::string& bus);
+	can_message_definition_t(const std::string& bus, uint32_t id, frequency_clock_t frequency_clock, bool force_send_changed);
+	can_message_definition_t(const std::string& bus, uint32_t id, can_message_format_t format, frequency_clock_t frequency_clock, bool force_send_changed);
+	can_message_definition_t(const std::string& bus, uint32_t id, can_message_format_t format, frequency_clock_t frequency_clock, bool force_send_changed, std::vector<std::shared_ptr<can_signal_t> > can_signals);
 
-	const std::string& get_bus_name() const;
+	const std::string get_bus_name() const;
 	uint32_t get_id() const;
 	std::vector<std::shared_ptr<can_signal_t> >& get_can_signals();