From: Petteri Aimonen <jpa@git.mail.kapsi.fi>
Date: Sat, 30 Jun 2012 15:23:18 +0000 (+0300)
Subject: Warn if PB_MAX_REQUIRED_FIELDS is not large enough.
X-Git-Tag: 3.99.1~14^2~488
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=67add3259a6429cb4afc1bdb6345e8c057a55ca8;p=apps%2Flow-level-can-service.git

Warn if PB_MAX_REQUIRED_FIELDS is not large enough.
---

diff --git a/generator/nanopb_generator.py b/generator/nanopb_generator.py
index 1e7e1f9..730c0aa 100644
--- a/generator/nanopb_generator.py
+++ b/generator/nanopb_generator.py
@@ -402,6 +402,16 @@ def generate_header(dependencies, headername, enums, messages):
     for msg in messages:
         yield msg.fields_declaration() + '\n'
     
+    count_required_fields = lambda m: len([f for f in msg.fields if f.htype == 'PB_HTYPE_REQUIRED'])
+    largest_msg = max(messages, key = count_required_fields)
+    largest_count = count_required_fields(largest_msg)
+    if largest_count > 64:
+        yield '\n/* Check that missing required fields will be properly detected */\n'
+        yield '#if PB_MAX_REQUIRED_FIELDS < %d\n' % largest_count
+        yield '#warning Properly detecting missing required fields in %s requires \\\n' % largest_msg.name
+        yield '         setting PB_MAX_REQUIRED_FIELDS to %d or more.\n' % largest_count
+        yield '#endif\n'
+    
     yield '\n#endif\n'
 
 def generate_source(headername, enums, messages):