From: Manuel Bachmann <manuel.bachmann@iot.bzh>
Date: Tue, 23 Feb 2016 12:15:24 +0000 (+0100)
Subject: Fix horrendously wrong Volume check in Audio plugin
X-Git-Tag: blowfish_2.0.1~277
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=623aa9c2f8296adcd3b2aed2c6811927fde3645d;p=src%2Fapp-framework-binder.git

Fix horrendously wrong Volume check in Audio plugin

Volume bound check was always false.

Signed-off-by: Manuel Bachmann <manuel.bachmann@iot.bzh>
---

diff --git a/plugins/audio/audio-api.c b/plugins/audio/audio-api.c
index 637f9d03..9c9da251 100644
--- a/plugins/audio/audio-api.c
+++ b/plugins/audio/audio-api.c
@@ -190,7 +190,7 @@ STATIC json_object* volume (AFB_request *request) {      /* AFB_SESSION_CHECK */
         volume_i = strtok (volume_i, ",");
         volume[0] = atoi (volume_i);
 
-        if (100 < volume[0] < 0) {
+        if ((100 < volume[0])||(volume[0] < 0)) {
             free (volume_i);
             request->errcode = MHD_HTTP_SERVICE_UNAVAILABLE;
             return (jsonNewMessage (AFB_FAIL, "Volume must be between 0 and 100"));