From: José Bollo <jose.bollo@iot.bzh>
Date: Thu, 13 Jun 2019 14:12:22 +0000 (+0200)
Subject: QAfbWebsocketClient: Allows null callback (FIX)
X-Git-Tag: 7.99.2^0
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=547374849a76225b1a6a0dd8bb84ae27a601f19d;p=src%2Flibafb-helpers.git

QAfbWebsocketClient: Allows null callback (FIX)

Don't passing a callback is a valid model.
But the library should not crash in that case.
This fix the uissue.

Bug-AGL: SPEC-2520

Change-Id: I6e6f3e6b617cfcf251ac910db5fa27832c2713a1
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---

diff --git a/qafbwebsocketclient.cpp b/qafbwebsocketclient.cpp
index 0cbc274..c0e5e71 100644
--- a/qafbwebsocketclient.cpp
+++ b/qafbwebsocketclient.cpp
@@ -85,8 +85,9 @@ void QAfbWebsocketClient::close()
  */
 void QAfbWebsocketClient::call(const QString& api, const QString& verb, const QJsonValue& arg, closure_t closure)
 {
-    QString callId = QString::number(m_nextCallId);
-    m_closures[callId] = closure;
+    QString callId = QString::number(m_nextCallId++);
+    if (closure)
+        m_closures[callId] = closure;
 
     QJsonArray msg;
     msg.append(2); // Call
@@ -94,8 +95,6 @@ void QAfbWebsocketClient::call(const QString& api, const QString& verb, const QJ
     msg.append(api + "/" + verb);
     msg.append(arg);
 
-    m_nextCallId++;
-
     QJsonDocument value;
     value.setArray(msg);