From: Scott Murray <scott.murray@konsulko.com>
Date: Tue, 3 Dec 2019 22:17:07 +0000 (-0500)
Subject: Fix filter bitmask generation
X-Git-Tag: 8.99.2~1
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=4780c23547407f6bafb7e14fb70aaeeca0a1257d;hp=6af1b5e243df2333a9ecdedf9c9ba23a3619de58;p=apps%2Fagl-service-can-low-level.git

Fix filter bitmask generation

Fix filter bitmask generation in encoder_t::encode_data; the mask
bits need to be left-aligned in each byte, not right-aligned.

Bug-AGL: SPEC-3013

Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Change-Id: Ie084f81e3d8c06e69b5bb7562055187395099ac7
---

diff --git a/low-can-binding/can/can-encoder.cpp b/low-can-binding/can/can-encoder.cpp
index 37a7b246..2d836cf9 100644
--- a/low-can-binding/can/can-encoder.cpp
+++ b/low-can-binding/can/can-encoder.cpp
@@ -93,7 +93,7 @@ void encoder_t::encode_data(std::shared_ptr<signal_t> sig, std::vector<uint8_t>
 		int j=0;
 		for(int i=0;i<new_bit_size;i++)
 		{
-			int mask = 1 << ((i%8)+new_start_bit);
+			int mask = 0x80 >> ((i%8)+new_start_bit);
 
 			uint8_t mask_v = 0;
 			if(mask > 255)