From: Naoko Tanibata <tnaoko@jp.adit-jv.com>
Date: Fri, 8 Feb 2019 13:31:11 +0000 (+0900)
Subject: transmitter: Correct error handling
X-Git-Tag: 7.99.1~2
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=3f28f47c6d21a708d5ca1d8041a143fce23a574b;p=src%2Fweston-ivi-plugins.git

transmitter: Correct error handling

When drm_get_dma_fd_from_view() fails, it returns negative value.
Therefore output->renderer->dmafd shall be compared with a negative in error handling.

Bug-AGL: SPEC-2057

Change-Id: I5457e7db8ff8673cdf32a65ff2c17721bfc8d7f0
Signed-off-by: Naoko Tanibata <tnaoko@jp.adit-jv.com>
---

diff --git a/waltham-transmitter/transmitter-plugin/output.c b/waltham-transmitter/transmitter-plugin/output.c
index f5b1c21..ef6e972 100644
--- a/waltham-transmitter/transmitter-plugin/output.c
+++ b/waltham-transmitter/transmitter-plugin/output.c
@@ -193,7 +193,7 @@ transmitter_output_repaint(struct weston_output *base,
 
 					output->renderer->dmafd =
 						api->get_dma_fd_from_view(&output->base, view);
-					if(!output->renderer->dmafd) {
+					if(output->renderer->dmafd < 0) {
 						weston_log("Failed to get dmafd\n");
 						goto out;
 					}