From: José Bollo <jose.bollo@iot.bzh>
Date: Wed, 28 Jun 2017 16:08:29 +0000 (+0200)
Subject: Fix bad error reporting
X-Git-Tag: eel/4.99.1~116
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=305d98f7b6db1a3207cc877bd2cda819e3b90656;p=src%2Fapp-framework-binder.git

Fix bad error reporting

The use of %m was buggy due to the implementation
of 'vverbose': it always returned ENOTTY

   Inappropriate ioctl for device

Change-Id: Idedeefa44ec3cf301d75cd542c54c35a208886a1
Signed-off-by: José Bollo <jose.bollo@iot.bzh>
---

diff --git a/src/verbose.c b/src/verbose.c
index 5b2611a7..2b009073 100644
--- a/src/verbose.c
+++ b/src/verbose.c
@@ -77,6 +77,7 @@ void verbose_set_name(const char *name, int authority)
 #else
 
 #include <unistd.h>
+#include <errno.h>
 
 static const char *appname;
 
@@ -95,7 +96,9 @@ static const char *prefixes[] = {
 
 void vverbose(int level, const char *file, int line, const char *function, const char *fmt, va_list args)
 {
+	int saverr = errno;
 	int tty = isatty(fileno(stderr));
+	errno = saverr;
 
 	fprintf(stderr, "%s: ", prefixes[LEVEL(level)] + (tty ? 4 : 0));
 	vfprintf(stderr, fmt, args);