From: Christopher Peplin <chris.peplin@rhubarbtech.com>
Date: Sun, 5 Jan 2014 23:56:37 +0000 (-0500)
Subject: Add a TODO about flipping byte order.
X-Git-Tag: 5.0.2~273^2~49
X-Git-Url: https://gerrit.automotivelinux.org/gerrit/gitweb?a=commitdiff_plain;h=2ea50110062053ef12b1c66956ec25faf7f1cb3c;p=apps%2Fagl-service-can-low-level.git

Add a TODO about flipping byte order.
---

diff --git a/src/obd2/obd2.c b/src/obd2/obd2.c
index f8b4a372..402cc2f9 100644
--- a/src/obd2/obd2.c
+++ b/src/obd2/obd2.c
@@ -37,7 +37,8 @@ DiagnosticRequestHandle diagnostic_request(DiagnosticShims* shims,
     uint8_t payload[MAX_DIAGNOSTIC_PAYLOAD_SIZE];
     payload[MODE_BYTE_INDEX] = request->mode;
     if(request->pid_length > 0) {
-        // TODO may need to flip the byte order
+        // TODO need a set bit field that's more natural and checks endianness
+        // becauase we DO need to flip it
         copy_bytes_right_aligned((uint8_t*)&request->pid, sizeof(request->pid),
                 PID_BYTE_INDEX, request->pid_length, payload, sizeof(payload));
     }