vss-agl: Fix engine speed datatype in overlays

The Vehicle.Powertrain.CombustionEngine.Speed signal datatype was
accidentally being overwritten as a float in our VSS overlays for
configuring the CAN provider.  I believe this was an artifact of
some cutting in pasting when the signal was added and upstream
recommended switching away from using OBD signals as the plan is
to deprecate those.  There are some downstream changes required in
the homescreen and dashboard applications to handle this being
fixed.

Bug-AGL: SPEC-5204

Change-Id: I3582dbbef6cf915f30a50804174753da12b905ae
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Reviewed-on: https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl-demo/+/30173
Tested-by: Jenkins Job builder account
ci-image-boot-test: Jenkins Job builder account
Reviewed-by: Naoto YAMAGUCHI <naoto.yamaguchi@aisin.co.jp>
ci-image-build: Jenkins Job builder account

diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
index b8a01e3..a08d94a 100644 (file)
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec
@@ -10,13 +10,11 @@ Vehicle.Speed:
     signal: PT_VehicleAvgSpeed
 
 Vehicle.Powertrain.CombustionEngine.Speed:
-  datatype: float
+  datatype: uint16
   type: sensor
   dbc2vss:
     signal: PT_EngineSpeed
     interval_ms: 100
-    transform:
-      math: "floor(x+0.5)"
   vss2dbc:
     signal: PT_EngineSpeed
 

diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
index b5e2b8a..fb85dda 100644 (file)
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.control-panel
@@ -7,7 +7,7 @@ Vehicle.Speed:
     signal: PT_VehicleAvgSpeed
 
 Vehicle.Powertrain.CombustionEngine.Speed:
-  datatype: float
+  datatype: uint16
   type: sensor
   vss2dbc:
     signal: PT_EngineSpeed

diff --git a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
index 6b0a9a3..060eb50 100644 (file)
--- a/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
+++ b/recipes-connectivity/vss/vss-agl/agl_vss_overlay.vspec.gw-control-panel
@@ -8,13 +8,11 @@ Vehicle.Speed:
     interval_ms: 100
 
 Vehicle.Powertrain.CombustionEngine.Speed:
-  datatype: float
+  datatype: uint16
   type: sensor
   dbc2vss:
     signal: PT_EngineSpeed
     interval_ms: 100
-    transform:
-      math: "floor(x+0.5)"
 
 # DBC mappings for other signals for V2C demo