transmitter: Correct error handling 03/20003/3
authorNaoko Tanibata <tnaoko@jp.adit-jv.com>
Fri, 8 Feb 2019 13:31:11 +0000 (22:31 +0900)
committerNaoko Tanibata <tnaoko@jp.adit-jv.com>
Fri, 15 Feb 2019 09:26:55 +0000 (18:26 +0900)
When drm_get_dma_fd_from_view() fails, it returns negative value.
Therefore output->renderer->dmafd shall be compared with a negative in error handling.

Bug-AGL: SPEC-2057

Change-Id: I5457e7db8ff8673cdf32a65ff2c17721bfc8d7f0
Signed-off-by: Naoko Tanibata <tnaoko@jp.adit-jv.com>
waltham-transmitter/transmitter-plugin/output.c

index f5b1c21..ef6e972 100644 (file)
@@ -193,7 +193,7 @@ transmitter_output_repaint(struct weston_output *base,
 
                                        output->renderer->dmafd =
                                                api->get_dma_fd_from_view(&output->base, view);
-                                       if(!output->renderer->dmafd) {
+                                       if(output->renderer->dmafd < 0) {
                                                weston_log("Failed to get dmafd\n");
                                                goto out;
                                        }