Add regression test for issue #227
authorPetteri Aimonen <jpa@git.mail.kapsi.fi>
Fri, 9 Dec 2016 16:50:20 +0000 (18:50 +0200)
committerPetteri Aimonen <jpa@git.mail.kapsi.fi>
Fri, 9 Dec 2016 16:50:20 +0000 (18:50 +0200)
tests/SConstruct
tests/regression/issue_227/SConscript [new file with mode: 0644]
tests/regression/issue_227/unaligned_uint64.c [new file with mode: 0644]
tests/regression/issue_227/unaligned_uint64.proto [new file with mode: 0644]

index d8ab9ab..f2abe04 100644 (file)
@@ -93,7 +93,9 @@ if not env.GetOption('clean'):
             conf.env.Append(CORECFLAGS = extra)
     
     # Check if we can use undefined behaviour sanitizer (only with clang)
-    extra = '-fsanitize=undefined '
+    # TODO: Fuzz test triggers the bool sanitizer, figure out whether to
+    #       modify the fuzz test or to keep ignoring the check.
+    extra = '-fsanitize=undefined -fno-sanitize-recover=undefined -fsanitize-recover=bool '
     if 'clang' in env['CC']:
         if conf.CheckCCFLAGS(extra, linkflags = extra):
             conf.env.Append(CORECFLAGS = extra)
diff --git a/tests/regression/issue_227/SConscript b/tests/regression/issue_227/SConscript
new file mode 100644 (file)
index 0000000..1074124
--- /dev/null
@@ -0,0 +1,14 @@
+# Regression test for Issue 227:Using proto3 type fields can cause unaligned access
+# NOTE: This test will only detect problems when run with clang sanitizer (which
+# is done regularly by a jenkins run).
+
+Import('env')
+
+env.NanopbProto('unaligned_uint64')
+
+p = env.Program(["unaligned_uint64.c",
+                 "unaligned_uint64.pb.c",
+                 "$COMMON/pb_encode.o",
+                 "$COMMON/pb_common.o"])
+env.RunTest(p)
+
diff --git a/tests/regression/issue_227/unaligned_uint64.c b/tests/regression/issue_227/unaligned_uint64.c
new file mode 100644 (file)
index 0000000..17c1d77
--- /dev/null
@@ -0,0 +1,14 @@
+#include "unaligned_uint64.pb.h"
+#include <pb_encode.h>
+
+int main()
+{
+    uint8_t buf[128];
+    pb_ostream_t stream = pb_ostream_from_buffer(buf, sizeof(buf));
+    MainMessage msg = MainMessage_init_zero;
+    msg.bar[0] = 'A';
+    pb_encode(&stream, MainMessage_fields, &msg);
+    
+    return 0;
+}
+
diff --git a/tests/regression/issue_227/unaligned_uint64.proto b/tests/regression/issue_227/unaligned_uint64.proto
new file mode 100644 (file)
index 0000000..f0269f6
--- /dev/null
@@ -0,0 +1,8 @@
+syntax = "proto3";
+import 'nanopb.proto';
+
+message MainMessage {
+    string foo = 1 [(nanopb).max_size = 3];
+    string bar = 2 [(nanopb).max_size = 8];
+}
+