Code Review
/
apps
/
agl-service-can-low-level.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(from parent 1:
4d19569
)
Remove a few resolved TODOs.
author
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Sat, 25 Jan 2014 01:50:39 +0000
(20:50 -0500)
committer
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Sat, 25 Jan 2014 01:50:39 +0000
(20:50 -0500)
src/uds/uds.c
patch
|
blob
|
history
diff --git
a/src/uds/uds.c
b/src/uds/uds.c
index
1a52db1
..
3295aaa
100644
(file)
--- a/
src/uds/uds.c
+++ b/
src/uds/uds.c
@@
-225,9
+225,6
@@
DiagnosticResponse diagnostic_receive_can_frame(DiagnosticShims* shims,
MAX(0, response.mode - MODE_RESPONSE_OFFSET),
response.pid, handle->request.mode,
handle->request.pid);
- // TODO just leave handles open until the user decides
- // to be done with it - keep a count of valid responses
- // received.
}
} else {
shims->log("Received an empty response on arb ID 0x%x",
@@
-238,8
+235,6
@@
DiagnosticResponse diagnostic_receive_can_frame(DiagnosticShims* shims,
handle->callback(&response);
}
- // TODO as of now we're completing the handle as soon as one
- // broadcast response is received....need to hang on for 100ms
break;
}
}