socket: Raise an error if open function failed.

The socket opening wasn't tested and we fails later on another function
using the wrongly opened socket. This would not happens anymore.

Bug-AGL: SPEC-2988

Change-Id: I9b30bd9fc13b99277cbef6f7aeaddadc57ad0b18
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

diff --git a/low-can-binding/utils/socketcan-j1939/socketcan-j1939.cpp b/low-can-binding/utils/socketcan-j1939/socketcan-j1939.cpp
index 3816325..660dffe 100644 (file)
--- a/low-can-binding/utils/socketcan-j1939/socketcan-j1939.cpp
+++ b/low-can-binding/utils/socketcan-j1939/socketcan-j1939.cpp
@@ -168,6 +168,8 @@ namespace utils
        {
 
                socket_ = socketcan_t::open(PF_CAN, SOCK_DGRAM, CAN_J1939);
+               if (socket_ < 0)
+                       return socket_;
 
                define_tx_address(device_name, name, pgn, addr);
 

diff --git a/low-can-binding/utils/socketcan.cpp b/low-can-binding/utils/socketcan.cpp
index 50dfafb..e8e0198 100644 (file)
--- a/low-can-binding/utils/socketcan.cpp
+++ b/low-can-binding/utils/socketcan.cpp
@@ -73,6 +73,9 @@ namespace utils
        {
                close();
                socket_ = ::socket(domain, type, protocol);
+               if (socket_ < 0)
+                       AFB_ERROR("Open failed. %s", strerror(errno));
+
                return socket_;
        }