Better handling of duplicate non recurring request
authorRomain Forlot <romain.forlot@iot.bzh>
Thu, 1 Jun 2017 16:18:07 +0000 (18:18 +0200)
committerRomain Forlot <romain.forlot@iot.bzh>
Thu, 1 Jun 2017 16:40:13 +0000 (18:40 +0200)
Change-Id: Ib6015d5dac66751622f3e287429475b6b708c3d5
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp

index 8ed8a78..f9dc960 100644 (file)
@@ -359,7 +359,8 @@ active_diagnostic_request_t* diagnostic_manager_t::add_request(DiagnosticRequest
                        diagnostic_request_to_string(&entry->get_handle()->request, request_string,
                                        sizeof(request_string));
 
-                       find_and_erase(entry, non_recurring_requests_);
+                       // Erase any existing request not already cleaned.
+                       cleanup_request(entry, true);
                        DEBUG(binder_interface, "%s: Added one-time diagnostic request on bus %s: %s", __FUNCTION__,
                                        bus_.c_str(), request_string);