Fix: double free issue

handle is already freed during the active_diagnostic_request destruction.

Bug-AGL: SPEC-2415

Change-Id: Ia26d5c9d2974ca34d411c3182b218141a84c8f21
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>

diff --git a/low-can-binding/diagnostic/diagnostic-manager.cpp b/low-can-binding/diagnostic/diagnostic-manager.cpp
index 55e6108..ba4b0c8 100644 (file)
--- a/low-can-binding/diagnostic/diagnostic-manager.cpp
+++ b/low-can-binding/diagnostic/diagnostic-manager.cpp
@@ -188,8 +188,6 @@ void diagnostic_manager_t::find_and_erase(active_diagnostic_request_t* entry, st
 void diagnostic_manager_t::cancel_request(active_diagnostic_request_t* entry)
 {
        entry->get_socket().close();
-       if(entry->get_handle())
-               delete(entry->get_handle());
        delete entry;
        entry = nullptr;
 }