Fix: exception unsubscribe all at start
authorRomain Forlot <romain.forlot@iot.bzh>
Tue, 6 Jun 2017 23:29:59 +0000 (01:29 +0200)
committerRomain Forlot <romain.forlot@iot.bzh>
Tue, 6 Jun 2017 23:29:59 +0000 (01:29 +0200)
When unsubscribing but no diagnostic subscription made there
is an exception when cleaning empty requests vector.

Change-Id: I40bdd01969fd1a1c6fecb0a438c46d0df584de83
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
CAN-binder/low-can-binding/diagnostic/diagnostic-manager.cpp

index ac91ae5..7dab749 100644 (file)
@@ -202,7 +202,7 @@ void diagnostic_manager_t::cancel_request(active_diagnostic_request_t* entry)
 /// @param[in] force - Force the cleaning or not ?
 void diagnostic_manager_t::cleanup_request(active_diagnostic_request_t* entry, bool force)
 {
-       if((force || (entry != nullptr && entry->response_received())))
+       if(entry != nullptr && (force || entry->response_received()))
        {
                char request_string[128] = {0};
                diagnostic_request_to_string(&entry->get_handle()->request,