Code Review
/
apps
/
agl-service-can-low-level.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
80c39d6
)
low-can: Fix init failing when using without J1939
40/23240/6
author
Romain Forlot
<romain.forlot@iot.bzh>
Thu, 28 Nov 2019 12:37:35 +0000
(13:37 +0100)
committer
Romain Forlot
<romain.forlot@iot.bzh>
Thu, 9 Jan 2020 15:25:36 +0000
(16:25 +0100)
Return variable was initialized to 1 instead of 0 and without using J1939
this variable isn't reaffected and so the final test fails.
Bug-AGL: SPEC-2386
Change-Id: I53b7cd757b3b344d66ab18ba9795284105cbcfcc
Signed-off-by: Romain Forlot <romain.forlot@iot.bzh>
low-can-binding/binding/low-can-cb.cpp
patch
|
blob
|
history
diff --git
a/low-can-binding/binding/low-can-cb.cpp
b/low-can-binding/binding/low-can-cb.cpp
index
20ed39d
..
aaf39d9
100644
(file)
--- a/
low-can-binding/binding/low-can-cb.cpp
+++ b/
low-can-binding/binding/low-can-cb.cpp
@@
-859,7
+859,7
@@
void list(afb_req_t request)
/// @return Exit code, zero if success.
int init_binding(afb_api_t api)
{
- int ret =
1
;
+ int ret =
0
;
application_t& application = application_t::instance();
can_bus_t& can_bus_manager = application.get_can_bus_manager();