Code Review
/
apps
/
low-level-can-service.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
76d13f3
)
Remove a resolved TODO.
author
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Fri, 3 Jan 2014 21:55:01 +0000
(16:55 -0500)
committer
Christopher Peplin
<chris.peplin@rhubarbtech.com>
Fri, 3 Jan 2014 21:55:01 +0000
(16:55 -0500)
src/obd2/obd2.c
patch
|
blob
|
history
diff --git
a/src/obd2/obd2.c
b/src/obd2/obd2.c
index
0590c1b
..
8a80da6
100644
(file)
--- a/
src/obd2/obd2.c
+++ b/
src/obd2/obd2.c
@@
-158,11
+158,6
@@
DiagnosticResponse diagnostic_receive_can_frame(DiagnosticShims* shims,
if(handle_negative_response(&message, &response, shims)) {
shims->log("Received a negative response to mode %d on arb ID 0x%x",
response.mode, response.arbitration_id);
-
- // TODO clarify what it means for a handle to be successful (we made
- // a good request+response) vs a request itself being
- // successfully
- // (the other node didn't return a negative response).
handle->success = true;
handle->completed = true;
} else if(handle_positive_response(handle, &message, &response,